From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89FC74414A; Mon, 3 Jun 2024 19:08:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DB4E42E5D; Mon, 3 Jun 2024 19:08:45 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 64A0E42E4A for ; Mon, 3 Jun 2024 19:08:44 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1f658800344so15089895ad.0 for ; Mon, 03 Jun 2024 10:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1717434523; x=1718039323; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XqqrGZ4CDLe8SWspuyYPChG+69xqxKwhp0/lJidiHHA=; b=eR6WF/+ZZbVFZiCfQ+8rc3x+X6NUvbA11yWeIFutpWVFsXWSKuigFJmurjOCokg8Ow +j68wz7OVF7TN2G0kJ033KfxPWMYAWhS7JQsF4J/f9kpY5lbWDDOqAfVv7NoclhkJt2C lSWx0MRlSxvVYNFGX67FJFaLg1ihuX5CxcfHNGa2ur7O17XIS7kzI0vmYXvaGM7sFRTt +5JwTMlW82vWBYZ+2l171tTy8i0ZfAA5yNFs4XR213YkY15F70HJLfXcEu2x6nalyrh1 qHTE7N6kFaND5jnfydVxAegr6pSIO5N76eUpj578ansBKrIqwsQU3qdHYsyCNaDw322N g9CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717434523; x=1718039323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XqqrGZ4CDLe8SWspuyYPChG+69xqxKwhp0/lJidiHHA=; b=s48+VqOOXN2AlELdquJEfutXbgvdbcf5wamahoZ43+OUXAo/ZYYy8eIH4rdm3+XjMH LW9qT7ubR1FzF5XHxApxe0lu8tbQ/hV9z6myAaRE1R5X+Sejr9V/zctGLrfDbIPWFGqE zpQ12pO8m5la5QjSwNiFc3jjTtVAxRF30QaRchIz0c/ISLyFWV00gBa9t6Ed+/9Vyqqd 6INsw6+dL5G9YeeQdYLb/iSBFOfgW7YQJqsXB1sbUxC0IKcmR6sqWMzLys6DJV/O924Y fpeni4X9uiR++G9U21FhspgDyKq1Vn7im2KBGOZmSLFnVlwTrEFWNN4bY/XA5MplX0uH IB8Q== X-Forwarded-Encrypted: i=1; AJvYcCV4113Pl6F3LRUCAEP6NKP0Nl0Wezd+G3jzhSSEG/MQCi2qR9LTcPJryU87TpSbQDGKYs22lAqb2qxoPos= X-Gm-Message-State: AOJu0YyA7tqx0HIkT+0c3FJW8v6T2fVyg/PBvEPChd8q1/E5lBUnKLKQ DaKrZK1hKsL7BN5USGbIyl3MmCOZXb8YHB25GhZxwemb8w4TBsMkDvToVT4NBKw= X-Google-Smtp-Source: AGHT+IEwbbgSSj3tI+NPc9t+72HSp6kTJtkifs8zPXRRFxq/0plRTT8WsBzUxUUVFmR/J+MgKZx4EA== X-Received: by 2002:a17:902:f652:b0:1f6:3c4f:2927 with SMTP id d9443c01a7336-1f63c4f2cd7mr152967735ad.38.1717434523450; Mon, 03 Jun 2024 10:08:43 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f63233909esm68064395ad.2.2024.06.03.10.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 10:08:43 -0700 (PDT) Date: Mon, 3 Jun 2024 10:08:41 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: Morten =?UTF-8?B?QnLDuHJ1cA==?= , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , dev@dpdk.org, Abdullah Sevincer , Pavan Nikhilesh , David Hunt , Vladimir Medvedkin Subject: Re: [RFC v3 5/5] eal: provide option to use compiler memcpy instead of RTE Message-ID: <20240603100841.09d8672e@hermes.local> In-Reply-To: References: <20240528074354.190779-1-mattias.ronnblom@ericsson.com> <20240602123921.363625-1-mattias.ronnblom@ericsson.com> <20240602123921.363625-6-mattias.ronnblom@ericsson.com> <98CBD80474FA8B44BF855DF32C47DC35E9F4E7@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 3 Jun 2024 19:04:49 +0200 Mattias R=C3=B6nnblom wrote: > >> static inline void > >> rte_mov32(uint8_t *dst, const uint8_t *src); =20 > >=20 > > While at it, would it be somehow beneficial to change these from uint8_= t* to void* or char* (keeping const where relevant)? > > =20 >=20 > Something to consider before doing such a change would be if it may=20 > cause any strict aliasing issue for existing users. >=20 > If we should break the API, I think we are better off removing=20 > rte_mov*() altogether. Why modify soon to be dead code. These should marked as deprecated in 24.11