From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D026744144; Tue, 4 Jun 2024 04:31:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A54B4433C6; Tue, 4 Jun 2024 04:31:32 +0200 (CEST) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by mails.dpdk.org (Postfix) with ESMTP id 4CBB543377 for ; Tue, 4 Jun 2024 04:31:31 +0200 (CEST) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-6c57fa82fdbso2576380a12.0 for ; Mon, 03 Jun 2024 19:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1717468290; x=1718073090; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7ffkSSGue+TLG2drHkQe7CHu49gXFub2DfGsb2l7lRc=; b=Sg7cIo+rH1eFaoo81O9NfQQ5a3O25jalyXs8F8HSZAklmY7BuDbpsk0rLSLEMS8sqv q6hKHHz/PdCNwqr4Y3JIF9ZRdlKsD8tBZNgKynQEUP9vxOGMTAMNyc+VHVZ3o2GzlLCG B/Q45b2lxUghZS127HRu65K0TryDFnFCU+3oTFraKrBHHdt1E9n5MuqzlSjexMumDSM8 fZkdAlwZCgSI/5UZep8itrftATg3vMYw8CwEqbjBlfMRWsCa6ClA6wzjw9/QETxUI9db BP0laBataKIdABrdqONvaGSSgncRxuEHVi5qfW4zGH2+AMbPvMq++BFUmRi6ngSXJsLI brMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717468290; x=1718073090; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ffkSSGue+TLG2drHkQe7CHu49gXFub2DfGsb2l7lRc=; b=nZ17zzdHpnQE2B6/tkRNvOC24fcAQoyNclwGaFt1YJZwKmx7ZwyVDmTITI014CoOJL 6KWQcLCp7PNaaor7tt2v9yiyL6CHZSJF6uFPKlwe/PCiUggzkktWBHD1DJaQB7hd7GUR A3AKo5PqQDzhHk62g7G5VYx+lNc5Cv/qN5Pw9Tz1I+r9bZPBmaYqA080hzBk6DKSPFg+ kdqqojvoLJihFqyzoVfuyX5oQ9tJk4z6AOL/F2dQe7SgyX7Dg0oxMjBCTLeQt1jvhBVY VXMY1PgM3EwHS0W42JSiFkhstsrqU7pTHxDhB2tsUIAq8FhRF3f+RqzSSepv2hTdo1ZC MUhw== X-Gm-Message-State: AOJu0Ywh3cZNF26emthBsxK4GSr0PW6VDRUOpLQqvM8EYZQKnCAHLQhN CpCVnY7ytwBdtyPZ2a4cm/f6futU7wyFolTg6RSeV3uvPLW5Abn+zcIG2t8y9rY8bbXVl9P4/A2 kIYvmdw== X-Google-Smtp-Source: AGHT+IGTnNmAFscc7CYcRGk7xrz9FTl1JIp4ffYni1ngFdTyVKagXQe8lJ88byLnCtGyGIUEoB4DAQ== X-Received: by 2002:a05:6a20:1059:b0:1af:e649:6f4 with SMTP id adf61e73a8af0-1b26f30e81cmr8637820637.57.1717468290158; Mon, 03 Jun 2024 19:31:30 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f632415710sm71327795ad.280.2024.06.03.19.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 19:31:29 -0700 (PDT) Date: Mon, 3 Jun 2024 19:31:28 -0700 From: Stephen Hemminger To: dev@dpdk.org Cc: Tyler Retzlaff , Dmitry Kozlyuk , Pallavi Kadam Subject: Re: [PATCH v21 02/14] windows: make getopt functions have const properties Message-ID: <20240603193128.0a26acf0@hermes.local> In-Reply-To: <20240604004731.6654-3-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240604004731.6654-1-stephen@networkplumber.org> <20240604004731.6654-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 3 Jun 2024 17:44:50 -0700 Stephen Hemminger wrote: > Having different prototypes on different platforms can lead > to lots of unnecessary workarounds. Looks like the version of > getopt used from windows was based on an older out of date > version from FreeBSD. > > This patch changes getopt, getopt_long, etc to have the same const > attributes as Linux and FreeBSD. The changes are derived from > the current FreeBSD version of getopt_long. > > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > Acked-by: Dmitry Kozlyuk Ignore checkpatch complaints about this file. It is better for the code to not change from the original FreeBSD.