From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F1C044144; Tue, 4 Jun 2024 04:37:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D794043377; Tue, 4 Jun 2024 04:37:48 +0200 (CEST) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by mails.dpdk.org (Postfix) with ESMTP id 646D0402D2 for ; Tue, 4 Jun 2024 04:37:47 +0200 (CEST) Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3d1f7593ddcso657590b6e.1 for ; Mon, 03 Jun 2024 19:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1717468666; x=1718073466; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7Kfv2234X+Hu7ymsU999XKcdsJrkhISUjImzuti+zGc=; b=zFUVeLCX5Qf612KiGc/62IDq27Bh+C3aCMlqPYJ93ZdI2AFBS4JqBCaW/NmOb1hizY iuLAPpRac9xEmHc4Y0z3kvRgjPnc5n8QMhM+2IV8X/M9MvYsCbKALrfc6hOBHA4rrsXo mVQy9+pQfZSmuXlBeRR4TmbjbT+OoiXUJ0zOl7H7vLsj/yjjuP2SOO+WzwuNWaeF9wLi X/wEfDQwqfv5EkMLtjnkPg9TvbHBWDWXnO1TElUjGKen3EV4A4+FqoRCPIcjVDE7IoQB DRQxtUInmipBfujh5q1NxyUEZgWndzZw4uVPK1i7jo3kH52g1PbYKmRqmdjqOrX94yPH su2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717468666; x=1718073466; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7Kfv2234X+Hu7ymsU999XKcdsJrkhISUjImzuti+zGc=; b=BjQ8ZHlH3Ie8u9e8LQqj8Be67s7GguJADMFOwomWd9sXE1TEnXrv1B5HzqqlvPyu5R vVYU3tHw5JKt90vAxyte0CSCueSqWGiLU/o0aUWf/iIeQh89LCDaDtvZTOmP3Ychi60Y sdiLoknT4Li5P6Mr2wWwqQHZyC5Rw90RXX66eTjDHt2bsoEzfrmJ0xwBEHicEnteiYbv PfeWp0omj7p8Kgu1uRdiOOJ6CgNWewTHf7drORCvt8EY0SRgJ7dTmWPnw4s2BpAbsJNi NwEwXMOaDsj0VfvLw3ijhDEhp8No4dK5j8JqyigknQCjco9J1I/P+72VHwIgPMXhAuUL MFNw== X-Gm-Message-State: AOJu0YxMM6XIZexxV1WRS2A9TpNVEc2AFzKIRwsOsMbB/KMWS6C/HbSD IDD5eKae2q3uLvGiq23CLhrv3MXtnuM4OcfcvYyOi8HL1phWmlrVLYgtvNEISss8UWz88aE/WLP KDrw= X-Google-Smtp-Source: AGHT+IGGqEW4WGhqKGTGwWr55ty5CIDn/1lW4gm1SFnnbwSWTRazt36Kzgwa6KEOHkIbBtLDDEBQbA== X-Received: by 2002:a05:6808:624d:b0:3c9:63d1:6fde with SMTP id 5614622812f47-3d1e35c1986mr11332413b6e.37.1717468666428; Mon, 03 Jun 2024 19:37:46 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7025958af78sm4068762b3a.130.2024.06.03.19.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 19:37:46 -0700 (PDT) Date: Mon, 3 Jun 2024 19:37:44 -0700 From: Stephen Hemminger To: dev@dpdk.org Cc: Tyler Retzlaff Subject: Re: [PATCH v21 14/14] log: colorize log output Message-ID: <20240603193744.62e0a4fd@hermes.local> In-Reply-To: <20240604004731.6654-15-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240604004731.6654-1-stephen@networkplumber.org> <20240604004731.6654-15-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 3 Jun 2024 17:45:02 -0700 Stephen Hemminger wrote: > Like dmesg, colorize the log output (unless redirected to file). > Timestamp is green, the subsystem is in yellow and the message > is red if urgent, boldface if an error, and normal for info and > debug messages. > > Signed-off-by: Stephen Hemminger Yet another valid patch that checkpatch complains about: 1. indent is correct, but it can't see #ifdefs 2. stdio is not a spelling error 3. it doesn't understand that FILE is a type, so it thinks it sees a multiply operator