From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18AE144136; Tue, 4 Jun 2024 02:47:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0F14402AC; Tue, 4 Jun 2024 02:47:45 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 5D0EA4021D for ; Tue, 4 Jun 2024 02:47:44 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f612d7b0f5so31428785ad.0 for ; Mon, 03 Jun 2024 17:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1717462063; x=1718066863; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AKaJ6vFHfDBIV8NsgQGkViLYKtbilkwi9Yd5JS4GxqY=; b=Yw46Xh6eTHTW78nQ3b3IQzE7irGACw/xkRrcuCmY3s1i1i5/Y25e9YNBDdXQcEB+1F saQuxb6iX9Y0l4eLTQYF/DcKdMVeHRyPxFOTAY09bT5M59sAuVe+vZgDnZAnpIl5HfCs QUlBr6IVlCQZIc3V33g6Dyn23LOQWaYWckt/SPIQtuO524EmpxLS99NwlMxLmLLaZLW/ I+05AkIuSZL907zGIMO1sJ6EYZhshh9vTm/uwsqmRW15HwHiWHnAeXx7xmlEnz2Zj8fC vsU74DRbqwgcD7z/dTrTO6UsC+db5nSNesM6m+924BG+kkUYIbKWFYCyznbs3pU0L3Hu vNKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717462063; x=1718066863; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AKaJ6vFHfDBIV8NsgQGkViLYKtbilkwi9Yd5JS4GxqY=; b=YZK5gD9+JX1cXsh5Hv1Ib9UrGYMRfBz5+Jpgdc2Pbf9NNR8KJnAtmbgi0pqVgKeL9R 8A0gn/2B/budRAZfAnERKfBhGWVf/ZeX8DqL9OBfT2oWU+VrQAT5elH9sfAka+HQKfXa iVpYhKzToOr0U9p3xYPBGsrSxKC3JIn5PZKOf9F0toz2LTK65Z+0W1PKoLHqqJ7HTUVo R/spRylfktpCWBBhrKhq1wv180ex89qabJb3pc9OCuyXSvYXzyb9W0QuvDLeM8CNNBO6 x8XLQi/Q2hkDkeP5O/V8Kuebl5hBDrS7TS8ds/ye4PZaCJ6TySAXhLtTjxNnQ1amrY5C 6syg== X-Gm-Message-State: AOJu0Ywt8Yf3UoHmTrIzeMR+T3qxauifO/sw60qn/7ncB76x6jsiPEQ0 UpvOL4oUJUiUQdtLfTh3GA8hcyaJL+PYO6HRBVSJdzH5n/OgKA7epUS9K8dQqtzLsxS6ddSmgEv m X-Google-Smtp-Source: AGHT+IHasB96gAOyeWzkIfXDo5U/MPvM06bqKXolEDHUY6lNoyCry4uJxrQv68KBFK84VsoD2iem1w== X-Received: by 2002:a17:902:f68b:b0:1f6:87f:1156 with SMTP id d9443c01a7336-1f692f7f9a4mr16749425ad.0.1717462063178; Mon, 03 Jun 2024 17:47:43 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6323e9aa7sm70381125ad.192.2024.06.03.17.47.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 17:47:42 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v21 00/14] Log library unification ane enhancements Date: Mon, 3 Jun 2024 17:44:48 -0700 Message-ID: <20240604004731.6654-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20200814173441.23086-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of startup codes. Timestamp is optional and must be enabled on command line. * Displaying console output with colors. It uses the standard conventions used by many other Linux commands for colorized display. The default is to enable color if the console output is going to a terminal. But it can be always on or disabled by command line flag. This default was chosen based on what dmesg(1) command does. Color is used by many tools (vi, iproute2, git) because it is helpful; DPDK drivers and libraries print lots of not very useful messages. And having error messages highlighted in bold face helps. This might also get users to pay more attention to error messages. Many bug reports have earlier messages that are lost because there are so many info messages. * Add support for automatic detection of systemd journal protocol. If running as systemd service will get enhanced logging. * Use of syslog is optional and the meaning of the --syslog flag has changed. The default is *not* to use syslog if output is going to a terminal. Add myself as maintainer for log because by now have added more than previous authors. v21 - rebase and clean up a couple of blank lines that snuck in Stephen Hemminger (14): maintainers: add for log library windows: make getopt functions have const properties windows: add os shim for localtime_r eal: make eal_log_level_parse common eal: do not duplicate rte_init_alert() messages eal: change rte_exit() output to match rte_log() log: move handling of syslog facility out of eal eal: initialize log before everything else log: drop syslog support, and make code common log: add hook for printing log messages log: add timestamp option log: add optional support of syslog log: add support for systemd journal log: colorize log output MAINTAINERS | 1 + app/test/test_eal_flags.c | 64 +++++- doc/guides/linux_gsg/linux_eal_parameters.rst | 27 --- doc/guides/prog_guide/log_lib.rst | 72 ++++++ lib/eal/common/eal_common_debug.c | 11 +- lib/eal/common/eal_common_options.c | 136 +++++++----- lib/eal/common/eal_options.h | 7 + lib/eal/freebsd/eal.c | 64 ++---- lib/eal/linux/eal.c | 68 ++---- lib/eal/windows/eal.c | 49 +--- lib/eal/windows/getopt.c | 23 +- lib/eal/windows/include/getopt.h | 8 +- lib/eal/windows/include/rte_os_shim.h | 10 + lib/log/log.c | 80 ++++--- lib/log/log_color.c | 148 ++++++++++++ lib/log/log_freebsd.c | 12 - lib/log/log_internal.h | 28 ++- lib/log/log_journal.c | 200 +++++++++++++++++ lib/log/log_linux.c | 61 ----- lib/log/log_private.h | 34 +++ lib/log/log_stubs.c | 37 +++ lib/log/log_syslog.c | 88 ++++++++ lib/log/log_timestamp.c | 210 ++++++++++++++++++ lib/log/log_windows.c | 18 -- lib/log/meson.build | 14 +- lib/log/version.map | 5 +- 26 files changed, 1097 insertions(+), 378 deletions(-) create mode 100644 lib/log/log_color.c delete mode 100644 lib/log/log_freebsd.c create mode 100644 lib/log/log_journal.c delete mode 100644 lib/log/log_linux.c create mode 100644 lib/log/log_private.h create mode 100644 lib/log/log_stubs.c create mode 100644 lib/log/log_syslog.c create mode 100644 lib/log/log_timestamp.c delete mode 100644 lib/log/log_windows.c -- 2.43.0