From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FBB044136; Tue, 4 Jun 2024 02:48:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 590E4432DE; Tue, 4 Jun 2024 02:47:53 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id DBAD2432B6 for ; Tue, 4 Jun 2024 02:47:48 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1f62217f806so42558785ad.2 for ; Mon, 03 Jun 2024 17:47:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1717462068; x=1718066868; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=; b=Uxr+/+rp5Fqqaj44SLBHd4y+YKLAdPZnkuSwpyeosSYv17BKtG4ojaJKNIG42DZtmx mbJW1GM+daYv37zoVU6giSxYWoOcXLe9i8pRhfGrl2tHqc/MuqKRfsdXqyVE9H3Nk2AB FLXh1oXIp92CKzMCNVYVCw+2apwCjAYbFitMY+x7XtWXsEcq/RFCbFhGEIPpkgbmVGxT tVLLv5bcIjY5MR8HuA3qnTyj1uJ0DwxSiZIjZRfvxZQnVNZvTNlEabHtsEVvF2t1gDTm TgFlCAGsUtiBsk/zsqvGNbNIfCbZV3L5zep1/ukcFBHjayr13F1udSIhjfpAcDlUBWpc 5flQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717462068; x=1718066868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jpuKRgSOIbpBBbsAGPHwAR/lg4j9u3JMjpynNGAPSTY=; b=s83SPfa0R4PlwrLUCPgRZ/Y19ragmG0CsB+YK0q8tJGfmUX3Z0L48YFnq4PGp/pPxe wLwvqHu1QHySle0MeEk86ED+BiCrpdH1UJVEogOrOmuG2ldwmdNuDLjPvMnUHdw+uVnq 9RBA1taPgNJQzn7/iEXKM3SJvMLzTxZaZwP9Uv0r+RDGwBSO4iNg/E+9lOKMaLbSlk+M Ch5mV9mHUOjzJ7pXOUz6j1M1mR2msVYzW1YPPWfiWz+CcawMbsVPHYvZbPLlxVkx0Qlb uLVPrrWmQCTrpK1hWt8iUSc70EYX0j7ZF9eiyy4alCdWNoVh6YSmCiK7YJVxtN1K5x5v +MQw== X-Gm-Message-State: AOJu0YwlwdYhrHH9MJ49XNdODWRAiDVQwccVaZrsB3tPNQ6XnbpOsdKr XjGX08A3fVHzGdfQpd5xgZOnepGoX/b/8uAQvtsyLM51p2/3Aaq4V2yO9Ulj6ZgZbVet8bVb8HU R X-Google-Smtp-Source: AGHT+IFVxtMATl3gr1zjYybU0nvL/RMURTWE3gHDkqgOrmO7y87tug2wBc6W3mXIkfe5lzN7yJvlxg== X-Received: by 2002:a17:903:1c9:b0:1f3:4225:bb79 with SMTP id d9443c01a7336-1f636fc54a4mr144972905ad.2.1717462068110; Mon, 03 Jun 2024 17:47:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6323e9aa7sm70381125ad.192.2024.06.03.17.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 17:47:47 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , Bruce Richardson Subject: [PATCH v21 05/14] eal: do not duplicate rte_init_alert() messages Date: Mon, 3 Jun 2024 17:44:53 -0700 Message-ID: <20240604004731.6654-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240604004731.6654-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240604004731.6654-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index 9825bcea0b..17b56f38aa 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index bffeb1f34e..23dc26b124 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.43.0