From: Gavin Li <gavinl@nvidia.com>
To: <matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,
<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>, <rasland@nvidia.com>
Subject: [V2 1/2] net: extend VXLAN header to support more extensions
Date: Tue, 4 Jun 2024 09:27:44 +0300 [thread overview]
Message-ID: <20240604062746.355383-2-gavinl@nvidia.com> (raw)
In-Reply-To: <20240604062746.355383-1-gavinl@nvidia.com>
Currently, DPDK supports VXLAN and VXLAN-GPE with similar header
structures and we are working on adding support for VXLAN-GBP which is
another extension to VXLAN. More extension of VXLAN may be added in the
future.
VXLAN and VXLAN-GBP use the same UDP port(4789) while VXLAN-GPE uses a
different one, 4790. The three protocols have the same header length and
overall similar header structure as below.
0 1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|R|R|R|R|I|R|R|R| Reserved |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| VXLAN Network Identifier (VNI) | Reserved |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Figure 1: VXLAN Header
0 1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|R|R|Ver|I|P|B|O| Reserved |Next Protocol |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| VXLAN Network Identifier (VNI) | Reserved |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Figure 2: VXLAN-GPE Header
0 1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|G|R|R|R|I|R|R|R|R|D|R|R|A|R|R|R| Group Policy ID |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| VXLAN Network Identifier (VNI) | Reserved |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Figure 3: VXLAN-GBP Extension
Both VXLAN-GPE and VXLAN-GBP extended VXLAN by redefining its reserved
bits, which means the packets can be processed with same pattern and most
of the code can be reused. Instead of adding more new items by
copying/pasting code for the VXLAN extensions in the future, it’s better
to use existing VXLAN infrastructure and add support code in it.
In this patch, all the VXLAN extension header will be merged with VXLAN as
union if the overlapped field has different format among protocols. The
existing VXLAN-GPE will be marked as deprecated and new extensions of
VXLAN should be added to VXLAN instead of a new RTE item.
Signed-off-by: Gavin Li <gavinl@nvidia.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/ethdev/rte_flow.h | 20 +++++++++--
lib/net/rte_vxlan.h | 83 +++++++++++++++++++++++++++++++++++++------
2 files changed, 90 insertions(+), 13 deletions(-)
diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index 6e8ab1d4c7..b27d5aa94c 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -355,6 +355,9 @@ enum rte_flow_item_type {
RTE_FLOW_ITEM_TYPE_GENEVE,
/**
+ * @deprecated
+ * @see RTE_FLOW_ITEM_TYPE_VXLAN
+ *
* Matches a VXLAN-GPE header.
*
* See struct rte_flow_item_vxlan_gpe.
@@ -1103,7 +1106,12 @@ static const struct rte_flow_item_sctp rte_flow_item_sctp_mask = {
/**
* RTE_FLOW_ITEM_TYPE_VXLAN.
*
- * Matches a VXLAN header (RFC 7348).
+ * Matches a VXLAN header (RFC 7348),
+ * including GPE (draft-ietf-nvo3-vxlan-gpe-13.txt)
+ * and GBP (draft-smith-vxlan-group-policy-05.txt).
+ *
+ * GPE is distinguished with its UDP port.
+ * UDP port may be specified with ``rte_eth_dev_udp_tunnel_port_add()``.
*/
struct rte_flow_item_vxlan {
union {
@@ -1346,6 +1354,9 @@ static const struct rte_flow_item_geneve rte_flow_item_geneve_mask = {
#endif
/**
+ * @deprecated
+ * @see rte_flow_item_vxlan
+ *
* RTE_FLOW_ITEM_TYPE_VXLAN_GPE (draft-ietf-nvo3-vxlan-gpe-05).
*
* Matches a VXLAN-GPE header.
@@ -1367,7 +1378,12 @@ struct rte_flow_item_vxlan_gpe {
};
};
-/** Default mask for RTE_FLOW_ITEM_TYPE_VXLAN_GPE. */
+/**
+ * @deprecated
+ * @see rte_flow_item_vxlan_mask
+ *
+ * Default mask for RTE_FLOW_ITEM_TYPE_VXLAN_GPE.
+ */
#ifndef __cplusplus
static const struct rte_flow_item_vxlan_gpe rte_flow_item_vxlan_gpe_mask = {
.hdr.vni = "\xff\xff\xff",
diff --git a/lib/net/rte_vxlan.h b/lib/net/rte_vxlan.h
index 997fc784fc..8ce93ae569 100644
--- a/lib/net/rte_vxlan.h
+++ b/lib/net/rte_vxlan.h
@@ -23,27 +23,80 @@ extern "C" {
/** VXLAN default port. */
#define RTE_VXLAN_DEFAULT_PORT 4789
+/** VXLAN GPE port. */
#define RTE_VXLAN_GPE_DEFAULT_PORT 4790
/**
* VXLAN protocol header.
* Contains the 8-bit flag, 24-bit VXLAN Network Identifier and
- * Reserved fields (24 bits and 8 bits)
+ * extensions (Generic Protocol Extension, Group Based Policy).
*/
__extension__ /* no named member in struct */
struct rte_vxlan_hdr {
union {
+ rte_be32_t vx_flags; /**< flags (8 bits) + extensions (24 bits). */
struct {
- rte_be32_t vx_flags; /**< flags (8) + Reserved (24). */
- rte_be32_t vx_vni; /**< VNI (24) + Reserved (8). */
- };
+ union {
+ uint8_t flags; /**< Default is I bit, others are extensions. */
+ struct {
+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+ uint8_t flag_g:1, /**< GBP bit. */
+ flag_rsvd:1, /* Reserved. */
+ flag_ver:2, /**< GPE Protocol Version. */
+ flag_i:1, /**< VNI bit. */
+ flag_p:1, /**< GPE Next Protocol bit. */
+ flag_b:1, /**< GPE Ingress-Replicated BUM. */
+ flag_o:1; /**< GPE OAM Packet bit. */
+#elif RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
+ uint8_t flag_o:1,
+ flag_b:1,
+ flag_p:1,
+ flag_i:1,
+ flag_ver:2,
+ flag_rsvd:1,
+ flag_g:1;
+#endif
+ } __rte_packed;
+ }; /* end of 1st byte */
+ union {
+ uint8_t rsvd0[3]; /* Reserved for extensions. */
+ struct {
+#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+ uint8_t rsvd0_gbp1:1, /* Reserved. */
+ flag_d:1, /**< GBP Don't Learn bit. */
+ rsvd0_gbp2:2, /* Reserved. */
+ flag_a:1, /**< GBP Applied bit. */
+ rsvd0_gbp3:3; /* Reserved. */
+#elif RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN
+ uint8_t rsvd0_gbp3:3,
+ flag_a:1,
+ rsvd0_gbp2:2,
+ flag_d:1,
+ rsvd0_gbp1:1;
+#endif
+ union {
+ uint16_t policy_id; /**< GBP Identifier. */
+ struct {
+ uint8_t rsvd0_gpe; /* Reserved. */
+ uint8_t proto; /**< GPE Next protocol. */
+ /* 0x01 : IPv4
+ * 0x02 : IPv6
+ * 0x03 : Ethernet
+ * 0x04 : Network Service Header
+ */
+ } __rte_packed;
+ };
+ } __rte_packed;
+ };
+ } __rte_packed;
+ }; /* end of 1st 32-bit word */
+ union {
+ rte_be32_t vx_vni; /**< VNI (24 bits) + reserved (8 bits). */
struct {
- uint8_t flags; /**< Should be 8 (I flag). */
- uint8_t rsvd0[3]; /**< Reserved. */
- uint8_t vni[3]; /**< VXLAN identifier. */
- uint8_t rsvd1; /**< Reserved. */
- };
- };
+ uint8_t vni[3]; /**< VXLAN Identifier. */
+ uint8_t rsvd1; /* Reserved. */
+ } __rte_packed;
+ }; /* end of 2nd 32-bit word */
} __rte_packed;
/** VXLAN tunnel header length. */
@@ -52,6 +105,9 @@ struct rte_vxlan_hdr {
/**
+ * @deprecated
+ * @see rte_vxlan_hdr
+ *
* VXLAN-GPE protocol header (draft-ietf-nvo3-vxlan-gpe-05).
* Contains the 8-bit flag, 8-bit next-protocol, 24-bit VXLAN Network
* Identifier and Reserved fields (16 bits and 8 bits).
@@ -75,7 +131,12 @@ struct rte_vxlan_gpe_hdr {
};
} __rte_packed;
-/** VXLAN-GPE tunnel header length. */
+/**
+ * @deprecated
+ * @see RTE_ETHER_VXLAN_HLEN
+ *
+ * VXLAN-GPE tunnel header length.
+ */
#define RTE_ETHER_VXLAN_GPE_HLEN (sizeof(struct rte_udp_hdr) + \
sizeof(struct rte_vxlan_gpe_hdr))
--
2.34.1
next prev parent reply other threads:[~2024-06-04 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 6:27 [V2 0/2] " Gavin Li
2024-06-04 6:27 ` Gavin Li [this message]
2024-06-05 8:09 ` [V3 " Gavin Li
2024-06-05 8:09 ` [V3 1/2] " Gavin Li
2024-06-05 8:09 ` [V3 2/2] app/testpmd: support matching any VXLAN field Gavin Li
2024-06-11 14:53 ` [V3 0/2] net: extend VXLAN header to support more extensions Ferruh Yigit
2024-06-04 6:27 ` [V2 2/2] app/testpmd: introduce VXLAN-GBP and VXLAN-GPE fields Gavin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240604062746.355383-2-gavinl@nvidia.com \
--to=gavinl@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).