From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAB0044153; Tue, 4 Jun 2024 14:14:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F133436A2; Tue, 4 Jun 2024 14:13:17 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2071.outbound.protection.outlook.com [40.107.212.71]) by mails.dpdk.org (Postfix) with ESMTP id 1B6844369C for ; Tue, 4 Jun 2024 14:13:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h3PQaDl8Cy2k+kcLTvd3N+VPf/Z0EduEAcnYT/JIHyfLwyAjCgmaBxVi4YASmjnFpNZsfptSTU9ZOp19lMnMERjOij0g4KDMg2yf8eXs1H9C/CB8ob2KytPe4DaWrn6iQqmU+NIQHByhAygC9MnAfwn8YlbR1m12EAlBIHVLwp08PRMDBqfMKGPt72dfGXeCObaY9pXJWdY/V1DTlWgP3hehP9InGODBBmfW+pV5veT9ke+42jv6mbuQCtgSIvojN6fZkaiVKIopKgK1AmZLTWMeuzTINcJ5nmWiiJk9yyPR4OibPTU+bYf49u8vTavBLw8dim94m8MMiS+/C4MJIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jEFRhwuTmECdTGuHmYHbBFjfNUPcNxGmQZqJ4Kmozqc=; b=H+ocmD/J2/6HolCL4kNUYNR1eOfBPc1eeSUwTelwkVRcfnHP/lK+LPlubF2q+FSYUmnQ5oeOGfNHUrBEAiS8vozeuD27CCYUrl8eRJXHUDQnilQ6PVN6FtX5I6pmJyD4o0b0IhhsCMhbrY6WKB08orQ57AcTSre4zdWtdATyackYPOIvs4wZk0ZLFnarHsPS67Dw05NLxkTBAe+0U3DcBSUM91h97awc9hlNSSJ05YyBaMZ9zs0tYBH8kv0qIXz3jLnVJIRr1GHez3OLjF0dacSi9VyYJkWH8xn5tl1f/KzDbtI2JfavFttIJ/UkOXGffGMvsXqoRfgVDZxiG2hjAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jEFRhwuTmECdTGuHmYHbBFjfNUPcNxGmQZqJ4Kmozqc=; b=KfHJBMt/Vl9LskXA/1mrG8NrbiFy0TW+E3n0g1499vfk7Fc2r2V26Ma1gXGuHKDexB4V+wPlfdnKPA/maqmROiFGHfRlHDzCPfBwu+o+dJNRNlc6R/z5aBmJSLvQzD18pThQvrqAilSXppxdrX8m0BN8S1oyN47FFhuq510Kp34= Received: from MN2PR10CA0004.namprd10.prod.outlook.com (2603:10b6:208:120::17) by PH8PR12MB6818.namprd12.prod.outlook.com (2603:10b6:510:1c9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.26; Tue, 4 Jun 2024 12:13:10 +0000 Received: from BN3PEPF0000B372.namprd21.prod.outlook.com (2603:10b6:208:120:cafe::87) by MN2PR10CA0004.outlook.office365.com (2603:10b6:208:120::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.31 via Frontend Transport; Tue, 4 Jun 2024 12:13:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN3PEPF0000B372.mail.protection.outlook.com (10.167.243.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.0 via Frontend Transport; Tue, 4 Jun 2024 12:13:10 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 4 Jun 2024 07:13:07 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande , Selwin Sebastian Subject: [PATCH v3 15/25] net/axgbe: remove field of SFP diagnostic support Date: Tue, 4 Jun 2024 17:41:47 +0530 Message-ID: <20240604121157.3052-15-venkatkumar.ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240604121157.3052-1-venkatkumar.ande@amd.com> References: <20240507124305.2318-1-VenkatKumar.Ande@amd.com> <20240604121157.3052-1-venkatkumar.ande@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B372:EE_|PH8PR12MB6818:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e89fb3d-ad18-462c-3550-08dc848fb35c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|376005|1800799015|82310400017; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YxzxQHI3c1QBJXDzGeGybCO2PWnrzVRrLI9QVAt/yyYPGvVYKvVGo6yfdPSc?= =?us-ascii?Q?Hp71uE2FSYUk3qDO/Q/H92IujRDaEbU6ztz2LrJBnZ/fyxXB8MkxGPS+uyon?= =?us-ascii?Q?HLQPHZTzH0Scnhqi3jyintTFKfrxSrY3vjo0IRrWv974cP7oe0TDFxsWnkyf?= =?us-ascii?Q?CF7r0a0mgKx+rhfibqz8icb5pacuose0zO/TamFdazO5HdALlc7kFBM0hwjA?= =?us-ascii?Q?NUA72Jess8Ssxsjpq2/oVLFFZ8U9ta3zbLscUrqXrEjXyKNWCZ1GjadcLMAc?= =?us-ascii?Q?hMNHZEMxGuRVTtRlOe8ca8NlhVIEP8lnGjr748TFfEe8Z3wgfjf7VjDfC5Uf?= =?us-ascii?Q?anDb7be331W6fZfYx+bHUevHEXK4aIX2W6ZY9snv3nWfCGznfeDr6Da5oDAe?= =?us-ascii?Q?wG0RIsFsGVlvmZEX2UeRouC6OWvWUHN/p1kdcO+uRkQdi4B9cTHJ3mJTM9w+?= =?us-ascii?Q?vzLp9GtJpfZs4USCBb1fVUCkiR0sMtltbYW5vHsM6dyxlNuY+RtiuJjw7W08?= =?us-ascii?Q?qmBc0F6AuT8DElTnwIlboZvV3PgQlwvjJPm3y5/T3lJGnGqzRKj683DDho2f?= =?us-ascii?Q?PJMqD9nVT5fBy6mDMD06pDol53q9/EeKnouaBlZN5/u95qPsPC8zSRlphI74?= =?us-ascii?Q?tRrxIXXKp9z63lgXbePsbjA8UHHLBFYiQgvzpBSt1SMCsqyYDI1ofl7YOocZ?= =?us-ascii?Q?dMwGv1jT1VU6aRDzCrofB/RT7zPF4uWqplKMg7GXi70YreoatMpHgCYn8koI?= =?us-ascii?Q?+zhm+giOAd7Zlq2s10Z9wszsp2zDI+goKgTmPn+iLVmOetcyJYgBny/l20Zo?= =?us-ascii?Q?+X8o+g0sE5pVYVT10cFlbKOnJTEU9XShDFKNOXUVkBtH81k9PLPHnRaDYT76?= =?us-ascii?Q?NGBg11GpRP1b++BAyxMg69yoJ2V4K7Z/QNZdswlQJWKjEoF7o0gtuMt6Apxn?= =?us-ascii?Q?U5erB4SfQ0I2aWR2IJtBNHExcn6JxgwtVpkbsOLk46hPey6sYByCaFhEf6q0?= =?us-ascii?Q?TCLPcXSJrSZhyZRObRaebWspWsOKdazyTQOh6URWLS6MMj2g19rNViSpS6Vs?= =?us-ascii?Q?X75wEvMaGotRoWQ9Kn77V6DZ5ltbK37STVC7EqN72LfFagfKLf1OqeBDtm4d?= =?us-ascii?Q?STEFGkWvwAbqF3Zz9Gh7s+PDoYJYCHJ6GGkXi5XqW/zWz67wfwzd6OErH2rq?= =?us-ascii?Q?b9P8VRYZ2AteyOBf1jdo4VN7W0I+UKLUc9zGHgnFb8KRyWhbAFKgWC1fR2YU?= =?us-ascii?Q?tRgDhZye78F2UKlaM+qaM7/LY14rQZuF70m3hyNHX0wWyh9IuAGDHnmUaIyg?= =?us-ascii?Q?v2a9sXG0bMTo5JSgvWU+IaP1G6EmciBLeTIXjk791BeDoPYBCe9mMfyOWT7O?= =?us-ascii?Q?/EiYLWhVsV/bbwP263iiFaTVZcyQ?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(376005)(1800799015)(82310400017); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 12:13:10.3653 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3e89fb3d-ad18-462c-3550-08dc848fb35c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B372.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6818 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Venkat Kumar Ande The driver currently sets an indication of whether the SFP supports, and that the driver can obtain, diagnostics data. This isn't currently used by the driver. Remove this field and the logic supporting it. Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 30727ee5a4..73cdcdc49d 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -219,7 +219,6 @@ struct axgbe_phy_data { unsigned int sfp_rx_los; unsigned int sfp_tx_fault; unsigned int sfp_mod_absent; - unsigned int sfp_diags; unsigned int sfp_changed; unsigned int sfp_phy_avail; unsigned int sfp_cable_len; @@ -702,14 +701,6 @@ static int axgbe_phy_sfp_read_eeprom(struct axgbe_port *pdata) if (memcmp(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom))) { phy_data->sfp_changed = 1; memcpy(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom)); - - if (sfp_eeprom.extd[AXGBE_SFP_EXTD_SFF_8472]) { - uint8_t diag_type; - diag_type = sfp_eeprom.extd[AXGBE_SFP_EXTD_DIAG]; - - if (!(diag_type & AXGBE_SFP_EXTD_DIAG_ADDR_CHANGE)) - phy_data->sfp_diags = 1; - } } else { phy_data->sfp_changed = 0; } @@ -770,7 +761,6 @@ static void axgbe_phy_sfp_reset(struct axgbe_phy_data *phy_data) phy_data->sfp_rx_los = 0; phy_data->sfp_tx_fault = 0; phy_data->sfp_mod_absent = 1; - phy_data->sfp_diags = 0; phy_data->sfp_base = AXGBE_SFP_BASE_UNKNOWN; phy_data->sfp_cable = AXGBE_SFP_CABLE_UNKNOWN; phy_data->sfp_speed = AXGBE_SFP_SPEED_UNKNOWN; -- 2.34.1