From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08B8744153; Tue, 4 Jun 2024 14:15:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E806B436E6; Tue, 4 Jun 2024 14:13:50 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2050.outbound.protection.outlook.com [40.107.101.50]) by mails.dpdk.org (Postfix) with ESMTP id EA97543718 for ; Tue, 4 Jun 2024 14:13:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TTk9Dw6R29Vlti3GV6hixUkeAVH5DazM28joThcke0QrnEURbE/ZQ6IY9Ae7RyQS5TbHjikkRz8gDZvjFZLq8moUNK9SwRXRNLKIo1/Un7pqdWbIlAXipjdo0eJx+a6MIRo/UNGlgLibl/qu1FUkFODreA461aPGFlCMG7cRw9AnZHVdklkGAmHc4UTclCjfcsnhOD3NqLWruoR7MLMTNJXA4MAKE+WfrXcJJtTZYh6TN3qWLSz8/C7RI9naSTiSLxMa1gPCf5955Sogta3axeopKKetFKTrGUnsLLiJaHyf9K15hh02APg5pUzReDHYPBcUqv39xleFRYfbX/GvbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6gjM/aMv/xEH8M9Lamy3jliyAx+7CYcvV9il7EcruAo=; b=Fk/OTnnu/+o/r3DRhB/A3ujB1ZObh5tjoFCa6irfa4IDrXBt86q01A4NBDfs83zcLXvo+5AFPGcdEkARONM7KKexz+w6ImTBAWxjS8lzg7UvMG10ejgo+LtEKcPu8JC4nswN1Sl9JoZnXnmNoJ/Fl90IoK2IYU65EYsR24cKJyStfQZvr+U9M6NILnTkAfDekIR9aImpr1iRjlQoHqRYP/Hr68wcdAGrOSFpTKotMCAReYlCiiJ1kUFKlMWHgJqYf783A9UVgzc8ipQTgcqZYNmzmBoSeaYKbBeeQpQHDOLiUhry6DbvTezpYKtbpCBY3B1hmhKnmsGHTsAAsxyYDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gjM/aMv/xEH8M9Lamy3jliyAx+7CYcvV9il7EcruAo=; b=5qQZZBD8Kq92BMlzgultPfNt/jkooP535YKUPehaDXkyaMRUDfDwB+2ydX0k7pDyIlodn5o1AftytA7QHCKE8vEVJFErVWdjHjixg0Bv9uY3vd8tGRZAlQgSkK117lkFu9lgb7lrHL0MIG2XJP/KoaLHoiYmmUFM17gXitVkMmE= Received: from MN2PR18CA0012.namprd18.prod.outlook.com (2603:10b6:208:23c::17) by BY5PR12MB4210.namprd12.prod.outlook.com (2603:10b6:a03:203::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.28; Tue, 4 Jun 2024 12:13:46 +0000 Received: from BN3PEPF0000B372.namprd21.prod.outlook.com (2603:10b6:208:23c:cafe::69) by MN2PR18CA0012.outlook.office365.com (2603:10b6:208:23c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.30 via Frontend Transport; Tue, 4 Jun 2024 12:13:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN3PEPF0000B372.mail.protection.outlook.com (10.167.243.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.0 via Frontend Transport; Tue, 4 Jun 2024 12:13:46 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 4 Jun 2024 07:13:44 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande , Selwin Sebastian Subject: [PATCH v3 25/25] net/axgbe: modify debug messages Date: Tue, 4 Jun 2024 17:41:57 +0530 Message-ID: <20240604121157.3052-25-venkatkumar.ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240604121157.3052-1-venkatkumar.ande@amd.com> References: <20240507124305.2318-1-VenkatKumar.Ande@amd.com> <20240604121157.3052-1-venkatkumar.ande@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B372:EE_|BY5PR12MB4210:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b7b9ec5-d9f5-48bf-1a17-08dc848fc8c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|82310400017|1800799015|36860700004|376005; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jTQadtkMdkE5DwaKTYqHclGMQlZj9BewsEFEkdj55jKaFhaQxu3jgfqJMaVb?= =?us-ascii?Q?KKvdxnfIiVzZgNRVI9mgRgKTynD57vIbllqhTmuOA9EQbMle5++vAQnrE15U?= =?us-ascii?Q?/qgJ4G2yuAwtjiz9p8zNeZ0cCZIOB9berQQv9AvS8omBuIaDJDja+XHspy52?= =?us-ascii?Q?hADotEAFR0QGYWBDFRzqDWn9KH0fJG/sfLXt116H7Cz5TpeXtkxfqYMjRacz?= =?us-ascii?Q?JsHB3+RukrbXwAZ6S5mB9GwlAh7df5Uz7FiB6vqcU5gB59M3YpV5g17M3P2m?= =?us-ascii?Q?nZCoAEvQPSBPzFRaBkWfjlLoagcxTWsb1j3v30/oE3kSv4rjcl34H3vIG0jQ?= =?us-ascii?Q?Zo2HwhihUORtI1qy4lCLHom2+lwhOL5yCltWlSgT1aPGDftzv7Hocll7UN9S?= =?us-ascii?Q?HTeDSHyon+evBJAvY8noSicqNa4eCLEwJcGqoZzWpFRVKRM50ZnqIMdXjZfU?= =?us-ascii?Q?cAWtWM8FUilnt4gaz7NfMOVS7CRPTMJtWfEnvemyNECbWmDPb5uGIumvolOx?= =?us-ascii?Q?LKh2UgVqH4P19gA9M7qqDLXAW+EW16RflG8J7a7tCOWLgvm2WbsZ98JRgtgq?= =?us-ascii?Q?MpXnwC6aMngkl4dv03HQGfLms53ToLInD5bYacp0VWnwYwLrBYTIwutiX416?= =?us-ascii?Q?7R+rQv8iCEv4jDviofk9dTHSluuRoMFz5h3B09UIUmitNXtNdzgIeBFWt9cs?= =?us-ascii?Q?2i4lbkQGFz7YWNV417xS0JcjqXrqrbsNVkQt2kvplZRbvk0ZbVLXzVpsk+yt?= =?us-ascii?Q?U8giSy0NJMh0doy+pR2FUEHIzLPgZauy2rIboDnxCQLWFJ4G6Soc88deX+du?= =?us-ascii?Q?rCxXP9AJNPmGazHsAp4Ey3UXrkG5yFDu/YDPsEByRRTKzch60JyiVCktKw7m?= =?us-ascii?Q?XrzFovXCDcjsWsa7uuImKgW5FDZ+OIjY1/hgIJyY9ybu3EAq0byEZ3NwGqpN?= =?us-ascii?Q?F59dwtijN6nV/eNNBARZC1UpwSUm4FVCpqu+6rviRQJ+PSXs4DyCGdCRbae6?= =?us-ascii?Q?4eJPakCDWNKHAETe4klNBN+L/5Hx83a6w3V+mZ2Es8EGO9BrHVx3KlfuhrLf?= =?us-ascii?Q?Wt8yMLlVZ4hWNJzbqpyajJ8H4UAOjlhjavjxn1AwdZr+z4FzjGamUHEg/Vse?= =?us-ascii?Q?m+4+AnuElX0ZnCw7QBux2kqCdJuEhwwugm7N7IzE3vlNAdltskV49+mcc5MK?= =?us-ascii?Q?OqhVqsR0R5poKg6QoxKesw2uV/CSHBquVQTB3gvbR5+lwV4Zmxba0oC8Lmgr?= =?us-ascii?Q?FU9v3wkCEA0KOVsIlIrbKLlmBBqsrqU1yoWudQtDpgOUrmqj4b6bnzVAQJYM?= =?us-ascii?Q?pv6NCpfOEwNq2ULE7komen+SOh61eiR4BqJ+olreeENo5gtjDK/kM6JLFOMl?= =?us-ascii?Q?mfjCBmsPizi/40id8XiRYSTiAO2Otd7VPZZlpJKl6RgzTa20Ww=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(82310400017)(1800799015)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 12:13:46.2718 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b7b9ec5-d9f5-48bf-1a17-08dc848fc8c3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B372.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4210 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Venkat Kumar Ande Modify debug messages to get better information from debug logs Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- drivers/net/axgbe/axgbe_phy_impl.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index 86c2ec64e0..8b1f3b2742 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -783,8 +783,8 @@ axgbe_dev_link_update(struct rte_eth_dev *dev, link.link_autoneg = !(dev->data->dev_conf.link_speeds & RTE_ETH_LINK_SPEED_FIXED); ret = rte_eth_linkstatus_set(dev, &link); - if (ret == -1) - PMD_DRV_LOG(ERR, "No change in link status\n"); + if (ret == 0) + PMD_DRV_LOG(ERR, "Link status changed\n"); return ret; } diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index ba781e2f83..b1a453ccc8 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1375,8 +1375,6 @@ static void axgbe_phy_perform_ratechange(struct axgbe_port *pdata, if (cmd != AXGBE_MB_CMD_POWER_OFF && cmd != AXGBE_MB_CMD_RRC) axgbe_phy_pll_ctrl(pdata, true); - - PMD_DRV_LOG(NOTICE, "firmware mailbox command did not complete\n"); } static void axgbe_phy_rrc(struct axgbe_port *pdata) -- 2.34.1