From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A55B44156; Tue, 4 Jun 2024 18:08:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C46D40A6D; Tue, 4 Jun 2024 18:08:52 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id E5E7C4026E for ; Tue, 4 Jun 2024 18:08:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717517331; x=1749053331; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=rWrvMn1hsY8C3A2IDGLWxuiGPLepygPC7zUVdPYKuys=; b=fRBVnGnhzw9uu4g5hHUV59FQiLEP5zqc2bphpYAYvl9rP5FFlZPq2hUb ptfWgXk9k+5eIecug79VireVQXSwOMkQ2ztYmHepnNwONX0BX7EknWOg2 vp8i+8/bOrbAwgtp45wQue/hPySkdgy5HIOrnyz3SKW2Le4vWZVgFxbt5 q1PaziYRL1tshu3uAqAzJTNve//4yzdRt2egYV/B0hbIYG93j5notL5rg VoJkyc8khSw4zIpBUP88Ma9X8eAqftTmkzX1QoCvneEHxRDUyr/HpdpZN SAth/8KnBtDh81v5J+8cNr/+DwigfGb5gFgMfezXiBIVEb+4ShatZnBOF Q==; X-CSE-ConnectionGUID: Eo2wDZuSSESj14FkFuxPBg== X-CSE-MsgGUID: ZtEiGSVVTjO5SPFNawgvMA== X-IronPort-AV: E=McAfee;i="6600,9927,11093"; a="24652363" X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="24652363" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2024 09:08:50 -0700 X-CSE-ConnectionGUID: S+8Pb4tnT4ilsdhqCTsCfA== X-CSE-MsgGUID: /YJ8hkJaS0+E1xtnLTnVGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,214,1712646000"; d="scan'208";a="68106010" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by orviesa002.jf.intel.com with ESMTP; 04 Jun 2024 09:08:50 -0700 From: Ganapati Kundapura To: dev@dpdk.org Subject: [PATCH v1] eventdev/crypto: restore opaque field between dequeue and enqueue Date: Tue, 4 Jun 2024 11:08:47 -0500 Message-Id: <20240604160847.1573821-1-ganapati.kundapura@intel.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For session-less crypto operations, event info is contained in crypto op metadata for each event which is restored in event from the crypto op metadata response info. For session based crypto operations, crypto op contains per session based event info in crypto op metadata. If any PMD passes any implementaion specific data in ev::impl_opaque on each event, it's not getting restored. This patch stores ev::impl_opaque in mbuf's dynamic field before enqueueing to cryptodev and restores ev::impl_opaque from mbuf's dynamic field after dequeueing crypto op from cryptodev for session based crypto operations. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_event_crypto_adapter.c index db1c7f3..91a30ca 100644 --- a/lib/eventdev/rte_event_crypto_adapter.c +++ b/lib/eventdev/rte_event_crypto_adapter.c @@ -138,6 +138,27 @@ static struct event_crypto_adapter **event_crypto_adapter; } \ } while (0) +#define ECA_DYNFIELD_NAME "eca_ev_opaque_data" +/** Device-specific metadata field type */ +typedef uint8_t eca_dynfield_t; +/** Dynamic mbuf field for device-specific metadata */ +int eca_dynfield_offset = -1; + +static int +eca_dynfield_register(void) +{ + static const struct rte_mbuf_dynfield eca_dynfield_desc = { + .name = ECA_DYNFIELD_NAME, + .size = sizeof(eca_dynfield_t), + .align = alignof(eca_dynfield_t), + .flags = 0, + }; + + eca_dynfield_offset = + rte_mbuf_dynfield_register(&eca_dynfield_desc); + return eca_dynfield_offset; +} + static inline int eca_valid_id(uint8_t id) { @@ -491,6 +512,24 @@ eca_enq_to_cryptodev(struct event_crypto_adapter *adapter, struct rte_event *ev, crypto_op = ev[i].event_ptr; if (crypto_op == NULL) continue; + + /** ev::impl_opaque field passed on from eventdev PMD could + * have different value per event. + * For session-based crypto operations retain ev::impl_opaque + * into mbuf dynfield and restore it back after copying event + * information from session event metadata. + * For session-less, each crypto operation carries event + * metadata and retains ev::impl_opaque information to be + * passed back to eventdev PMD. + */ + if (crypto_op->sess_type == RTE_CRYPTO_OP_WITH_SESSION) { + struct rte_mbuf *mbuf = crypto_op->sym->m_src; + + *RTE_MBUF_DYNFIELD(mbuf, + eca_dynfield_offset, + eca_dynfield_t *) = ev[i].impl_opaque; + } + m_data = rte_cryptodev_session_event_mdata_get(crypto_op); if (m_data == NULL) { rte_pktmbuf_free(crypto_op->sym->m_src); @@ -657,6 +696,21 @@ eca_ops_enqueue_burst(struct event_crypto_adapter *adapter, rte_memcpy(ev, &m_data->response_info, sizeof(*ev)); ev->event_ptr = ops[i]; + + /** restore ev::impl_opaque from mbuf dyn field + * for session based crypto operation. + * For session-less, each crypto operations carries event + * metadata and retains ev::impl_opaque information to be + * passed back to eventdev PMD. + */ + if (ops[i]->sess_type == RTE_CRYPTO_OP_WITH_SESSION) { + struct rte_mbuf *mbuf = ops[i]->sym->m_src; + + ev->impl_opaque = *RTE_MBUF_DYNFIELD(mbuf, + eca_dynfield_offset, + eca_dynfield_t *); + } + ev->event_type = RTE_EVENT_TYPE_CRYPTODEV; if (adapter->implicit_release_disabled) ev->op = RTE_EVENT_OP_FORWARD; @@ -895,6 +949,16 @@ eca_init_service(struct event_crypto_adapter *adapter, uint8_t id) } adapter->implicit_release_disabled = (uint8_t)impl_rel; + + /* Register for mbuf dyn field to store/restore ev::impl_opaque */ + eca_dynfield_offset = eca_dynfield_register(); + if (eca_dynfield_offset < 0) { + RTE_EDEV_LOG_ERR("Failed to register eca mbuf dyn field"); + eca_circular_buffer_free(&adapter->ebuf); + rte_free(adapter); + return -EINVAL; + } + adapter->service_inited = 1; return ret; -- 2.6.4