From: Stephen Hemminger <stephen@networkplumber.org>
To: "Wani, Shaiq" <shaiq.wani@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [PATCH v4] net/cpfl: get running host ID for CPFL PMD
Date: Wed, 5 Jun 2024 11:05:22 -0700 [thread overview]
Message-ID: <20240605110522.784bb637@hermes.local> (raw)
In-Reply-To: <SJ0PR11MB5918E86B5461DD650E70A0AB92F92@SJ0PR11MB5918.namprd11.prod.outlook.com>
On Wed, 5 Jun 2024 05:48:39 +0000
"Wani, Shaiq" <shaiq.wani@intel.com> wrote:
> > + if (uname(&unamedata) != 0)
> > + PMD_INIT_LOG(ERR, "Cannot fetch node_name for host\n");
No newline needed.
> > + else if (strstr(unamedata.nodename, "ipu-imc"))
> > + PMD_INIT_LOG(ERR, "CPFL PMD cannot be running on IMC.");
> > + else if (strstr(unamedata.nodename, "ipu-acc"))
> > + host_id = CPFL_HOST_ID_ACC;
>
> The nodename in uname is the same as the hostname.
> This can be changed by user, is that ok?
>
> We are making an assumption that user will not have hostname as ipu-acc or ipu-imc.
> If this is okay, I will upload a new patch taking care of the blank line between the functions.
>
> Also, please put one blank line between functions, it makes code easier to read.
>
The blank line is not important, but there is something that is worth adding.
Could you add something to the NIC documentation and/or release notes if necessary.
next prev parent reply other threads:[~2024-06-05 18:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 4:05 [PATCH v3] " Shaiq Wani
2024-05-30 9:39 ` [PATCH v4] " Shaiq Wani
2024-06-04 16:17 ` Stephen Hemminger
2024-06-05 5:48 ` Wani, Shaiq
2024-06-05 18:05 ` Stephen Hemminger [this message]
2024-06-06 10:44 ` [PATCH v5] " Shaiq Wani
2024-06-13 15:36 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605110522.784bb637@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).