From: jspewock@iol.unh.edu
To: Luca.Vizzarro@arm.com, probb@iol.unh.edu, npratte@iol.unh.edu,
paul.szczepanek@arm.com, juraj.linkes@pantheon.tech,
yoan.picchi@foss.arm.com, thomas@monjalon.net,
wathsala.vithanage@arm.com, Honnappa.Nagarahalli@arm.com
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>
Subject: [RFC PATCH v1 1/2] dts: Add interactive shell for managing Scapy
Date: Wed, 5 Jun 2024 13:52:26 -0400 [thread overview]
Message-ID: <20240605175227.7003-2-jspewock@iol.unh.edu> (raw)
In-Reply-To: <20240605175227.7003-1-jspewock@iol.unh.edu>
From: Jeremy Spewock <jspewock@iol.unh.edu>
This shell can be used to remotely run Scapy commands interactively
and provides methods for handling the sending and capturing of packets.
depends-on: series-32014 ("Improve interactive shell output gathering
and logging")
Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
---
dts/framework/remote_session/__init__.py | 1 +
dts/framework/remote_session/scapy_shell.py | 175 ++++++++++++++++++++
dts/framework/utils.py | 1 +
3 files changed, 177 insertions(+)
create mode 100644 dts/framework/remote_session/scapy_shell.py
diff --git a/dts/framework/remote_session/__init__.py b/dts/framework/remote_session/__init__.py
index 1910c81c3c..ec50265bed 100644
--- a/dts/framework/remote_session/__init__.py
+++ b/dts/framework/remote_session/__init__.py
@@ -21,6 +21,7 @@
from .interactive_shell import InteractiveShell
from .python_shell import PythonShell
from .remote_session import CommandResult, RemoteSession
+from .scapy_shell import ScapyShell
from .ssh_session import SSHSession
from .testpmd_shell import TestPmdShell
diff --git a/dts/framework/remote_session/scapy_shell.py b/dts/framework/remote_session/scapy_shell.py
new file mode 100644
index 0000000000..fa647dc870
--- /dev/null
+++ b/dts/framework/remote_session/scapy_shell.py
@@ -0,0 +1,175 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 University of New Hampshire
+
+"""Scapy interactive shell."""
+
+import re
+import time
+from typing import Callable, ClassVar
+
+from scapy.compat import base64_bytes # type: ignore[import]
+from scapy.layers.l2 import Ether # type: ignore[import]
+from scapy.packet import Packet # type: ignore[import]
+
+from framework.testbed_model.port import Port
+from framework.utils import REGEX_FOR_BASE64_ENCODING
+
+from .python_shell import PythonShell
+
+
+class ScapyShell(PythonShell):
+ """Scapy interactive shell.
+
+ The scapy shell is implemented using a :class:`~.python_shell.PythonShell` and importing
+ everything from the "scapy.all" library. This is done due to formatting issues that occur from
+ the scapy interactive shell attempting to use iPython, which is not compatible with the
+ pseudo-terminal that paramiko creates to manage its channels.
+
+ This class is used as an underlying session for the scapy traffic generator and shouldn't be
+ used directly inside of test suites. If there isn't a method in
+ :class:`framework.testbed_model.traffic_generator.scapy.ScapyTrafficGenerator` to fulfill a
+ need, one should be added there and implemented here.
+ """
+
+ #: Name of sniffer to ensure the same is used in all places
+ _sniffer_name: ClassVar[str] = "sniffer"
+ #: Name of variable that points to the list of packets inside the scapy shell.
+ _send_packet_list_name: ClassVar[str] = "packets"
+ #: Padding to add to the start of a line for python syntax compliance.
+ _padding: ClassVar[str] = " " * 4
+
+ def _start_application(self, get_privileged_command: Callable[[str], str] | None) -> None:
+ """Overrides :meth:`~.interactive_shell._start_application`.
+
+ Adds a command that imports everything from the scapy library immediately after starting
+ the shell for usage in later calls to the methods of this class.
+
+ Args:
+ get_privileged_command: A function (but could be any callable) that produces
+ the version of the command with elevated privileges.
+ """
+ super()._start_application(get_privileged_command)
+ self.send_command("from scapy.all import *")
+
+ def _build_send_packet_list(self, packets: list[Packet]) -> None:
+ """Build a list of packets to send later.
+
+ Gets the string that represents the Python command that was used to create each packet in
+ `packets` and sends these commands into the underlying Python session. The purpose behind
+ doing this is to create a list that is identical to `packets` inside the shell. This method
+ should only be called by methods for sending packets immediately prior to sending. The list
+ of packets will continue to exist in the scope of the shell until subsequent calls to this
+ method, so failure to rebuild the list prior to sending packets could lead to undesired
+ "stale" packets to be sent.
+
+ Args:
+ packets: The list of packets to recreate in the shell.
+ """
+ self._logger.info("Building a list of packets to send...")
+ self.send_command(
+ f"{self._send_packet_list_name} = [{', '.join(map(Packet.command, packets))}]"
+ )
+
+ def send_packets(self, packets: list[Packet], send_port: Port) -> None:
+ """Send packets without capturing any received traffic.
+
+ Provides a "fire and forget" method for sending packets for situations when there is no
+ need to collected any received traffic.
+
+ Args:
+ packets: The packets to send.
+ send_port: The port to send the packets from.
+ """
+ self._build_send_packet_list(packets)
+ send_command = [
+ "sendp(",
+ f"{self._send_packet_list_name},",
+ f"iface='{send_port.logical_name}',",
+ "realtime=True,",
+ "verbose=True",
+ ")",
+ ]
+ self.send_command(f"\n{self._padding}".join(send_command))
+
+ def _create_sniffer(
+ self, packets_to_send: list[Packet], send_port: Port, recv_port: Port, filter_config: str
+ ) -> None:
+ """Create an asynchronous sniffer in the shell.
+
+ A list of packets to send is added to the sniffer inside of a callback function so that
+ they are immediately sent at the time sniffing is started.
+
+ Args:
+ packets_to_send: A list of packets to send when sniffing is started.
+ send_port: The port to send the packets on when sniffing is started.
+ recv_port: The port to collect the traffic from.
+ filter_config: An optional BPF format filter to use when sniffing for packets. Omitted
+ when set to an empty string.
+ """
+ self._build_send_packet_list(packets_to_send)
+ sniffer_commands = [
+ f"{self._sniffer_name} = AsyncSniffer(",
+ f"iface='{recv_port.logical_name}',",
+ "store=True,",
+ "started_callback=lambda *args: sendp(",
+ f"{self._padding}{self._send_packet_list_name}, iface='{send_port.logical_name}'),",
+ ")",
+ ]
+ if filter_config:
+ sniffer_commands.insert(-1, f"filter='{filter_config}'")
+
+ self.send_command(f"\n{self._padding}".join(sniffer_commands))
+
+ def _start_and_stop_sniffing(self, duration: float) -> list[Packet]:
+ """Starts asynchronous sniffer, runs for a set `duration`, then collects received packets.
+
+ This method expects that you have first created an asynchronous sniffer inside the shell
+ and will fail if you haven't. Received packets are collected by printing the base64
+ encoding of each packet in the shell and then harvesting these encodings using regex to
+ convert back into packet objects.
+
+ Args:
+ duration: The amount of time in seconds to sniff for received packets.
+
+ Returns:
+ A list of all packets that were received while the sniffer was running.
+ """
+ sniffed_packets_name = "gathered_packets"
+ self.send_command(f"{self._sniffer_name}.start()")
+ time.sleep(duration)
+ self.send_command(f"{sniffed_packets_name} = {self._sniffer_name}.stop(join=True)")
+ # An extra newline is required here due to the nature of interactive Python shells
+ packet_objects = self.send_command(
+ f"for pakt in {sniffed_packets_name}: print(bytes_base64(pakt.build()))\n"
+ )
+ # In the string of bytes "b'XXXX'", we only want the contents ("XXXX")
+ list_of_packets_base64 = re.findall(
+ f"^b'({REGEX_FOR_BASE64_ENCODING})'", packet_objects, re.MULTILINE
+ )
+ return [Ether(base64_bytes(pakt)) for pakt in list_of_packets_base64]
+
+ def send_packets_and_capture(
+ self,
+ packets: list[Packet],
+ send_port: Port,
+ recv_port: Port,
+ filter_config: str,
+ duration: float,
+ ) -> list[Packet]:
+ """Send packets and capture any received traffic.
+
+ The steps required to collect these packets are creating a sniffer that holds the packets to
+ send then starting and stopping the sniffer.
+
+ Args:
+ packets: The packets to send.
+ send_port: The port to send the packets from.
+ recv_port: The port to collect received packets from.
+ filter_config: The filter to use while sniffing for packets.
+ duration: The amount of time in seconds to sniff for received packets.
+
+ Returns:
+ A list of packets received after sending `packets`.
+ """
+ self._create_sniffer(packets, send_port, recv_port, filter_config)
+ return self._start_and_stop_sniffing(duration)
diff --git a/dts/framework/utils.py b/dts/framework/utils.py
index cc5e458cc8..4eea1818ed 100644
--- a/dts/framework/utils.py
+++ b/dts/framework/utils.py
@@ -26,6 +26,7 @@
from .exception import ConfigurationError
REGEX_FOR_PCI_ADDRESS: str = "/[0-9a-fA-F]{4}:[0-9a-fA-F]{2}:[0-9a-fA-F]{2}.[0-9]{1}/"
+REGEX_FOR_BASE64_ENCODING: str = "[-a-zA-Z0-9+\\/]*={0,3}"
def expand_range(range_str: str) -> list[int]:
--
2.45.1
next prev parent reply other threads:[~2024-06-05 17:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 17:52 [RFC PATCH v1 0/2] dts: replace XML-RPC server jspewock
2024-06-05 17:52 ` jspewock [this message]
2024-06-11 11:12 ` [RFC PATCH v1 1/2] dts: Add interactive shell for managing Scapy Juraj Linkeš
2024-06-17 19:45 ` Jeremy Spewock
2024-06-05 17:52 ` [RFC PATCH v1 2/2] dts: Remove XML-RPC server for Scapy TG and instead us ScapyShell jspewock
2024-06-11 10:46 ` Juraj Linkeš
2024-06-17 19:57 ` Jeremy Spewock
2024-06-20 23:11 ` [PATCH v1 0/1] dts: replace XML-RPC server jspewock
2024-06-20 23:11 ` [PATCH v1 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell jspewock
2024-06-21 14:14 ` Juraj Linkeš
2024-06-24 20:54 ` Jeremy Spewock
2024-06-25 21:11 ` [PATCH v2 0/1] dts: replace XML-RPC server jspewock
2024-06-25 21:11 ` [PATCH v2 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell jspewock
2024-09-12 4:00 ` Patrick Robb
2024-09-19 19:02 ` [PATCH v3 0/1] dts: replace XML-RPC server jspewock
2024-09-19 19:02 ` [PATCH v3 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell jspewock
2024-09-24 10:55 ` Juraj Linkeš
2024-09-24 16:34 ` Jeremy Spewock
2024-09-25 7:49 ` Juraj Linkeš
2024-09-25 17:37 ` [PATCH v4 0/1] dts: replace XML-RPC server jspewock
2024-09-25 17:37 ` [PATCH v4 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell jspewock
2024-09-26 9:12 ` Juraj Linkeš
2024-09-26 14:54 ` Jeremy Spewock
2024-09-27 9:35 ` Juraj Linkeš
2024-09-26 14:55 ` Jeremy Spewock
2024-09-26 16:50 ` [PATCH v5 0/1] dts: replace XML-RPC server jspewock
2024-09-26 16:50 ` [PATCH v5 1/1] dts: use PythonShell for Scapy instead of XML-RPC jspewock
2024-09-27 9:42 ` Juraj Linkeš
2024-09-27 11:47 ` Luca Vizzarro
2024-09-30 13:41 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240605175227.7003-2-jspewock@iol.unh.edu \
--to=jspewock@iol.unh.edu \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Luca.Vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).