From: Luca Vizzarro <luca.vizzarro@arm.com>
To: dev@dpdk.org
Cc: "Jeremy Spewock" <jspewock@iol.unh.edu>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Luca Vizzarro" <luca.vizzarro@arm.com>,
"Paul Szczepanek" <paul.szczepanek@arm.com>
Subject: [PATCH v5 1/5] dts: fix InteractiveShell command prompt filtering
Date: Thu, 6 Jun 2024 22:34:16 +0100 [thread overview]
Message-ID: <20240606213420.254260-2-luca.vizzarro@arm.com> (raw)
In-Reply-To: <20240606213420.254260-1-luca.vizzarro@arm.com>
When sending a command using an instance of InteractiveShell the output
should filter out the trailing shell prompt when returning it. After
every command two shell prompts are summoned. One is consumed as it is
used as a delimiter for the command output. The second one is not
consumed and left for the next command to be sent.
Given that the consumed prompt is merely a delimiter, this should not be
added to the returned output, as it may be mistakenly be interpreted as
the command's own output.
Bugzilla ID: 1411
Fixes: 88489c0501af ("dts: add smoke tests")
Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
---
dts/framework/remote_session/interactive_shell.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/framework/remote_session/interactive_shell.py
index 074a541279..aa5d2d9be8 100644
--- a/dts/framework/remote_session/interactive_shell.py
+++ b/dts/framework/remote_session/interactive_shell.py
@@ -132,11 +132,11 @@ def send_command(self, command: str, prompt: str | None = None) -> str:
self._stdin.flush()
out: str = ""
for line in self._stdout:
- out += line
if prompt in line and not line.rstrip().endswith(
command.rstrip()
): # ignore line that sent command
break
+ out += line
self._logger.debug(f"Got output: {out}")
return out
--
2.34.1
next prev parent reply other threads:[~2024-06-06 21:34 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 11:11 [PATCH 0/5] dts: testpmd show port info/stats Luca Vizzarro
2024-04-12 11:11 ` [PATCH 1/5] dts: fix InteractiveShell command prompt filtering Luca Vizzarro
2024-04-16 8:40 ` Juraj Linkeš
2024-04-16 12:12 ` Luca Vizzarro
2024-04-17 13:06 ` Juraj Linkeš
2024-04-17 14:17 ` Luca Vizzarro
2024-04-18 6:31 ` Juraj Linkeš
2024-04-29 16:16 ` Jeremy Spewock
2024-04-12 11:11 ` [PATCH 2/5] dts: skip first line of send_command output Luca Vizzarro
2024-04-16 8:48 ` Juraj Linkeš
2024-04-16 12:15 ` Luca Vizzarro
2024-04-17 13:18 ` Juraj Linkeš
2024-04-29 15:18 ` Jeremy Spewock
2024-06-14 18:58 ` Nicholas Pratte
2024-04-12 11:11 ` [PATCH 3/5] dts: add parsing utility module Luca Vizzarro
2024-04-16 8:59 ` Juraj Linkeš
2024-04-16 12:16 ` Luca Vizzarro
2024-04-29 16:15 ` Jeremy Spewock
2024-04-30 10:49 ` Luca Vizzarro
2024-04-30 20:03 ` Jeremy Spewock
2024-04-12 11:11 ` [PATCH 4/5] dts: add `show port info` command to TestPmdShell Luca Vizzarro
2024-04-16 9:03 ` Juraj Linkeš
2024-04-16 12:24 ` Luca Vizzarro
2024-04-17 13:22 ` Juraj Linkeš
2024-04-17 14:25 ` Luca Vizzarro
2024-04-17 15:29 ` Luca Vizzarro
2024-04-18 6:41 ` Juraj Linkeš
2024-04-18 10:52 ` Luca Vizzarro
2024-04-12 11:11 ` [PATCH 5/5] dts: add `show port stats` " Luca Vizzarro
2024-04-16 9:04 ` Juraj Linkeš
2024-04-29 15:54 ` Jeremy Spewock
2024-04-30 10:51 ` Luca Vizzarro
2024-05-09 11:26 ` [PATCH v2 0/5] dts: testpmd show port info/stats Luca Vizzarro
2024-05-09 11:26 ` [PATCH v2 1/5] dts: fix InteractiveShell command prompt filtering Luca Vizzarro
2024-05-31 21:06 ` Jeremy Spewock
2024-06-04 13:57 ` Juraj Linkeš
2024-05-09 11:26 ` [PATCH v2 2/5] dts: skip first line of send command output Luca Vizzarro
2024-05-31 21:06 ` Jeremy Spewock
2024-06-04 13:58 ` Juraj Linkeš
2024-05-09 11:26 ` [PATCH v2 3/5] dts: add parsing utility module Luca Vizzarro
2024-05-31 21:06 ` Jeremy Spewock
2024-06-04 15:13 ` Juraj Linkeš
2024-06-05 10:35 ` Luca Vizzarro
2024-06-05 12:19 ` Juraj Linkeš
2024-06-05 13:00 ` Luca Vizzarro
2024-05-09 11:26 ` [PATCH v2 4/5] dts: add `show port info` command to TestPmdShell Luca Vizzarro
2024-05-31 21:06 ` Jeremy Spewock
2024-06-03 9:11 ` Luca Vizzarro
2024-06-04 15:40 ` Juraj Linkeš
2024-06-05 11:03 ` Luca Vizzarro
2024-05-09 11:26 ` [PATCH v2 5/5] dts: add `show port stats` " Luca Vizzarro
2024-05-20 14:26 ` Nicholas Pratte
2024-05-21 15:00 ` Luca Vizzarro
2024-05-31 21:07 ` Jeremy Spewock
2024-06-04 15:44 ` Juraj Linkeš
2024-06-05 11:04 ` Luca Vizzarro
2024-06-05 14:44 ` [PATCH v3 0/5] dts: testpmd show port info/stats Luca Vizzarro
2024-06-05 14:45 ` [PATCH v3 1/5] dts: fix InteractiveShell command prompt filtering Luca Vizzarro
2024-06-05 14:45 ` [PATCH v3 2/5] dts: skip first line of send command output Luca Vizzarro
2024-06-05 14:45 ` [PATCH v3 3/5] dts: add parsing utility module Luca Vizzarro
2024-06-05 14:45 ` [PATCH v3 4/5] dts: add `show port info` command to TestPmdShell Luca Vizzarro
2024-06-05 14:45 ` [PATCH v3 5/5] dts: add `show port stats` " Luca Vizzarro
2024-06-06 9:17 ` [PATCH v4 0/5] dts: testpmd show port info/stats Luca Vizzarro
2024-06-06 9:17 ` [PATCH v4 1/5] dts: fix InteractiveShell command prompt filtering Luca Vizzarro
2024-06-06 18:52 ` Jeremy Spewock
2024-06-06 9:17 ` [PATCH v4 2/5] dts: skip first line of send command output Luca Vizzarro
2024-06-06 18:52 ` Jeremy Spewock
2024-06-06 9:17 ` [PATCH v4 3/5] dts: add parsing utility module Luca Vizzarro
2024-06-06 18:52 ` Jeremy Spewock
2024-06-06 21:14 ` Luca Vizzarro
2024-06-06 9:17 ` [PATCH v4 4/5] dts: add `show port info` command to TestPmdShell Luca Vizzarro
2024-06-06 18:52 ` Jeremy Spewock
2024-06-06 9:17 ` [PATCH v4 5/5] dts: add `show port stats` " Luca Vizzarro
2024-06-06 18:53 ` Jeremy Spewock
2024-06-06 21:34 ` [PATCH v5 0/5] dts: testpmd show port info/stats Luca Vizzarro
2024-06-06 21:34 ` Luca Vizzarro [this message]
2024-06-07 11:15 ` [PATCH v5 1/5] dts: fix InteractiveShell command prompt filtering Juraj Linkeš
2024-06-07 13:10 ` Jeremy Spewock
2024-06-14 20:05 ` Nicholas Pratte
2024-06-06 21:34 ` [PATCH v5 2/5] dts: skip first line of send command output Luca Vizzarro
2024-06-07 11:16 ` Juraj Linkeš
2024-06-07 13:10 ` Jeremy Spewock
2024-06-06 21:34 ` [PATCH v5 3/5] dts: add parsing utility module Luca Vizzarro
2024-06-07 11:16 ` Juraj Linkeš
2024-06-07 13:11 ` Jeremy Spewock
2024-06-14 17:39 ` Nicholas Pratte
2024-06-06 21:34 ` [PATCH v5 4/5] dts: add `show port info` command to TestPmdShell Luca Vizzarro
2024-06-07 11:16 ` Juraj Linkeš
2024-06-07 13:11 ` Jeremy Spewock
2024-06-14 17:36 ` Nicholas Pratte
2024-06-06 21:34 ` [PATCH v5 5/5] dts: add `show port stats` " Luca Vizzarro
2024-06-07 11:16 ` Juraj Linkeš
2024-06-07 13:11 ` Jeremy Spewock
2024-06-14 17:34 ` Nicholas Pratte
2024-06-20 3:04 ` [PATCH v5 0/5] dts: testpmd show port info/stats Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240606213420.254260-2-luca.vizzarro@arm.com \
--to=luca.vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=paul.szczepanek@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).