From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Ferruh Yigit" <ferruh.yigit@amd.com>,
"Sivaprasad Tummala" <sivaprasad.tummala@amd.com>,
<david.marchand@redhat.com>, <aman.deep.singh@intel.com>,
<yuying.zhang@intel.com>, <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH v2] app/testpmd: fix lcore ID restriction
Date: Fri, 14 Jun 2024 11:11:33 -0700 [thread overview]
Message-ID: <20240614111133.3cb31be7@hermes.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F523@smartserver.smartshare.dk>
On Fri, 14 Jun 2024 19:50:29 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> > > ```
> > > ../../root/dpdk/app/test-pmd/config.c: In function
> > 'icmp_echo_config_setup':
> > > ../../root/dpdk/app/test-pmd/config.c:5159:30: error: comparison
> > between
> > > signed and unsigned integer expressions [-Werror=sign-compare]
> > > if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores)
> >
> > That does look like a compiler bug. uint16 multiplied by uint16 should
> > be uint16.
>
> Not, C doesn't promote types like that. Arithmetic operations always promote smaller types to int or unsigned int. And since uint16 fits in int, uint16 is promoted to int (not unsigned int).
You are right. Long winded explanation here:
https://stackoverflow.com/questions/46073295/implicit-type-promotion-rules
next prev parent reply other threads:[~2024-06-14 18:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 19:46 [PATCH] " Sivaprasad Tummala
2024-04-15 21:54 ` Stephen Hemminger
2024-04-15 21:56 ` Stephen Hemminger
2024-04-16 9:55 ` [PATCH v2] " Sivaprasad Tummala
2024-04-19 8:24 ` Ferruh Yigit
2024-04-19 11:30 ` Ferruh Yigit
2024-06-06 9:56 ` Tummala, Sivaprasad
2024-06-13 16:51 ` Ferruh Yigit
2024-06-13 19:13 ` Stephen Hemminger
2024-06-14 9:01 ` Ferruh Yigit
2024-06-14 15:27 ` Stephen Hemminger
2024-06-14 15:39 ` Ferruh Yigit
2024-06-14 17:50 ` Morten Brørup
2024-06-14 18:11 ` Stephen Hemminger [this message]
2024-06-06 11:27 ` [PATCH v3] " Sivaprasad Tummala
2024-06-11 23:37 ` Ferruh Yigit
2024-06-13 16:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614111133.3cb31be7@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=mb@smartsharesystems.com \
--cc=sivaprasad.tummala@amd.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).