From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CB0F4545E; Fri, 14 Jun 2024 17:04:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8228C4279E; Fri, 14 Jun 2024 17:03:56 +0200 (CEST) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by mails.dpdk.org (Postfix) with ESMTP id 8AB2B4279E for ; Fri, 14 Jun 2024 17:03:55 +0200 (CEST) Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-441187684e3so14893891cf.3 for ; Fri, 14 Jun 2024 08:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1718377435; x=1718982235; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R/zSpEbl2RNPTd31N/3iIidXvvhWD/j5QobOs+hvavw=; b=ZtS36MRRRUyz6m9bxpCN8nt8ma7q3HQ+S74FMVUUqg4aWHqhX7qnSCCi7FNBOXvCGC zlwlnPOrAFcZEsMex1HA945qxLu1itNBaQBdsYBgjDbwoH+Ub4DQ4b9OPIrSm5dXUwTH 6x0Xm9UlIEFf+Q9son1aVIJjaug4RT6D6oh0A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718377435; x=1718982235; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R/zSpEbl2RNPTd31N/3iIidXvvhWD/j5QobOs+hvavw=; b=M4VKa6vM2sInAS+OtoazfgA/cOKILeTK+HTkrU2dChnOc0Rg4vKAwdHt14ACZNpSDz j5hM3ez5ckvfSmgn0m6N9+eXzfCH3zbyC5vjHEaXTAKdHP6BJrXEbD1/2VAsA6U4v8CN MQtQ9MiH6gAC4X43VcI3ZdBuH6jqUN1xvqTnN3vOrJNacgAElvWupABp/V+pWTQSeBFa 2CX/KH2zb8qftLrZrn4SzGDFHJz41R80Ehs8EIe4Bl9Nx5FlFS5xjCuRWZaVzON0iJUP pcmRyQhXXJ1uietrDuPssw0oIhEr9t3IfFdS7lz19gt2+4/EJkiv6C1FE8Yk10e5krNH b0Pg== X-Gm-Message-State: AOJu0YzbyEJaxC12iYlDQkQjiOM43t36RXbkCKsbz4GqEeA9H9uu6Hka Db7m0XPY+eSfklOve4Ju9Ybb2It89Z59YQGK2mHu5B+OUcgF11TmLvxZheS0rco= X-Google-Smtp-Source: AGHT+IEBLKhyVrqYivfBcYf8lzkAdYtmGZING8L5gP1/FnPalvsz8FKUlpmBnDTDYdjnbf0i1fffsw== X-Received: by 2002:a05:622a:1792:b0:440:fe6d:d538 with SMTP id d75a77b69052e-442168583aemr31107301cf.6.1718377434699; Fri, 14 Jun 2024 08:03:54 -0700 (PDT) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44212efe609sm12966671cf.52.2024.06.14.08.03.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 08:03:54 -0700 (PDT) From: Dean Marx To: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, jspewock@iol.unh.edu, bruce.richardson@intel.com, luca.vizzarro@arm.com Cc: dev@dpdk.org, Dean Marx Subject: [PATCH v3 2/3] Initial implementation for VLAN test suite Date: Fri, 14 Jun 2024 11:02:37 -0400 Message-ID: <20240614150238.26374-3-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240614150238.26374-1-dmarx@iol.unh.edu> References: <20240611161606.23881-2-dmarx@iol.unh.edu> <20240614150238.26374-1-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Test suite for ensuring Poll Mode Driver can enable or disable vlan filtering, stripping, and header insertion of packets sent on a port. Signed-off-by: Dean Marx --- dts/tests/TestSuite_vlan.py | 172 ++++++++++++++++++++++++++++++++++++ 1 file changed, 172 insertions(+) create mode 100644 dts/tests/TestSuite_vlan.py diff --git a/dts/tests/TestSuite_vlan.py b/dts/tests/TestSuite_vlan.py new file mode 100644 index 0000000000..8b6827ec4b --- /dev/null +++ b/dts/tests/TestSuite_vlan.py @@ -0,0 +1,172 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2024 University of New Hampshire + +"""Test the support of VLAN Offload Features by Poll Mode Drivers. + +The test suite ensures that with the correct configuration, a port +will not drop a VLAN tagged packet. In order for this to be successful, +packet header stripping and packet receipts must be enabled on the Poll Mode Driver. +The test suite checks that when these conditions are met, the packet is received without issue. +The suite also checks to ensure that when these conditions are not met, as in the cases where +stripping is disabled, or VLAN packet receipts are disabled, the packet is not received. +Additionally, it checks the case where VLAN header insertion is enabled in transmitted packets, +which should be successful if the previous cases pass. + +""" + +from scapy.layers.l2 import Dot1Q, Ether # type: ignore[import] +from scapy.packet import Raw # type: ignore[import] + +from framework.remote_session.testpmd_shell import TestPmdForwardingModes, TestPmdShell +from framework.test_suite import TestSuite + + +class TestVlan(TestSuite): + """DPDK VLAN test suite. + + Ensures VLAN packet reception on the Poll Mode Driver when certain conditions are met. + If one or more of these conditions are not met, the packet reception should be unsuccessful. + """ + + def set_up_suite(self) -> None: + """Set up the test suite. + + Setup: + Create a testpmd session and set up tg nodes + verify that at least two ports are open for session + """ + self.verify(len(self._port_links) > 1, "Not enough ports") + + def send_vlan_packet_and_verify( + self, should_receive: bool = True, strip: bool = False, vlan_id: int = -1 + ) -> None: + """Generate a vlan packet, send and verify on the dut. + + Args: + should_receive: indicate whether the packet should be successfully received + vlan_id: expected vlan ID + strip: indicates whether stripping is on or off, + and when the vlan tag is checked for a match + """ + data = "P" * 10 + packet = Ether() / Dot1Q(vlan=vlan_id) / Raw(load=data) + received_packets = self.send_packet_and_capture(packet) + received_packets = [ + packets + for packets in received_packets + if hasattr(packets, "load") and data in str((packets.load)) + ] + if should_receive: + self.verify( + len(received_packets) == 1, "Packet was dropped when it should have been received" + ) + received = received_packets[0] + if strip: + self.verify(Dot1Q not in received, "Vlan tag was not stripped successfully") + else: + if len(received_packets) == 1: + self.verify( + received.vlan == vlan_id, "The received tag did not match the expected tag" + ) + else: + self.verify( + not len(received_packets) == 1, + "Packet was received when it should have been dropped", + ) + + def send_packet_and_verify_insertion(self, expected_id: int = -1) -> None: + """Generate a packet with no vlan tag, send and verify on the dut. + + Args: + expected_id: the vlan id that is being inserted through tx_offload configuration + should_receive: indicate whether the packet should be successfully received + """ + data = "P" * 10 + packet = Ether() / Raw(load=data) + received_packets = self.send_packet_and_capture(packet) + received_packets = [ + packets + for packets in received_packets + if hasattr(packets, "load") and data in str((packets.load)) + ] + self.verify( + len(received_packets) == 1, "Packet was dropped when it should have been received" + ) + received = received_packets[0] + self.verify(Dot1Q in received, "The received packet did not have a vlan tag") + self.verify(received.vlan == expected_id, "The received tag did not match the expected tag") + + def test_vlan_receipt_no_stripping(self) -> None: + """Ensure vlan packet is dropped when receipts are enabled and header stripping is disabled. + + Test: + Create an interactive testpmd shell and verify a vlan packet. + """ + testpmd = self.sut_node.create_interactive_shell(TestPmdShell, privileged=True) + testpmd.set_forward_mode(TestPmdForwardingModes.mac) + testpmd.send_command("set verbose 1", "testpmd>") + testpmd.send_command("set promisc 0 off", "testpmd>") + testpmd.vlan_filter_set_on(0) + testpmd.rx_vlan_add(1, 0) + testpmd.start() + + filtered_vlan = 1 + self.send_vlan_packet_and_verify(True, vlan_id=filtered_vlan) + testpmd.close() + + def test_vlan_receipt_stripping(self) -> None: + """Ensure vlan packet received with no tag when receipts and header stripping are enabled. + + Test: + Create an interactive testpmd shell and verify a vlan packet. + """ + testpmd = self.sut_node.create_interactive_shell(TestPmdShell, privileged=True) + testpmd.set_forward_mode(TestPmdForwardingModes.mac) + testpmd.send_command("set verbose 1", "testpmd>") + testpmd.send_command("set promisc 0 off", "testpmd>") + testpmd.vlan_filter_set_on(0) + testpmd.rx_vlan_add(1, 0) + testpmd.vlan_strip_set_on(0) + testpmd.start() + + self.send_vlan_packet_and_verify(should_receive=True, strip=True, vlan_id=1) + testpmd.close() + + def test_vlan_no_receipt(self) -> None: + """Ensure vlan packet dropped when filter is on and sent tag not in the filter list. + + Test: + Create an interactive testpmd shell and verify a vlan packet. + """ + testpmd = self.sut_node.create_interactive_shell(TestPmdShell, privileged=True) + testpmd.set_forward_mode(TestPmdForwardingModes.mac) + testpmd.send_command("set verbose 1", "testpmd>") + testpmd.send_command("set promisc 0 off", "testpmd>") + testpmd.vlan_filter_set_on(0) + testpmd.rx_vlan_add(1, 0) + testpmd.start() + + filtered_vlan = 1 + self.send_vlan_packet_and_verify(should_receive=False, vlan_id=filtered_vlan + 1) + testpmd.close() + + def test_vlan_header_insertion(self) -> None: + """Ensure that vlan packet is received with the correct inserted vlan tag. + + Test: + Create an interactive testpmd shell and verify a non-vlan packet. + """ + testpmd = self.sut_node.create_interactive_shell(TestPmdShell, privileged=True) + testpmd.set_forward_mode(TestPmdForwardingModes.mac) + testpmd.send_command("set verbose 1", "testpmd>") + testpmd.send_command("set promisc 0 off", "testpmd>") + testpmd.port_stop_all() + testpmd.tx_vlan_set(1, 51) + testpmd.port_start_all() + testpmd.start() + + self.send_packet_and_verify_insertion(expected_id=51) + testpmd.close() + + def tear_down_suite(self) -> None: + """Tear down the suite.""" -- 2.44.0