From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85B7045482; Mon, 17 Jun 2024 16:04:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17AC14028B; Mon, 17 Jun 2024 16:04:31 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2073.outbound.protection.outlook.com [40.107.100.73]) by mails.dpdk.org (Postfix) with ESMTP id 2C6C94028A for ; Mon, 17 Jun 2024 16:04:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YrvYZ5Pyqqh93vaeG+apSQlZQ9jcNZluPnCCmeJ7cM9PV6WpSz6RmAOqpW2k7NauLUeNeS8K+vvdzRYrtZD8cFkrRWYh6Uhg67PR7tuUBHvE8Y/9WcHVg7Yc7BpgszLDSkySM1owp4ZyHv89iFTO7j+MljN8LXHy8GYLeqks2jsqVay2NwgQnAZMe+zXpiY83XNqLH/8DjXUvpXTmfx5S6oZcF/4FU4TvQPtNjFVl5Yz37yZ6aEB29nwfXSRJb2YmwRcZLu76Hj6eN06fwR4ml3/aEzz8B0kKTMx6O/39cCdpyqnvVWWbjmPdDKafDZD672kek6duMNtodn6kd1bHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nd/pj8SsHVQqiGlvPdRkPfEzQEjxO4iC2a4Xs0TI/XI=; b=CT7TNFb8k+o405313MoEX9iCKi3dgBGVYXqZvNRislPhZCEB8kVQh//7Dy1Gyi2SeSYIDoX4K0vOFEHMMLueqM8EubUo1vTONqG0XtXeu3Wa93XYr0itPf3DEbiz7iEHRKVgS7EcTpLfS7Y/jg/mIYqtp8rwAJ1ltWEYW7XzIXCVgNCEGzePRrlMfBdwBMazqKmqboHPZO9PVIZ8i8T4zWuZy2kLIfW6sVJMK7NW+7BLaQCRgA/7JoFi3N7iXQ6syXIPGgK+7S6Byrn6cZmeUCMOoi8qygsWUMiRVzKNY7X5p9llIQtrytktnUykWCRX143pOJXAAKdXI7YW/yKg0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nd/pj8SsHVQqiGlvPdRkPfEzQEjxO4iC2a4Xs0TI/XI=; b=XRRJ88GarpbQ5Gq58Gk1Fz+CEAJxq3myRhKbB2GvwBjcmXSaEEQwt7iTdnmrwB7S3nxbqFJKULN8EspgcLyo8j+Dx18g8wp8yqoKKX73tpGtOTRzXx03lJvT7kV8CUywlOxrdHLjwzw0IB4Rmm1j+6WpuFwPXfDmp1df1wE0AembTeIjmkdRvSgCD+lYR4ZlN+9ZFgsWI75iiWkK+VlmmKyUOnKxarwlYpgT60x4UnxeLdFbG+nCxUJHuc716FooJnNLzPCOhQ7TseGtxV4wjw8JSueklVdbQPTP0ecZHh8M+9gQ3w7F7JQkW311+GYNzg3WkxhMmE0maWtYDy1OuQ== Received: from PH8PR07CA0033.namprd07.prod.outlook.com (2603:10b6:510:2cf::20) by PH0PR12MB7863.namprd12.prod.outlook.com (2603:10b6:510:28b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Mon, 17 Jun 2024 14:04:20 +0000 Received: from CY4PEPF0000EDD0.namprd03.prod.outlook.com (2603:10b6:510:2cf:cafe::f5) by PH8PR07CA0033.outlook.office365.com (2603:10b6:510:2cf::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Mon, 17 Jun 2024 14:04:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EDD0.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Mon, 17 Jun 2024 14:04:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 07:04:01 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 07:03:58 -0700 From: Gregory Etelson To: CC: , =?UTF-8?q?=C2=A0?= , , Dariusz Sosnowski , "Viacheslav Ovsiienko" , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH] net/mlx5: fix HWS VXLAN item validation Date: Mon, 17 Jun 2024 17:03:41 +0300 Message-ID: <20240617140341.168247-1-getelson@nvidia.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD0:EE_|PH0PR12MB7863:EE_ X-MS-Office365-Filtering-Correlation-Id: 20169535-e85b-444a-1558-08dc8ed6626a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230037|36860700010|376011|82310400023|1800799021; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ce2SUebV7l5DlaWFqf9zkd8d6QR21h+JV0MnTJMrz2ougoGXoXoovlxSFZ2L?= =?us-ascii?Q?5cYRtbp38ilYxNaqwHUrDPdhAEsYz3tEbrzCiO6u1ikJ4bw4GBzbTfG7+KFJ?= =?us-ascii?Q?e7Dy8T3DQR2Crr61UQjzqzAI2eWMBy4JvTEm9x10DrJ7rKryI2MEzE6jUoS3?= =?us-ascii?Q?tz1S/T+Nn6B9wFFXt/C/8eC0DrJS//e6/GBTyQH1W+HxeU5+09fdNNotCjJa?= =?us-ascii?Q?L7xyrrM/efkyZJdPOSH34/KtOdalnhcYvbqmFcp2NgODEGcczmO6UoAhFgM4?= =?us-ascii?Q?2VMWotDB4c/7O1m7qn0LiHhhm7O5vls1bZWiCShBdHUTRvAuMg9EF9PiVmsJ?= =?us-ascii?Q?Ucm+5uI51sp+wh9Bb2yr1jFkAYhk3qmAdoDR/3SvaEyus7+vd6ek5YLYVGXY?= =?us-ascii?Q?1cB3xx5XqnomrfFAfQjPXif8nNMB1TTEFM+/M+5XQBbMqF9SnK34oOambG2D?= =?us-ascii?Q?iu512y2njpycKtvKikL1OEOqM8efWsGvPPBaw0EO+/2U5c+9k9vcXduhSuxF?= =?us-ascii?Q?d3zrEbkSrbDbpsDDeCZSa5IyOrjUqeFsLiF3FfBsp97VlffuIDYH+KcdSK22?= =?us-ascii?Q?pAacZMCQJZYtf8MfyhAiyzJTuZWsEau4nAbq03reyQwE53zpZW4gbrtE7Vk1?= =?us-ascii?Q?GwvanZJv45gH3fErqQRA4L3c4/+2IcJz1pGGLR2tvQcfbPxJNikDv965/YW+?= =?us-ascii?Q?d1L8xw8IRjwEjiDAO9EZVPIwG0OiE5WEbbBjdE4FtYmeY3hSeR+BYu3d2azG?= =?us-ascii?Q?Qe2v1eW5nSuJggdRZqsYwSToPsuF+QX5gE1aD7vpfmSWAwYV3OUWYjYkQoNB?= =?us-ascii?Q?zaErb5AHUaQVZ1g9UwDb8bt9g2KfGC4NRSMKbda895knjT4JWiQRCj1qMHVq?= =?us-ascii?Q?n2oFEnrD2iUY9wz/9/B8mJDab7nhFl//iSj1XFoNm+vEAca3BbgWEupkWRyc?= =?us-ascii?Q?0mZIN102VMM6A8ZyqlPCI2rQzzzepzIbYrwBmMdcyKadj1MXTfYXCwHzgCUd?= =?us-ascii?Q?dqIJmFvWJy6p5fuDaUYjNQ804r8UF2BsHolmqJ0O6TwS9Ud9O980tLS+xxZM?= =?us-ascii?Q?f1X/2m6X5ArkbEuxUwYZYrKKWfWXvePPKn3xAyOkGlCl3cwX5xOlCvNV3296?= =?us-ascii?Q?9BDN8cD2sAvuNU3WkNPB9WJ6V0DAkA4iQCUjhXSmDvH2PWizk+GW1LXxt0VY?= =?us-ascii?Q?zafGRDGd4c2CmUBAuJXvMtZLYL7LnChZQRgezUVWEkBP4BoEsq2jKIgyz4Ef?= =?us-ascii?Q?HTlWskMaDDEA7TjA7+U65yy93/LM5qyI3vfwm6gSXye+G+axepZlI+T+kz4b?= =?us-ascii?Q?tkKiWAB5jlON9E+Bt1XnzDx0bWtwWq5CPLdf40nsNsEzthbHuSJ8lFNg3Zqk?= =?us-ascii?Q?kD+5PdaGYZWI9nAaxXipqCu7I0fVf4M1AcfTnR8NgwuiPzIrbA=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230037)(36860700010)(376011)(82310400023)(1800799021); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2024 14:04:20.3939 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20169535-e85b-444a-1558-08dc8ed6626a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7863 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org HWS can match entire VXLAN, VXLAN-GPE and VXLAN-GBP headers. No need for mask validation. Fixes: 113feae56db6 ("net/mlx5: validate HWS template items") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 7bcbbc74b5..a150909bd3 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -3148,21 +3148,22 @@ mlx5_flow_validate_item_vxlan(struct rte_eth_dev *dev, RTE_FLOW_ERROR_TYPE_ITEM, item, "multiple tunnel layers not" " supported"); + /* HWS can match entire VXLAN, VXLAN-GBP and VXLAN-GPE headers */ + if (mlx5_hws_active(dev)) + return 0; valid_mask = &rte_flow_item_vxlan_mask; /* * Verify only UDPv4 is present as defined in * https://tools.ietf.org/html/rfc7348 */ - if (!mlx5_hws_active(dev)) { - if (!(item_flags & MLX5_FLOW_LAYER_OUTER_L4_UDP)) - return rte_flow_error_set(error, EINVAL, - RTE_FLOW_ERROR_TYPE_ITEM, - item, "no outer UDP layer found"); - if (!(item_flags & MLX5_FLOW_LAYER_OUTER)) - return rte_flow_error_set(error, ENOTSUP, - RTE_FLOW_ERROR_TYPE_ITEM, item, - "VXLAN tunnel must be fully defined"); - } + if (!(item_flags & MLX5_FLOW_LAYER_OUTER_L4_UDP)) + return rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ITEM, + item, "no outer UDP layer found"); + if (!(item_flags & MLX5_FLOW_LAYER_OUTER)) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ITEM, item, + "VXLAN tunnel must be fully defined"); if (!mask) mask = &rte_flow_item_vxlan_mask; -- 2.43.0