From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 613724548C; Tue, 18 Jun 2024 13:43:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B22E427CD; Tue, 18 Jun 2024 13:42:28 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id A6F39427A5 for ; Tue, 18 Jun 2024 13:42:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718710944; x=1750246944; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nZU8o2JCNaC9u+4hBIwhDFA1aXbgKdVbR4QJepfQavI=; b=etOu5UOaWlxpm6JNM5RKI7llbk87sjXZwYZmWNecCvBEeAgeZXnvwxHE lShizIV2fFXuNAnr4KK9ireKW3B0zGYnaX1p7EgyUC0yqduh4tqoXx4su WXGikaksq6iZNUv5Q98MbmkjJ5XwUaiXltcRvdCt337T7VyMms05Gfl3H mKJleT2pwdiAEqaEeD8WPOasdfCQE02g0GAHx/4/i7S3gOaCPzNA8Z0uP ++sjSspNh/ZZeTKPRS0FBn1/wr934o9yEiqP4OFUrEVZdD0jnf09begFZ Uj3OfAIZv+rx4DaJw2HAVOsjJ4TobzJjwi2k1io05aXO1KtNouCah07tJ g==; X-CSE-ConnectionGUID: jb3jxuPlTj+k0bjzdJ1+jQ== X-CSE-MsgGUID: tN9YOhV8SW2IT6oLgPOoDw== X-IronPort-AV: E=McAfee;i="6700,10204,11106"; a="19443335" X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="19443335" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2024 04:42:24 -0700 X-CSE-ConnectionGUID: tyytZtwPQpaQbNFtPa6gRg== X-CSE-MsgGUID: lCk75UGdQJ2cDGzsqn9aeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,247,1712646000"; d="scan'208";a="41621173" Received: from unknown (HELO npf-hyd-clx-03..) ([10.145.170.182]) by fmviesa009.fm.intel.com with ESMTP; 18 Jun 2024 04:42:22 -0700 From: Soumyadeep Hore To: bruce.richardson@intel.com, anatoly.burakov@intel.com Cc: dev@dpdk.org Subject: [PATCH v4 13/21] common/idpf: update in PTP message validation Date: Tue, 18 Jun 2024 10:57:14 +0000 Message-ID: <20240618105722.2326987-14-soumyadeep.hore@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240618105722.2326987-1-soumyadeep.hore@intel.com> References: <20240612035257.2245824-11-soumyadeep.hore@intel.com> <20240618105722.2326987-1-soumyadeep.hore@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the message for getting timestamp latches is sent by the driver, number of latches is equal to 0. Current implementation of message validation function incorrectly notifies this kind of message length as invalid. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h index e76ccbd46f..24a8b37876 100644 --- a/drivers/common/idpf/base/virtchnl2.h +++ b/drivers/common/idpf/base/virtchnl2.h @@ -2272,7 +2272,7 @@ virtchnl2_vc_validate_vf_msg(__rte_unused struct virtchnl2_version_info *ver, u3 case VIRTCHNL2_OP_GET_PTP_CAPS: valid_len = sizeof(struct virtchnl2_get_ptp_caps); - if (msglen >= valid_len) { + if (msglen > valid_len) { struct virtchnl2_get_ptp_caps *ptp_caps = (struct virtchnl2_get_ptp_caps *)msg; @@ -2288,7 +2288,7 @@ virtchnl2_vc_validate_vf_msg(__rte_unused struct virtchnl2_version_info *ver, u3 case VIRTCHNL2_OP_GET_PTP_TX_TSTAMP_LATCHES: valid_len = sizeof(struct virtchnl2_ptp_tx_tstamp_latches); - if (msglen >= valid_len) { + if (msglen > valid_len) { struct virtchnl2_ptp_tx_tstamp_latches *tx_tstamp_latches = (struct virtchnl2_ptp_tx_tstamp_latches *)msg; -- 2.43.0