From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D61F45497; Tue, 18 Jun 2024 22:03:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 353C9402CB; Tue, 18 Jun 2024 22:03:23 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id BCF574027C for ; Tue, 18 Jun 2024 22:03:21 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-701b0b0be38so5265782b3a.0 for ; Tue, 18 Jun 2024 13:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1718741001; x=1719345801; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=N1tBx0w85Fmkq5CS5bq/dYE2WTiJNBpMFf4zhMNqCyk=; b=kvmuYgY/S5C4fEuyCGak86VtuozothVoIWhdIRoC5hNrcDV+6bV4/V06pFFyvfhUxV VMOPngrgmtvN1UDve9uXDxvSO1eC5oLwI+saeOx8slxA/1n8rq0nLCGxMc7u06ZsOu4m CftGU5k3/OxV0aEj7pLHKedq8kjoQoM8tvr8Q4JB5iaP5FWtI/qL+apUMjqVWbiCzOFb p2oBVMz1DIdNUGmQERhDfkf++S8yepEazuHgK+U6XrhWHiH61++oz8ESZwi8vRmEbmMR Lzv1Wt1rb/F0jYsmeYOv5gdfOet1CVOo8B3hib9ySJGh5SSwpYECOhfl/INwlz//B1EF L3Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718741001; x=1719345801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N1tBx0w85Fmkq5CS5bq/dYE2WTiJNBpMFf4zhMNqCyk=; b=hevaibmqNvV1ccO5hwAulJmcJfk518V18VwltNcTiHDvAT839AivrR9TyCqYdgJa+M P4dL5R15DzvdJnrYqZ+0jil4L7pjoNibYyXTK5nG2Hcv4HWTPTINXxO4JaejSWWqqKGf XTPuuWFr7SrGKvIUHtxieoIwnR1LN+Y2ceDd2NK6Ct7VHTZ0Y18SJBk7fabtP07P2wDR ozWUtd/NjOKTKD+ragm6u1TjUa5deLOYKLLgsEFetEDlcY1vbpuuEMVv0CorFgChQOoR XilRmLXCqpSrNT2+C0EP8CV1pUAdBdKQHdVla8+uQbJnQoj1R0+ghSFiJHawQl8taBeO gTDw== X-Forwarded-Encrypted: i=1; AJvYcCW1DqH2SbmhIcwG+rUENHRjN5YCq+4M0il4fFvY48wnaUoxA8laJKj2+tPwTmUxwKINp0uOAme80WjVkjM= X-Gm-Message-State: AOJu0YwSXS72Z7itoNhVg1tzvNqmR5iMSkmx+0s1ceXTntX9M9+UyxD3 04CZf3ScETBGUqMj4uJU8ZxkTi1thr2aaMOKM6UwSaJub8pNsjNKGpB4dW7KzzQ= X-Google-Smtp-Source: AGHT+IGlFCONU+Pw3bBJh4Q5Sux9dog79L3n0tiaj2YMQJl28J3dzj7eSXOEI7n7nfnzIH5c0Ixp5A== X-Received: by 2002:a05:6a20:bca0:b0:1bc:9b00:e012 with SMTP id adf61e73a8af0-1bcbb60f95cmr540743637.58.1718741000778; Tue, 18 Jun 2024 13:03:20 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb3d1d7sm9327109b3a.134.2024.06.18.13.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jun 2024 13:03:20 -0700 (PDT) Date: Tue, 18 Jun 2024 13:03:18 -0700 From: Stephen Hemminger To: Daniel Gregory Cc: Stanislaw Kardach , Bruce Richardson , dev@dpdk.org, Liang Ma , Punit Agrawal , Pengcheng Wang , Chunsong Feng Subject: Re: [PATCH 1/5] config/riscv: add flag for using Zbc extension Message-ID: <20240618130318.0efacceb@hermes.local> In-Reply-To: <20240618174133.33457-2-daniel.gregory@bytedance.com> References: <20240618174133.33457-1-daniel.gregory@bytedance.com> <20240618174133.33457-2-daniel.gregory@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 18 Jun 2024 18:41:29 +0100 Daniel Gregory wrote: > diff --git a/config/riscv/meson.build b/config/riscv/meson.build > index 07d7d9da23..4bda4089bd 100644 > --- a/config/riscv/meson.build > +++ b/config/riscv/meson.build > @@ -26,6 +26,13 @@ flags_common = [ > # read from /proc/device-tree/cpus/timebase-frequency. This property is > # guaranteed on Linux, as riscv time_init() requires it. > ['RTE_RISCV_TIME_FREQ', 0], > + > + # Use RISC-V Carry-less multiplication extension (Zbc) for hardware > + # implementations of CRC-32C (lib/hash/rte_crc_riscv64.h), CRC-32 and CRC-16 > + # (lib/net/net_crc_zbc.c). Requires intrinsics available in GCC 14.1.0+ and > + # Clang 18.1.0+ > + # Make sure to add '_zbc' to your target's -march below > + ['RTE_RISCV_ZBC', false], > ] Please do not add more config options via compile flags. It makes it impossible for distros to ship one version. Instead, detect at compile or runtime