From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7069D4548E; Tue, 18 Jun 2024 16:18:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F5DD40DD8; Tue, 18 Jun 2024 16:18:02 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by mails.dpdk.org (Postfix) with ESMTP id DD299402B4 for ; Tue, 18 Jun 2024 15:47:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M9zJsXDzToSP8gGeZerIP9lVzr9hmKPZRXFB+hryMvz6il4m7+wxIz0FFo5pNNa8T7h4+DdTtdL9yFvFQblDwPZrBpve/n7CilQahfsoS7epYltl+i6SfuGirOeVB8WSxgF5FFoLbAqtVajSaRn8/Qn5s0KB862Kr6QyNysdhMzyp5e3Rte7B4xJUwa1bUpUKgglZj3teTdD8r6Zn+fBRBH/oE4ZUkbLwkK4i9heOJE7dyrDdjPs5JbEvVQTCTchcfy+WTDwf5gHKR7Eqe4bwDFUJTs5Y8oQ/4E+2SM7C5VDda5OBb2/W63zhdLPLMlIGp6EBPmKojHg79LryIQXDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EOZ8MQlDiMQmuG+3U/We1Fu8wQuhewmu7a+Za8iGUmI=; b=nUgHz5j9RVSYSU5nJQSQFP2uIYtR49oB8/G9bAjmIebkbBihCTUYAJQmKYm0S5xlH8+nw1aeVw31FJaxGQznIEVRw/0Krm5vXmw4DUPm2TaKjb+Tc8+dcKjUAQZHJyDxIIht0lGKaxxZpTXn3H2LhZjZnBL9C2Km/Ec87gUJOl2Rc0Tjo9A58s+6UhmzYWeihGh3UycNifFKAwezpjudyh+OMDhlE1Spaa4WMq4bhtpR60xMwwhLaOLqHe3u88GUuKPjOgDGXsX6FXeJtJSoyWytYkNxoAHwUO73TaWcEGSTpbIhc82fQxTPqEYrKhzOcl+kQ5TvqfEm8E/gzBs7aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOZ8MQlDiMQmuG+3U/We1Fu8wQuhewmu7a+Za8iGUmI=; b=hR+xcrGU+mM7g2NCPhWRSZcC4F1F4aOjUQ5F8/2Rd9Pl+M3AUe+jB/9L8169hPsIHh9VYHwwTrCegkJwN2yP48H9KAHM4IT3wlhM5D4RzmKvF99kJ1LlGX26IyZ2q6w4VidkIqi+et25kDHNbuaP4EbPt0/xWEDe8dyv97WvqrTjHnKp6VtTELVkjdR6rq6cwmapmieJM4CjfrcQt2DfrMxgD+HTpF+3+D1wQCJE409tnwRBHUsgVxaIml2idKaIq5l1Xlmoiwojb9XnEMJ5YrghNRFqkPAuAWShMfz2kLlQ9/RpV6xAQkytWh+cLuSWSgwb11KbDLTxnsoxvxQW+A== Received: from AS9P194CA0021.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::11) by PAXPR07MB9604.eurprd07.prod.outlook.com (2603:10a6:102:24b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.17; Tue, 18 Jun 2024 13:47:08 +0000 Received: from AMS0EPF00000193.eurprd05.prod.outlook.com (2603:10a6:20b:46d:cafe::48) by AS9P194CA0021.outlook.office365.com (2603:10a6:20b:46d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Tue, 18 Jun 2024 13:47:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AMS0EPF00000193.mail.protection.outlook.com (10.167.16.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Tue, 18 Jun 2024 13:47:06 +0000 Received: from seliius19819.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 18 Jun 2024 15:47:03 +0200 Received: from seliiuvd10563.seli.gic.ericsson.se (unknown [10.120.141.220]) by seliius19819.seli.gic.ericsson.se (Postfix) with ESMTP id 0071AC0000A2; Tue, 18 Jun 2024 15:47:01 +0200 (CEST) Received: by seliiuvd10563.seli.gic.ericsson.se (Postfix, from userid 93258) id 9BE6561BBC59; Tue, 18 Jun 2024 15:47:01 +0200 (CEST) From: Sriram Yagnaraman To: Bruce Richardson CC: , Sriram Yagnaraman Subject: [PATCH] net/ring: Set mbuf->port for received packets Date: Tue, 18 Jun 2024 15:47:00 +0200 Message-ID: <20240618134700.3709388-1-sriram.yagnaraman@ericsson.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF00000193:EE_|PAXPR07MB9604:EE_ X-MS-Office365-Filtering-Correlation-Id: 50ee6a5a-5e83-4ac0-6562-08dc8f9d24a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230037|1800799021|82310400023|376011|36860700010; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+8gI+AzWEWWBJApWhFOATiyuklZmeaxUnTfLoLMm6ESgK6FYYAdeyKDqQPcM?= =?us-ascii?Q?UETOGC+TbVtGYkAMXxDmhzGor7aC1Q71dQesPWtlEgvCp7SMZmXXwPkT0KMB?= =?us-ascii?Q?skKCGqNbLkM+9XX/iI2E8qEZXtVlRsr0RJSfW1BB9lugU7AAre79D17tnEem?= =?us-ascii?Q?qG3+jxB4xB3sMs7F+YmgfE2WA4rXM3zh6Y8w8PilvaGa+U/V++oypYspjDVz?= =?us-ascii?Q?Gl9Fu7fVlww0su1D+ivx+i2FfqkrHm8Styl/SbpRlBHIBfIKN720MgAIE2ux?= =?us-ascii?Q?EQ8h//lVgFvKysCpGrPOj2qH3KAj6oczGdrt5UgM2F0Rncwb8S6T4h54vNfg?= =?us-ascii?Q?hOgpVtrhyJQFmPsExDVkDuSf5an9AHpreuzkRd5OpnJK9KI1E25mkdh4pzkl?= =?us-ascii?Q?/LiHKWqvhSQNmeRljXyFNpPxRcfhbsvxg/jxy9nAz0kCHgoEbHOTyQ5GpItL?= =?us-ascii?Q?vMy/wo7wlrXngT0nDdAerYIRmx9MgnNaBIbh3Nr5oNl/gAP5WYkrQWEUbCVL?= =?us-ascii?Q?dhSIm4JXesbtIAmt3b4OcZdJ24TL9Jx2a7csp1bJlIY9VTQBQUGLB7bIqRtU?= =?us-ascii?Q?oKATbKYffJf2X0cywMqqV1GtSqG5EgCMu7AtDlHoB1vYMdfSmgS7MCI/04+i?= =?us-ascii?Q?x8zbcQpJCBeYE5mSGSFnDZzxejjd78No/uk4X2p1OChrfrL8L2eIvIB6l8ls?= =?us-ascii?Q?pOsN3q+kh9zgIDBcyTpPEuL9Hm5GnxrX1nJ0f6MIBuoJ/nLdsBdvmX+lSp/o?= =?us-ascii?Q?FRlSJVEPD3hog0iFMKZdaU+JMn+y/8ZB5W86ygP9fuNMYPYRha0kzZZJSMB4?= =?us-ascii?Q?domhV3y7k3EQ3l3Tyh3mpuoTlxHimI08KT9IK+0oGjv5i+OqRvVpR0r9ZMNM?= =?us-ascii?Q?uSn+tmFBUO4jkJgm8QLCEG+zarsJxxCzNw9DpQMT0fCo8KY10L/e8LvGWEi8?= =?us-ascii?Q?l51jsW7WwygKk6QgRUagQ+Iz+YMQGPs/4+XpdsOriDrBXju75Y75ZzA/FQLs?= =?us-ascii?Q?83/yiGIr7ywvuWSL2p+VXNRR2KW5k/3YSaD9bKtWj+yQv/UBF9zdBubie8bd?= =?us-ascii?Q?t6eS8wIEu7f7u0YKXCa1VL0BFFm7ayRUVzJcfkZWPNZ4bUfklE/OoIK6gh5R?= =?us-ascii?Q?DVYHWef4xEAzSKGf2mUOzhv5aGvHqa1zUBZ0QphEbwDmX2PVqqAGI68Vr1bg?= =?us-ascii?Q?uKvdOk3eXRJJTbyVTkGB6zJvDZn2n9+b5014zRlnSoEnDOepRWePC3HvAXRa?= =?us-ascii?Q?iQGNkSwFVoGtozEOfsGdochcKzpukBfnobKWpTHHju1bv2xZ2vwl8KEaStAk?= =?us-ascii?Q?kGiZRa3k5UAumRq2O/Q5KZmCKhB8e7DM2V83yEoGy0tKci3tERj5CQ5F7yNO?= =?us-ascii?Q?HVJ7MhL4RdxF+rFOyQUddA10DNwtW0bZO1l4WKSK4hfHT/J7LA=3D=3D?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230037)(1800799021)(82310400023)(376011)(36860700010); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 13:47:06.6337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50ee6a5a-5e83-4ac0-6562-08dc8f9d24a1 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000193.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR07MB9604 X-Mailman-Approved-At: Tue, 18 Jun 2024 16:18:01 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When using ring based ethdev, mbuf->port is not set on received packets. For applications that use the mbuf->port to identify the incoming port, especially when eventdev RX adapter pulls the packet on a different core and the application running on a worker core has no clue on the incoming port. This change adds some cycles at receive, to set the port of course. Please advise if this change is something that can be upstreamed. Signed-off-by: Sriram Yagnaraman --- drivers/net/ring/rte_eth_ring.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index b16f5d55f2..1346a0dba3 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -44,6 +44,7 @@ enum dev_action { struct ring_queue { struct rte_ring *rng; + uint16_t in_port; RTE_ATOMIC(uint64_t) rx_pkts; RTE_ATOMIC(uint64_t) tx_pkts; }; @@ -75,10 +76,13 @@ RTE_LOG_REGISTER_DEFAULT(eth_ring_logtype, NOTICE); static uint16_t eth_ring_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) { + unsigned int i; void **ptrs = (void *)&bufs[0]; struct ring_queue *r = q; const uint16_t nb_rx = (uint16_t)rte_ring_dequeue_burst(r->rng, ptrs, nb_bufs, NULL); + for (i = 0; i < nb_rx; i++) + bufs[i]->port = r->in_port; if (r->rng->flags & RING_F_SC_DEQ) r->rx_pkts += nb_rx; else @@ -155,7 +159,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id, struct rte_mempool *mb_pool __rte_unused) { struct pmd_internals *internals = dev->data->dev_private; - + internals->rx_ring_queues[rx_queue_id].in_port = dev->data->port_id; dev->data->rx_queues[rx_queue_id] = &internals->rx_ring_queues[rx_queue_id]; return 0; } @@ -414,10 +418,12 @@ do_eth_dev_ring_create(const char *name, internals->max_tx_queues = nb_tx_queues; for (i = 0; i < nb_rx_queues; i++) { internals->rx_ring_queues[i].rng = rx_queues[i]; + internals->rx_ring_queues[i].in_port = -1; data->rx_queues[i] = &internals->rx_ring_queues[i]; } for (i = 0; i < nb_tx_queues; i++) { internals->tx_ring_queues[i].rng = tx_queues[i]; + internals->tx_ring_queues[i].in_port = -1; data->tx_queues[i] = &internals->tx_ring_queues[i]; } -- 2.31.1