From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,
Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>
Subject: [PATCH 1/7] net/nfp: remove the unused parameter
Date: Wed, 19 Jun 2024 17:19:35 +0800 [thread overview]
Message-ID: <20240619091941.3479371-2-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20240619091941.3479371-1-chaoyong.he@corigine.com>
Remove the unused 'error' parameter of 'nfp_flow_setup()' interface.
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/flower/nfp_flower_flow.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c
index f05e35580c..e5ee6f1fb9 100644
--- a/drivers/net/nfp/flower/nfp_flower_flow.c
+++ b/drivers/net/nfp/flower/nfp_flower_flow.c
@@ -4567,7 +4567,6 @@ nfp_flow_setup(struct nfp_flower_representor *representor,
const struct rte_flow_attr *attr,
const struct rte_flow_item items[],
const struct rte_flow_action actions[],
- __rte_unused struct rte_flow_error *error,
bool validate_flag)
{
uint64_t cookie;
@@ -4644,7 +4643,7 @@ nfp_flow_validate(struct rte_eth_dev *dev,
representor = dev->data->dev_private;
priv = representor->app_fw_flower->flow_priv;
- nfp_flow = nfp_flow_setup(representor, attr, items, actions, error, true);
+ nfp_flow = nfp_flow_setup(representor, attr, items, actions, true);
if (nfp_flow == NULL) {
return rte_flow_error_set(error, ENOTSUP,
RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
@@ -4680,7 +4679,7 @@ nfp_flow_create(struct rte_eth_dev *dev,
app_fw_flower = representor->app_fw_flower;
priv = app_fw_flower->flow_priv;
- nfp_flow = nfp_flow_setup(representor, attr, items, actions, error, false);
+ nfp_flow = nfp_flow_setup(representor, attr, items, actions, false);
if (nfp_flow == NULL) {
rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
NULL, "This flow can not be offloaded.");
--
2.39.1
next prev parent reply other threads:[~2024-06-19 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 9:19 [PATCH 0/7] refactor flow validate and create interface Chaoyong He
2024-06-19 9:19 ` Chaoyong He [this message]
2024-06-19 9:19 ` [PATCH 2/7] net/nfp: exit as soon as possible Chaoyong He
2024-06-19 9:19 ` [PATCH 3/7] net/nfp: remove the duplicate logic of output action Chaoyong He
2024-06-19 9:19 ` [PATCH 4/7] net/nfp: split out the flow item check logic Chaoyong He
2024-06-19 9:19 ` [PATCH 5/7] net/nfp: simplify the flow item calculate logic Chaoyong He
2024-06-19 9:19 ` [PATCH 6/7] net/nfp: split out the flow action check logic Chaoyong He
2024-06-19 9:19 ` [PATCH 7/7] net/nfp: simplify the flow action calculate logic Chaoyong He
2024-07-07 2:11 ` [PATCH 0/7] refactor flow validate and create interface Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619091941.3479371-2-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).