From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03A454548E; Wed, 19 Jun 2024 11:20:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 597C842D7B; Wed, 19 Jun 2024 11:20:24 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2118.outbound.protection.outlook.com [40.107.237.118]) by mails.dpdk.org (Postfix) with ESMTP id 515B840289 for ; Wed, 19 Jun 2024 11:20:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQcoW847c/Tun3uqWJ1s5Inr+6fhEtk1NZLdbDLtYQQ0NvAsQvxNmFOMsDuFcf7zdJziKNPce6K0k2KbpHxpsrqU8wyX/RtPNqb9aga4HNpISLAOOdaTcA2/ghCqsYt3lbU2nDrb88OGzYIC4eg9u3JAQmVvGvuAAd1tLd35kCpdb0XEuuOfpAvWhD9hpJOBLWNiCV6EgFbVkxftbd8Z6MWKLphRfKu7mUn/5OmNOKY8siOjxGu4Jc6MTTSQ0kZKqqPY39ocdI0nX82VI3pxr7ZapP2ep8FPm1bUtN5rtIX+VZybXLINlyTlFeaA/CdnlDxurjl7w7Ockww6MdEHnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FNOddiEEX05cY1HztRd74BF6UOUsasA++eV5NvHrY9Y=; b=jLJJOVSbtIXM48tqNYw9G0oGzO4/LH8k0CxaoouUuIUwB8qhJW8ijy147o7kgmDBenxr67DH3WTk8v2ms9uMFVxIXbL1vpGirfSlGXfBfXilCiZ3B2DkStMcbMn/BybRZO+sWaz38PoRhADoyBjc4Rmw5UL+b4VaWFAby63m+x8PGj/UXA9cFmRWAWEXmC3USiCP5tmFcxBYBGS2bmMW8plqnLy5TcsEkIMjx7cXgy1gzjt0yDHp9XZeW4/dwORR8cGK7Y5RSzX5o1yBdi0I9CP9ywVpfImacrlIpAre4/2FLGSm076t+7CnIKSFljOWobv/u50c3BpyL+WrEyGRXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FNOddiEEX05cY1HztRd74BF6UOUsasA++eV5NvHrY9Y=; b=pzzMT+tbOHmFVmlCVe8YCNejaiLFxFlwvyFFdP57SxuSP1dV5xDNJVVbIhYSGyqUSBbxF53yMTjfFZLQNfNWrYSorRZmfDiOqxeUw2Xre7VVulgnsKfkp1fo0VQwM8XlGyVdtuE9vYYsiP8CjT6yCe/3j2RkSWyLtQEgIRBP2SE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY1PR13MB7041.namprd13.prod.outlook.com (2603:10b6:a03:5a8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Wed, 19 Jun 2024 09:20:02 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%4]) with mapi id 15.20.7677.030; Wed, 19 Jun 2024 09:20:02 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , Long Wu , Peng Zhang Subject: [PATCH 2/7] net/nfp: exit as soon as possible Date: Wed, 19 Jun 2024 17:19:36 +0800 Message-Id: <20240619091941.3479371-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240619091941.3479371-1-chaoyong.he@corigine.com> References: <20240619091941.3479371-1-chaoyong.he@corigine.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: BY5PR13CA0003.namprd13.prod.outlook.com (2603:10b6:a03:180::16) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY1PR13MB7041:EE_ X-MS-Office365-Filtering-Correlation-Id: b9712536-6bc1-43da-9ce5-08dc9040ff9a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230037|1800799021|366013|376011|52116011|38350700011; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IqapGoqqAXl1p0zaAJKQ2b5jD4Q2aP/aHTlyV8ieb4Ee6hdbiT5afz4Bc9PQ?= =?us-ascii?Q?bBSKenbAuOwYzyPkYqQJ9DVCnVDkH2n7YBXPbxXcr9G2ZlIIPQyOoH+rYnWh?= =?us-ascii?Q?5Yp94MfNRbgC2FzzsEv0bZMLuA5AwdQTWbEmQiYa212SLM0tMxIPJwc0sZWp?= =?us-ascii?Q?cIXNVTxjx/ojfdpuXshh06j5HeX3rXwkcTok5/pULvlpsvP1Zz6bRvbSiLwf?= =?us-ascii?Q?BBld/jRX07pNG26m1h5ffm8znhoPOBQ3yikE1Fp0IcqzMx7iXI6SiIv4IwFY?= =?us-ascii?Q?lFkejoX5KB1xzIiz7czpKf6v0vZipp0AF6yFlRyrjGa27M4Id0eLZq4J0ow+?= =?us-ascii?Q?IZrqDQKZfmQoUOmwpGgOxYtus9tFPPeyPcV/EPZPVXbzYnRFSHrB9r7lQHZk?= =?us-ascii?Q?KcuYFGddDO8Fw4N8GF4b4F8TgPBRRZGVS638jx5bFuNp3gJMFbGHOsFvWJDB?= =?us-ascii?Q?hTvc8sbeDH3wN1uUeu9Dq3BucmcmKvS7w/8Or8vsVGRG5+7gX17PcyzYJCus?= =?us-ascii?Q?fkAh36G7kskoYB+FWkHTaQLFUg988NX7ODOYzs8Lu7OavkI5pHCxl8A/65GJ?= =?us-ascii?Q?ooHKdT7PpdUD81VtjMVyVA7s1vG9bia4Y/XuDiGwU4+Jnd/VgC/mROUMTZxi?= =?us-ascii?Q?esUcS4mL8PNQVFOBq/fD3gSfBiH4sB3nEEkah7+C2Bnh+GtBcBLTksnwbtiB?= =?us-ascii?Q?hYLRJI1D4VF8vrI/7ylupRMVO5HONZ1GF3c9sIxrh2ivUfoz5GI2TQfkJfAP?= =?us-ascii?Q?8ILUfamZ7qBKxc0EE3w+nv4dxwXZ5uYLElxwpTpZqKXlIYxu8oj19ynxCdbC?= =?us-ascii?Q?WEqKb6zD0bWO059Fmc41sMu7M3d1OlLuHUzu1FmW++y/4jkYR7JHUlVQWVTh?= =?us-ascii?Q?0QqvXA8znaJ6pOVBtN2B6wNsiVXBOd2r7Dn5loywSSCHwU8K4TPV6bkPE+P8?= =?us-ascii?Q?yPGT6lL6y452yBx+O22iS8xqf1toqNkNOj581TDh1yUVbbiNJcxFDdIdPkh4?= =?us-ascii?Q?jMaBIE3nNnMEtMD62Dgh15zrVX+IfvM9TrfHgscSigOVb4VFDeYjIDHtFFaH?= =?us-ascii?Q?P+L6Nm/VTyteAkEKf4ehoGinyc03lOuIa4shhsc4roBWcW6us+SZX34eLB5B?= =?us-ascii?Q?BnlB/mcKd5EU+R6QQYI/JtdYNq4J7VB4Lfj9ap+dobuFXCtTDVEk9bXnxEVN?= =?us-ascii?Q?Bg2opWxGoECBjP23A5YHMBi+kn4baAO2CRr5YheQ3NLblg+E3v4+vy7dPfvh?= =?us-ascii?Q?hM6NN2IMWINLbplHsll49W8T7B1YKQ0R+sXsT37tUrUEtzpx30poMl8gSkd9?= =?us-ascii?Q?79gxQzOrxii7951lzxJpL1sdU0yUWi5qFhLPmFHDEMTeO+mOA/Fok8tWUyFn?= =?us-ascii?Q?y+DeCg8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(1800799021)(366013)(376011)(52116011)(38350700011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vPPFnAQkUPNOOxR5pCg7/fwh7LaZvEBj+PHyhITH6uMECTEA/5ZBcNaH3qL+?= =?us-ascii?Q?jExZNDVZ0qQLgPc30SV88KlYFKaBePOXcGnNk+Cck5SMgFGaMxZXiKNs6DNZ?= =?us-ascii?Q?FMO9UZx3u6+3aiTtMSobOtjGulVPOcp8mQG0OE/fp+44Ugfua5j1JjZ7JYvK?= =?us-ascii?Q?j/MnVZ3l+GNT5XNYagoteakwWrftf2lF9c14B1hny0nTMZbwbZAXe2A3twf5?= =?us-ascii?Q?7vCuQfpcNNPus5FYaO+pk9dfKpSivOZiK3+04kyQmMpNkQMcU2lJRjKMH/7W?= =?us-ascii?Q?zvq32sMHiqeg7nT8k+6brtUVBU7PhMNSIp8fntv7XcEUTwa6GSFrgbnsahQP?= =?us-ascii?Q?GeW34VyzMMxAfE301Rj6V9liPLhy3bpUwTXG+xVZp70WV0CW3onnS8tTkhQg?= =?us-ascii?Q?4n2BZUJOHeddGdX/UBtxJOkuRhx60yNdvg2WVe9ebMsAb+/p/B0iwXHdQycA?= =?us-ascii?Q?pLKQWWsX3CsAH/mJMio3iwsAEeukT/+onI4fy1GIe19KKVJYgY25Jx1K+rC6?= =?us-ascii?Q?80h+DHpm1v4J4zD+dF09VrJq1uF/N6ZizClI/it/xmmBoSfiEcCTdFsM7NYq?= =?us-ascii?Q?/4VoH3zJicVzmJR7xg4cc+ulUZd0yV92eJCfBQEKOtEdPkMLNiv9xiXZuaj4?= =?us-ascii?Q?DoXX7nSsQ4gEE+g6P8r7PAdxJ15Vi3lB+HcpZMU9yCNL2xdVHPT87JXUpRMi?= =?us-ascii?Q?q/dlj2uwIxfsevP4Uk26UhYDYWLhjohdHUUKRo5rECjD+nlDcHcG71KEtzN2?= =?us-ascii?Q?wLwTyOaSKYWrhwi0D62G3NBL5ap89TAIfjsiCqMtE3Ky6+bvDKjgAtMljv5t?= =?us-ascii?Q?JgKurqIW5jxA7oSLHSnHm7RCDt1gVB6KubjqKNnbRFWhsW030JGi0p7LOQX2?= =?us-ascii?Q?7uabXxlGMMFZhChgiqUIZVIcUpDBY7e1xJmulc9hfyQX+sHrBWiS4V1nuo4i?= =?us-ascii?Q?WrCbdO1jx7O8a0N2xc40HVg42d+Jp5PjrWT2Eo9Xv9S1gBeXDnrlLMKBJPWu?= =?us-ascii?Q?F59blVZZ/+r/+O+Qs9UuEF3+83m/lPjP2tU52nsw6LK4m0k2qOGmpfr1JUP9?= =?us-ascii?Q?kGWv8DOkX6CjiTAGBJ3++PiwqlqnPvTrypsl3nqdbSloJ/z8FBFEDP7i/pr/?= =?us-ascii?Q?sj3PIDTia41jcYqBy/gIzOfx8hKbtoJ57izTY0RMfTYIkN+n7eJOHVeXpfAa?= =?us-ascii?Q?mgTGzqco1jqQ8PYCErCuLQbGkfCUyaAyvI1k4gTJrS1PjYVYTujyJbFaWgeE?= =?us-ascii?Q?haLFvc5x6hoNlS1FhAK/l2wPQqN5iF+xADbUb8EZhK4I+7BrhjYmTm/o2XPr?= =?us-ascii?Q?gvwiFRiBWNGA8Y8rpRJ+3sHx3tVsk/wrZxyGrnYb9+fkln5872CSKVz1VPX1?= =?us-ascii?Q?z7uqdoHzvCGnw5nd4o9iGF4TngPf4tko06k4fxgnsgeMPpzZHD/i2QN3eE2c?= =?us-ascii?Q?PjO5UDZAGV1tUSDoSCqt1uXH9+EySr1sDUzpfd5UN+yp4adjxVFbQ7Tx8cAa?= =?us-ascii?Q?5/lJPCORCT/yxW+pg0pZ9xT46Mi+lLz5JlUFcwl6hQJoGJicvuGfHMBJhQO8?= =?us-ascii?Q?aql7lza2ZsOfDQaEn9II94d3spRH6R47RIcrUlw01qbvGuRGlFw9+BLNehkX?= =?us-ascii?Q?Lw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9712536-6bc1-43da-9ce5-08dc9040ff9a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2024 09:20:02.3326 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XRLzxcAHQbbT3ATaRm/fM3HYOdNTQOHdPqLj/aM55c/RxfXFjRObgG5OGF4nRXJltjTOySojGcDlsKHJoJY5nbi9+uXgF/BMJ/7orIMIMHk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR13MB7041 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add log message and exit as soon as possible. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_flow.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c index e5ee6f1fb9..f1388620d6 100644 --- a/drivers/net/nfp/flower/nfp_flower_flow.c +++ b/drivers/net/nfp/flower/nfp_flower_flow.c @@ -1479,7 +1479,7 @@ nfp_flow_key_layers_calculate(const struct rte_flow_item items[], const struct rte_flow_action actions[], struct nfp_fl_key_ls *key_ls) { - int ret = 0; + int ret; key_ls->key_layer_two = 0; key_ls->key_layer = NFP_FLOWER_LAYER_PORT; @@ -1490,10 +1490,19 @@ nfp_flow_key_layers_calculate(const struct rte_flow_item items[], key_ls->vlan = 0; key_ls->tun_type = NFP_FL_TUN_NONE; - ret |= nfp_flow_key_layers_calculate_items(items, key_ls); - ret |= nfp_flow_key_layers_calculate_actions(actions, key_ls); + ret = nfp_flow_key_layers_calculate_items(items, key_ls); + if (ret != 0) { + PMD_DRV_LOG(ERR, "flow items calculate failed"); + return ret; + } - return ret; + ret = nfp_flow_key_layers_calculate_actions(actions, key_ls); + if (ret != 0) { + PMD_DRV_LOG(ERR, "flow actions check failed"); + return ret; + } + + return 0; } static bool -- 2.39.1