From: Stephen Hemminger <stephen@networkplumber.org>
To: "Boyer, Andrew" <Andrew.Boyer@amd.com>
Cc: John McNamara <john.mcnamara@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: rte_bitmap_free() Re: DPDK Coverity issue 426433
Date: Thu, 20 Jun 2024 10:14:21 -0700 [thread overview]
Message-ID: <20240620101421.19c962c2@hermes.local> (raw)
In-Reply-To: <6A08397F-8D6E-4631-B63E-4CAE319F1463@amd.com>
On Thu, 20 Jun 2024 13:45:39 +0000
"Boyer, Andrew" <Andrew.Boyer@amd.com> wrote:
> Hello John,
> While Coverity is correct that this is a useless call, that's an internal implementation detail of rte_bitmap_free() - not really something the caller should know about.
>
> Can we annotate rte_bitmap_free() in some way to eliminate these? This is not the first PMD that's had this issue reported against it.
>
> Thanks,
> Andrew
>
The function should have not been declared void, no caller checks return value
and all other free() type functions are void. Not sure why function even
exists to be honest.
Also, bitmap code should really be split into inline (fast path)
and non inline (slow path).
prev parent reply other threads:[~2024-06-20 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240620111828.576992-1-john.mcnamara@intel.com>
2024-06-20 13:45 ` Boyer, Andrew
2024-06-20 17:14 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620101421.19c962c2@hermes.local \
--to=stephen@networkplumber.org \
--cc=Andrew.Boyer@amd.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).