From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34144454AC; Thu, 20 Jun 2024 19:14:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB031402E9; Thu, 20 Jun 2024 19:14:26 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 2B829402E2 for ; Thu, 20 Jun 2024 19:14:25 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7061d37dc9bso1024608b3a.2 for ; Thu, 20 Jun 2024 10:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1718903664; x=1719508464; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+q3PjIkwuAWUUN/zqWs8P9d/GKgs2SG523ULneXXb6E=; b=SvwZriwjl5DhSlI/tMiJmCXXIbiMethMmgStGYODy351WlKUKXNP4rMn0FlP3NFU2U 8kEiiqS4aCKuewoprqfur3cbSEmINYPoTxUcg8cgnhyoMh+ZjQzG6zUWVFmKfp9VXR3l mQER5njgIzIGjMgUZyhuq+3E2B19CbJIn1JxQFNm1HdwD/zKf9BSZuLllQ/x6MZLbslC pSHbiIKjs/QdAvCye4LuTU2cKrumPrt8iDVDKPmj+mkJkJLx7Rppajr7Yr+BT/Fvg38m +WKJdIwsjmdzH8SiCu+121e2KVeiix5cFcwlAPrLmZlFihsrybr410/2izJag4zzpJeb l7oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718903664; x=1719508464; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+q3PjIkwuAWUUN/zqWs8P9d/GKgs2SG523ULneXXb6E=; b=LclsB3yHDk1AUM3huMQt90mjoLhxE+7frWveGMT6YeUdF4iQjtBNtFYwPU33tJhYXW R2fjWMe9b3dwRryvk5JQYmTPgDLTBmqsmnQPqHJLaDc2teqZJTRpDIoPTdDcDp1IPXck 5x++2SjdPHuzCAsJ6/jx7LH0H9t7q/mpL4byREv1zLyyAj13sQUsMvnkTKarLiqawh6o gIZ7T/zsBVDdUPdLAXMdcgXcWuJCTAARIttITGwS/e/u0ibFdgkHAujaOwpZZO8/GCjq z5r6KPu3xk9fr3mqh4EubJc56V5frD16whNv7RENNlj1AGlF2fSVfyG6PSrTamlTLsw8 oxDg== X-Forwarded-Encrypted: i=1; AJvYcCUNNRYWcCEL9r1CtHaPOJZC6hex5Ce+G4k1OnsrtcxqhArG2jibK7C1S+k4aMIjwjADUya1w2EYuof/8Vc= X-Gm-Message-State: AOJu0Yzq2UjJ0O5F32IgApP5c+fJn6DtVVK83GTZQHuFgcHY8JPhUHj9 vZJXeYx/i0ZdCILuBH610JF9c64iLVwl5/G2CyNzRpQ+rgIW3VSEnvysis7nHT0= X-Google-Smtp-Source: AGHT+IFyHaQj/BjyMqB0wGn7w6kMJ7jvc6qW3mBtCheRdrBTI1O/rbl9qULMSr3OvsVpJOH8DfE60A== X-Received: by 2002:a05:6a20:6a9b:b0:1b8:44af:daba with SMTP id adf61e73a8af0-1bcbb56a5fcmr5357055637.31.1718903664118; Thu, 20 Jun 2024 10:14:24 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb3d2b7sm12556213b3a.106.2024.06.20.10.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 10:14:23 -0700 (PDT) Date: Thu, 20 Jun 2024 10:14:21 -0700 From: Stephen Hemminger To: "Boyer, Andrew" Cc: John McNamara , "dev@dpdk.org" Subject: Re: rte_bitmap_free() Re: DPDK Coverity issue 426433 Message-ID: <20240620101421.19c962c2@hermes.local> In-Reply-To: <6A08397F-8D6E-4631-B63E-4CAE319F1463@amd.com> References: <20240620111828.576992-1-john.mcnamara@intel.com> <6A08397F-8D6E-4631-B63E-4CAE319F1463@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 20 Jun 2024 13:45:39 +0000 "Boyer, Andrew" wrote: > Hello John, > While Coverity is correct that this is a useless call, that's an internal implementation detail of rte_bitmap_free() - not really something the caller should know about. > > Can we annotate rte_bitmap_free() in some way to eliminate these? This is not the first PMD that's had this issue reported against it. > > Thanks, > Andrew > The function should have not been declared void, no caller checks return value and all other free() type functions are void. Not sure why function even exists to be honest. Also, bitmap code should really be split into inline (fast path) and non inline (slow path).