From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5DB53454BC;
	Fri, 21 Jun 2024 17:19:34 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4A47042ED7;
	Fri, 21 Jun 2024 17:19:34 +0200 (CEST)
Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com
 [209.85.210.171])
 by mails.dpdk.org (Postfix) with ESMTP id E25A540265
 for <dev@dpdk.org>; Fri, 21 Jun 2024 17:19:22 +0200 (CEST)
Received: by mail-pf1-f171.google.com with SMTP id
 d2e1a72fcca58-7065e2fe7d9so256058b3a.3
 for <dev@dpdk.org>; Fri, 21 Jun 2024 08:19:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1718983162;
 x=1719587962; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=xcnfKXmxvv+HacnSJklGwhdTyBDBOm6Qk2swr5vy9Uc=;
 b=QsAv4r4n8Egb0znV0T+7JhTjJhdOOSC5GAGr2HM9yia5FBQSQlrvu4b20XObGEQQpq
 coRlxlUYdYt9SHGXwLDiOTkQGKmRJ/qI5yh+Bjptxy+SB/aoLqSqddY1yA1E1U/hP5rS
 T9OJtt0iex7O22HVP3Jy1NAxgMxt0mKNSVAUYqbGa35KDESMSIDYFalHJUAmlavHOnc1
 4CIRIgE2TRSIVKF9PiHb0mR/lVVxU0fzmJQfEooYoxi6YCxZtjz3sjaT5wLkODg+iVcN
 RaseOHu8v3F7dLzXrE/6ErNcUs7KoUGBloP3ZYPjtNTO0E/t1qSHlpQ3+hMog4PcaRl0
 mrrA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1718983162; x=1719587962;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=xcnfKXmxvv+HacnSJklGwhdTyBDBOm6Qk2swr5vy9Uc=;
 b=JHzqoerVsSDq3Ix1tamGZZ985E1lxMLoBTKvSSn/KEWtOMs7R9wgrcOgnZGD7scRIS
 7wXGxB7ThczBG5jFyIz8KzNb7d9A0gdvsxDDDH6CAE+h+xOvvbQBpeMZjnMEN6GBeqEz
 oto8+eqf9x7rVpNwraHVoqSgN2LKh8K7S/2AZRFhOq+ZEBAUS/ImzHFhGr9bSZEd3MUa
 YaxUCTDp3wkKo+6QB/XzbQruKulNl4yHqy2A/qso8uD88M/ViStfp+3Mf+hR9bW4KxO/
 ZjB9zmUloGbypuVgMj1Df6G3XsD9+EP4peHmLmrT2JFxXIYu/OUKorQSJ92n1+C09Jga
 ENzQ==
X-Gm-Message-State: AOJu0YxGcgfXZMiFlE9NMRbc6HdKfG9Tth4BGeVB02a+Ykbsuc3+ogFB
 NCR/UTHqrhMdZLH4GSq/SapSwB9C+tGQdsGMFRm3AYg50Oe9U8MYK8kKlR6cEKA=
X-Google-Smtp-Source: AGHT+IHigIYKIk8c5tRMka5JopEte8ccNxnhZvJxPFidBITP221WT67DslD+v2FfkjLU8yUZLlTJeA==
X-Received: by 2002:a05:6a00:2e11:b0:705:bc1a:b468 with SMTP id
 d2e1a72fcca58-70629cfb209mr12707399b3a.34.1718983162000; 
 Fri, 21 Jun 2024 08:19:22 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-706512900a0sm1573581b3a.149.2024.06.21.08.19.21
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 21 Jun 2024 08:19:21 -0700 (PDT)
Date: Fri, 21 Jun 2024 08:19:19 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= <mattias.ronnblom@ericsson.com>
Cc: <dev@dpdk.org>, <hofors@lysator.liu.se>, Morten =?UTF-8?B?QnLDuHJ1cA==?=
 <mb@smartsharesystems.com>, Abdullah Sevincer
 <abdullah.sevincer@intel.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>,
 David Hunt <david.hunt@intel.com>, "Vladimir Medvedkin"
 <vladimir.medvedkin@intel.com>, Bruce Richardson
 <bruce.richardson@intel.com>
Subject: Re: [PATCH v4 13/13] eal: provide option to use compiler memcpy
 instead of RTE
Message-ID: <20240621081919.33aba43c@hermes.local>
In-Reply-To: <20240620175731.420639-14-mattias.ronnblom@ericsson.com>
References: <20240620115027.420304-2-mattias.ronnblom@ericsson.com>
 <20240620175731.420639-1-mattias.ronnblom@ericsson.com>
 <20240620175731.420639-14-mattias.ronnblom@ericsson.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, 20 Jun 2024 19:57:31 +0200
Mattias R=C3=B6nnblom <mattias.ronnblom@ericsson.com> wrote:

> Provide build option to have functions in <rte_memcpy.h> delegate to
> the standard compiler/libc memcpy(), instead of using the various
> custom DPDK, handcrafted, per-architecture rte_memcpy()
> implementations.
>=20
> A new meson build option 'use_cc_memcpy' is added. By default,
> the compiler/libc memcpy() is used.
>=20
> The performance benefits of the custom DPDK rte_memcpy()
> implementations have been diminishing with every compiler release, and
> with current toolchains the use of a custom memcpy() implementation
> may even be a liability.
>=20
> This patch leaves an option to stay on the custom DPDK implementations,
> would that prove beneficial for certain applications or architectures.
>=20
> An additional benefit of this change is that compilers and static
> analysis tools have an easier time detecting incorrect usage of
> rte_memcpy() (e.g., buffer overruns, or overlapping source and
> destination buffers).
>=20
> Signed-off-by: Mattias R=C3=B6nnblom <mattias.ronnblom@ericsson.com>
> Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com>

Would like to mark rte_memcpy as deprecated in a future release.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>