From: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: dev@dpdk.org, Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Subject: [PATCH] net/mlx5: fix memleak for resource object
Date: Sun, 23 Jun 2024 14:35:39 +0400 [thread overview]
Message-ID: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> (raw)
Coverity issue: 426424
Fixes: e78e5408da89 ("net/mlx5: remove cache term from the list utility")
Cc: matan@nvidia.com
Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index d46beffd4c..1010b8e423 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -12010,9 +12010,12 @@ flow_matcher_create_cb(void *tool_ctx, void *cb_ctx)
items = *((const struct rte_flow_item **)(ctx->data2));
resource->matcher_object = mlx5dr_bwc_matcher_create
(resource->group->tbl, resource->priority, items);
- if (!(resource->matcher_object))
+ if (!(resource->matcher_object)) {
+ mlx5_free(resource);
return NULL;
+ }
#else
+ mlx5_free(resource);
return NULL;
#endif
}
--
2.43.0
next reply other threads:[~2024-06-23 10:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 10:35 Mahmoud Maatuq [this message]
2024-06-24 13:59 ` Dariusz Sosnowski
2024-06-24 19:10 ` Mahmoud Maatouq
2024-07-01 18:04 ` Dariusz Sosnowski
2024-06-24 19:41 ` [PATCH v2] " Mahmoud Maatuq
2024-07-01 18:07 ` Dariusz Sosnowski
2024-07-02 20:14 ` [PATCH v3] net/mlx5: fix matcher object memory leak Mahmoud Maatuq
2024-07-03 8:00 ` Bing Zhao
2024-07-03 8:08 ` Dariusz Sosnowski
2024-07-04 10:34 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240623103539.1690600-1-mahmoudmatook.mm@gmail.com \
--to=mahmoudmatook.mm@gmail.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).