From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BBF7454A7; Mon, 24 Jun 2024 09:49:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DB0A4066A; Mon, 24 Jun 2024 09:49:38 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id ADEB64014F for ; Mon, 24 Jun 2024 09:48:48 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45NLvSDB026147 for ; Mon, 24 Jun 2024 00:48:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-type:date:from:message-id:mime-version:subject:to; s= pfpt0220; bh=nle/+BunEvAglhMUpJy0ZiwFmjoJcyhB4WAYKAt8cx8=; b=PXP FQKKvw5890FkCUnmlgP83AeOIjSPuF3vRFO+Qo299/DxVccGbOHwbpmcm/WYH21y fi6QufVaFINw1SrErH7dPGZ+6Fl3EbuLRHXEQwGyAcUTdJvWkb0HU02XLKfUqJF4 0gsDovRLQDOw4D+qj+GuOSNVcLLJwNRatTBP7VhcHmeYqD0mxG9tanTR9oUPvoci hcLbkOzPegkt0A73/qbmHgaNkLB73orMGWvTX0RtjQ7L4NEbl1j/GwxoBxBw+7+n lkTm0F8l3z94PJN2LjaODMNCFDT8JwCXu+t3ylxtrLcscx+1J+Bm18aFES79ID9m u2huO97Q4VynW0h/SuA== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ywx4gbwvx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 24 Jun 2024 00:48:47 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 24 Jun 2024 00:48:46 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 24 Jun 2024 00:48:46 -0700 Received: from localhost.localdomain (unknown [10.29.52.211]) by maili.marvell.com (Postfix) with ESMTP id 3A6483F7079; Mon, 24 Jun 2024 00:48:42 -0700 (PDT) From: Harman Kalra To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra CC: , , Amit Prakash Shukla Subject: [PATCH 1/6] net/cnxk: stale offload flag reset Date: Mon, 24 Jun 2024 13:18:16 +0530 Message-ID: <20240624074822.88955-1-hkalra@marvell.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-GUID: OOeTMj6yQrr4o3x4jJKsP2TftYItWXm5 X-Proofpoint-ORIG-GUID: OOeTMj6yQrr4o3x4jJKsP2TftYItWXm5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-24_07,2024-06-21_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Amit Prakash Shukla mbuf buffer is not reset on tx and hence few fields has stale data from previous packets. Due to stale offload flags, in one of the scenarios with OVS, VxLAN offload flag was set while packet did not have the VxLAN header. In the OVS packet path, the flag was read and accordingly VxLAN processing was done but as packet did not have VxLAN header it caused segfault. This patch resets mbuf offload flags in rx burst function. Signed-off-by: Amit Prakash Shukla --- drivers/net/cnxk/cnxk_eswitch_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cnxk/cnxk_eswitch_rxtx.c b/drivers/net/cnxk/cnxk_eswitch_rxtx.c index d57e32b091..0200392f2d 100644 --- a/drivers/net/cnxk/cnxk_eswitch_rxtx.c +++ b/drivers/net/cnxk/cnxk_eswitch_rxtx.c @@ -194,7 +194,7 @@ cnxk_eswitch_dev_rx_burst(struct cnxk_eswitch_dev *eswitch_dev, uint16_t qid, mbuf->vlan_tci = rx->vtag0_tci; /* Populate RSS hash */ mbuf->hash.rss = cqe->tag; - mbuf->ol_flags |= RTE_MBUF_F_RX_RSS_HASH; + mbuf->ol_flags = RTE_MBUF_F_RX_RSS_HASH; pkts[pkt] = mbuf; roc_prefetch_store_keep(mbuf); plt_esw_dbg("Packet %d rec on queue %d esw qid %d hash %x mbuf %p vlan tci %d", -- 2.18.0