From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9F8D454DF; Mon, 24 Jun 2024 12:03:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1B1140E39; Mon, 24 Jun 2024 12:03:13 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 9CDE740A77 for ; Mon, 24 Jun 2024 12:02:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719223352; x=1750759352; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nZU8o2JCNaC9u+4hBIwhDFA1aXbgKdVbR4QJepfQavI=; b=UeC8TQo9o5lvF7+dc5exNaHmrECLLiZDaiF9dXEozpjxoYixjrRRERSg xC05geFj5sD2OCFDpdUXA5eZt1NshSo0zHEK5yDCQmAAlS4iIxkxC2pqP 9KFkJwGvWMRgU5cYm/hbqLuDZeFPcYzKNFvYtFqwqSkCCa5ML6r4WkC5R f+i2u+YKzsqJGZzQHMLrRl1NFnyKRIAoJTeHlmgXrEYepO2WI+h31Ulgv 8zaKRA1eX57/pUXG6JGVTk/HwTtWJ5vJqBsouIG4fktvgMbXo1SBaEDTP +X3OSr4V7GiFVckaA7avqL6B86oAJTVk2vED7s7+R8wOkjIRjN912D2Ys Q==; X-CSE-ConnectionGUID: oDSpI/FgQZe6bL4CD4sdyA== X-CSE-MsgGUID: 0xaz41KVSX+wfsy5OWQDeg== X-IronPort-AV: E=McAfee;i="6700,10204,11112"; a="19086445" X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="19086445" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2024 03:02:31 -0700 X-CSE-ConnectionGUID: EYEKOXZDQjG3jAeqIDjhMg== X-CSE-MsgGUID: QVIAWgA6SKm7BLPrwhF2kw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,261,1712646000"; d="scan'208";a="74479145" Received: from unknown (HELO npf-hyd-clx-03..) ([10.145.170.182]) by fmviesa001.fm.intel.com with ESMTP; 24 Jun 2024 03:02:28 -0700 From: Soumyadeep Hore To: bruce.richardson@intel.com, anatoly.burakov@intel.com Cc: dev@dpdk.org Subject: [PATCH v5 13/21] common/idpf: update in PTP message validation Date: Mon, 24 Jun 2024 09:16:36 +0000 Message-ID: <20240624091644.2404658-14-soumyadeep.hore@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240624091644.2404658-1-soumyadeep.hore@intel.com> References: <20240618105722.2326987-22-soumyadeep.hore@intel.com> <20240624091644.2404658-1-soumyadeep.hore@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the message for getting timestamp latches is sent by the driver, number of latches is equal to 0. Current implementation of message validation function incorrectly notifies this kind of message length as invalid. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/virtchnl2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/virtchnl2.h b/drivers/common/idpf/base/virtchnl2.h index e76ccbd46f..24a8b37876 100644 --- a/drivers/common/idpf/base/virtchnl2.h +++ b/drivers/common/idpf/base/virtchnl2.h @@ -2272,7 +2272,7 @@ virtchnl2_vc_validate_vf_msg(__rte_unused struct virtchnl2_version_info *ver, u3 case VIRTCHNL2_OP_GET_PTP_CAPS: valid_len = sizeof(struct virtchnl2_get_ptp_caps); - if (msglen >= valid_len) { + if (msglen > valid_len) { struct virtchnl2_get_ptp_caps *ptp_caps = (struct virtchnl2_get_ptp_caps *)msg; @@ -2288,7 +2288,7 @@ virtchnl2_vc_validate_vf_msg(__rte_unused struct virtchnl2_version_info *ver, u3 case VIRTCHNL2_OP_GET_PTP_TX_TSTAMP_LATCHES: valid_len = sizeof(struct virtchnl2_ptp_tx_tstamp_latches); - if (msglen >= valid_len) { + if (msglen > valid_len) { struct virtchnl2_ptp_tx_tstamp_latches *tx_tstamp_latches = (struct virtchnl2_ptp_tx_tstamp_latches *)msg; -- 2.43.0