From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F177454E1; Mon, 24 Jun 2024 15:24:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3185E40DD6; Mon, 24 Jun 2024 15:24:40 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 0A70140B92 for ; Mon, 24 Jun 2024 15:24:34 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45OARDdp022070 for ; Mon, 24 Jun 2024 06:24:34 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pfpt0220; bh=BAPY6GUmqsWMAO0RX+Vre2W9M gAyvZpZjqtD2GY4Ppo=; b=bPDrFF676clvedIla+/+95M0gq34IYeLdh9pPZIc1 8IWVzM+0d9ACmq8hkkA5mcwiSRrK7nQR6l8lKL3vleBdh77MLNw9ZN+piOu0ddDY EMizSOLgr0waeNuLDZlEfsItjtnCGVoZjfV0Y4KlQ6jKJP3f+Zw9aT4GLlqHNfM2 EH/rhUEU6iZzfcflCQQzPpCjBPzYnH/8eEfM+eG7mgRI5hvg9SKbuRYeCBVBM6YT bUbJ/ZFU8oCC1AyS9yMUWW5My65rfC+rYONZhBTz/0pRQVbIzeWGc1uKcST69rtO 462ZPFPq0rgU/8SAWPTKdE2JJ4gHrcC+daFklBy+ysLdg== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3yy72f0hvh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 24 Jun 2024 06:24:34 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 24 Jun 2024 06:24:33 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 24 Jun 2024 06:24:33 -0700 Received: from localhost.localdomain (unknown [10.29.52.211]) by maili.marvell.com (Postfix) with ESMTP id 7B9466268BD; Mon, 24 Jun 2024 06:24:30 -0700 (PDT) From: Harman Kalra To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra CC: , , Hanumanth Pothula Subject: [PATCH v3 5/5] net/cnxk: fix representor port mapping Date: Mon, 24 Jun 2024 18:54:15 +0530 Message-ID: <20240624132415.32291-5-hkalra@marvell.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20240624132415.32291-1-hkalra@marvell.com> References: <20240624074822.88955-1-hkalra@marvell.com> <20240624132415.32291-1-hkalra@marvell.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-ORIG-GUID: lYFadQQyBAz6FH4SXRASCrwNdHE5Gy-1 X-Proofpoint-GUID: lYFadQQyBAz6FH4SXRASCrwNdHE5Gy-1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-24_10,2024-06-24_01,2024-05-17_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Hanumanth Pothula As part of ready and exit messages only first half of the ports were processed, i.e. represented to representor port mapping was setup and released. While later half of the ports were not processed. Fixes: 804c585658ea ("net/cnxk: add representor control plane") Signed-off-by: Hanumanth Pothula --- V2: * Added fixes tag * Better commit message drivers/net/cnxk/cnxk_rep_msg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/cnxk/cnxk_rep_msg.c b/drivers/net/cnxk/cnxk_rep_msg.c index f3a62a805e..29ce94e5c6 100644 --- a/drivers/net/cnxk/cnxk_rep_msg.c +++ b/drivers/net/cnxk/cnxk_rep_msg.c @@ -369,12 +369,12 @@ notify_rep_dev_ready(cnxk_rep_msg_ready_data_t *rdata, void *data, memset(rep_id_arr, 0, RTE_MAX_ETHPORTS * sizeof(uint64_t)); /* For ready state */ - if ((rdata->nb_ports / 2) > eswitch_dev->repr_cnt.nb_repr_probed) { + if (rdata->nb_ports > eswitch_dev->repr_cnt.nb_repr_probed) { rc = CNXK_REP_CTRL_MSG_NACK_INV_REP_CNT; goto fail; } - for (i = 0; i < rdata->nb_ports / 2; i++) { + for (i = 0; i < rdata->nb_ports; i++) { rep_id = UINT16_MAX; rc = cnxk_rep_state_update(eswitch_dev, rdata->data[i], &rep_id); if (rc) { @@ -475,7 +475,7 @@ notify_rep_dev_exit(cnxk_rep_msg_exit_data_t *edata, void *data) rc = -EINVAL; goto fail; } - if ((edata->nb_ports / 2) > eswitch_dev->repr_cnt.nb_repr_probed) { + if (edata->nb_ports > eswitch_dev->repr_cnt.nb_repr_probed) { rc = CNXK_REP_CTRL_MSG_NACK_INV_REP_CNT; goto fail; } -- 2.18.0