From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEE4D454F1; Tue, 25 Jun 2024 17:44:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E20F74278B; Tue, 25 Jun 2024 17:44:50 +0200 (CEST) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id 6F7BA40677 for ; Tue, 25 Jun 2024 17:44:49 +0200 (CEST) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2c8517aab46so2272533a91.1 for ; Tue, 25 Jun 2024 08:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1719330288; x=1719935088; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3YztMWZOldoQ2RX+/NF6Ok+sb/4GN0DGXIf8zo1RFLs=; b=JK+8d6IYtLl5wFdeE8clpxsSilvabXwIHescL3ZbvHZHgaObnqcEMdzi1KBMjYf8n6 tXEHyJdAy/vRUOcuLkWD564h0+I3a/DnNh9ro529N+KVOOxKBMTjIqsMDQxsAA3XjXpp Pk0ze4K8LolYaXZfZiB2ps8Ty3Cu4GY05FX1Vkaik4xZUBjkgTfA1nbGmJQQ8uksVOvY /xtoH6TB4PsH2OxoA13tXf79tB8OBaVau91rt8OTjNF7wFHgkPKoYflcRKkgfcElDTMH 5nCTOI96Od/fdioXP23CNwdAarQVYsw1sSMbnZL53ZiylyW/vPKjqXomKBPvPe5hB3od 4kuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719330288; x=1719935088; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3YztMWZOldoQ2RX+/NF6Ok+sb/4GN0DGXIf8zo1RFLs=; b=Rg3gRHshjf+Eusoohqiok+Lj80Bck0Bw0W1qX9pEYxHIdVrs2axEeEj6boFR1qdch6 u4U3FxU4Pz7ICibPyzx72iJJX3N+GJDUqWNVwgJJlPHY5Rl66MQ5ScXQFKBUcemjrqV1 wvWqIwEyvl/mEooB0OBGURzdoxvKr8GIFT5iLedPRGl6TvHl692FTfrpMeisUKuZlmrt pqRpJrlVDqWbEUp5FZIDIQ+AxImSNzaIahG0MuD7eaj0oaHc7H6G3/Dh+vee+/BBBwLa bPEOuI6q59Ouk/kLQ16PTBrdh6RpjBM+PErcYjSj3ao9ftkIdrfAYq1eqGcgo1Rq9X70 UiNg== X-Forwarded-Encrypted: i=1; AJvYcCVt27g0IpYSUPlHcrWP8GyKSctH2uK8F7Dv7XnA4YNfUcbxxfD+3r2FbffktRtLXMOaMOkf12Bv/G2l7Sg= X-Gm-Message-State: AOJu0Yz5XbicxEZfsFjOEJyOzfDly42lvyODaIvmKtnxBh/EqJOO2ERV VcTfnG/amxIOAP9hPcczHhCDQ0Ym1wycWHwemXdYaMEgaSBrXn9zyAAgIZQ5nb++9kTJ1mYz70K IC/s= X-Google-Smtp-Source: AGHT+IHFAFTFytsjZpLe/5+0VSQ+Ndg+wqJAMyR9K2vA4Ryb5y74aHlJwP0FLCPdY7gIpCJIcOGIkA== X-Received: by 2002:a17:90a:7891:b0:2c2:d8d7:bf65 with SMTP id 98e67ed59e1d1-2c858199a63mr6900916a91.7.1719330288551; Tue, 25 Jun 2024 08:44:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c8af9e1e8esm1272144a91.0.2024.06.25.08.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jun 2024 08:44:48 -0700 (PDT) Date: Tue, 25 Jun 2024 08:44:46 -0700 From: Stephen Hemminger To: Maxime Coquelin Cc: Mattias =?UTF-8?B?UsO2bm5ibG9t?= , dev@dpdk.org, hofors@lysator.liu.se, Morten =?UTF-8?B?QnLDuHJ1cA==?= , Abdullah Sevincer , Pavan Nikhilesh , David Hunt , Vladimir Medvedkin , Bruce Richardson Subject: Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy Message-ID: <20240625084446.3fe45d3b@hermes.local> In-Reply-To: References: <20240620115027.420304-2-mattias.ronnblom@ericsson.com> <20240620175731.420639-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 25 Jun 2024 17:29:35 +0200 Maxime Coquelin wrote: > Hi Mattias, >=20 > On 6/20/24 19:57, Mattias R=C3=B6nnblom wrote: > > This patch set make DPDK library, driver, and application code use the > > compiler/libc memcpy() by default when functions in are > > invoked. > >=20 > > The various custom DPDK rte_memcpy() implementations may be retained > > by means of a build-time option. > >=20 > > This patch set only make a difference on x86, PPC and ARM. Loongarch > > and RISCV already used compiler/libc memcpy(). =20 >=20 > It indeed makes a difference on x86! >=20 > Just tested latest main with and without your series on > Intel(R) Xeon(R) Gold 6438N. >=20 > The test is a simple IO loop between a Vhost PMD and a Virtio-user PMD: > # dpdk-testpmd -l 4-6 --file-prefix=3Dvirtio1 --no-pci --vdev=20 > 'net_virtio_user0,mac=3D00:01:02:03:04:05,path=3D./vhost-net,server=3D1,m= rg_rxbuf=3D1,in_order=3D1'=20 > --single-file-segments -- -i > testpmd> start =20 >=20 > # dpdk-testpmd -l 8-10 --file-prefix=3Dvhost1 --no-pci --vdev=20 > 'net_vhost0,iface=3Dvhost-net,client=3D1' --single-file-segments -- -i > testpmd> start tx_first 32 =20 >=20 > Latest main: 14.5Mpps > Latest main + this series: 10Mpps >=20 > So for me, it should be disabled by default. >=20 > Regards, > Maxime What is the size of the copy being done? Which compiler version?