DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH] net/tap/bpf: fix meson warning
Date: Tue, 25 Jun 2024 10:06:52 -0700	[thread overview]
Message-ID: <20240625170652.12017-1-stephen@networkplumber.org> (raw)

Meson was warning that run_command was used without check and
the result of that will change in future version.

In this case, the command (uname -m) should be checked.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/tap/bpf/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/tap/bpf/meson.build b/drivers/net/tap/bpf/meson.build
index df497948e2..35d7438c74 100644
--- a/drivers/net/tap/bpf/meson.build
+++ b/drivers/net/tap/bpf/meson.build
@@ -44,7 +44,7 @@ libbpf_include_dir = libbpf.get_variable(pkgconfig : 'includedir')
 # The include files <linux/bpf.h> and others include <asm/types.h>
 # but <asm/types.h> is not defined for multi-lib environment target.
 # Workaround by using include directoriy from the host build environment.
-machine_name = run_command('uname', '-m').stdout().strip()
+machine_name = run_command('uname', '-m', check: true).stdout().strip()
 march_include_dir = '/usr/include/' + machine_name + '-linux-gnu'
 
 clang_flags = [
-- 
2.43.0


             reply	other threads:[~2024-06-25 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 17:06 Stephen Hemminger [this message]
2024-06-25 17:17 ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625170652.12017-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).