From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCB3845501; Wed, 26 Jun 2024 15:52:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ABCA402A3; Wed, 26 Jun 2024 15:52:30 +0200 (CEST) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by mails.dpdk.org (Postfix) with ESMTP id 7E38E400EF for ; Wed, 26 Jun 2024 15:52:27 +0200 (CEST) Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-445032cf88fso4238431cf.1 for ; Wed, 26 Jun 2024 06:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1719409947; x=1720014747; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NONUSKsm5d8NN0z6YB3VZ+tTNaCJFwLobomjvIqmemI=; b=OCvyg/JZvNpSIdrUfmybfyJ5yjc69s37cemOdaLTKUSoFT1V/0plm5rClEFjJMquf0 6i573ripj1YhZbHwK2R4LNeLUFRhc6zyfu9UuZJ7ICIZIQm/cJjuRuBHDTCVQ/R/XKIo 4ll+ZTxbPT6luHCjUIWx0O42jbsPmCHdNGWTo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719409947; x=1720014747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NONUSKsm5d8NN0z6YB3VZ+tTNaCJFwLobomjvIqmemI=; b=HZneynr+FMWthGNasEsnLrO4/Un9fD0N4ZQYe+/HZDu2HrYwHhMXv9AnOv1bIOkiHI LEIQUa8+eHkPCGCdZ3ywXdkZ+4fVoDr0W0Q3BKEQ6LsZ+sOWeXa4oCaOlhRbc5jdNE69 qtiVjq7/a8Xo3NwtQC3/bchHW+Hym8hS5fVO/BMuDpkzE7unrEmt3D9gWaMBev0+1Sxz tpAkby/es8NRW+GGTBbXl4D/o2+QN63RBIHvAIQBTaY1nLvBS2lHu/uKW9vWj8RyGSBM s90g/O16xwP7oiEH8WHXGsMTFi9uNTLwffVUl/x7dj7Z6stTALR0/V82dzs59pBbowae +kcA== X-Gm-Message-State: AOJu0YyAAXWgzxDRz8+4f2LZKA5kCbVxxXWjZVbne0Znp5YLF2mKzvO8 K06bRXVHRjA7m0lQq1jDh4izRwvBiKLF04AlE0OGulqeEn+STwknmS7dBNcAqIc= X-Google-Smtp-Source: AGHT+IHVlH3EAjh9TKOn8T5j4+t4phhw2iBTXi2Mogq1vWj0YnnYO5SBw0f/skvznkQFgJaXiF+eKg== X-Received: by 2002:ac8:5f4b:0:b0:444:af27:3855 with SMTP id d75a77b69052e-444d933104emr106799441cf.67.1719409946740; Wed, 26 Jun 2024 06:52:26 -0700 (PDT) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-444c2caf5eesm67109921cf.96.2024.06.26.06.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 06:52:26 -0700 (PDT) From: Dean Marx To: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, jspewock@iol.unh.edu, bruce.richardson@intel.com, luca.vizzarro@arm.com Cc: dev@dpdk.org, Dean Marx Subject: [PATCH v3 2/3] dts: add functions to testpmd shell Date: Wed, 26 Jun 2024 09:51:48 -0400 Message-ID: <20240626135149.32557-2-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240626135149.32557-1-dmarx@iol.unh.edu> References: <20240617194638.12926-2-dmarx@iol.unh.edu> <20240626135149.32557-1-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 157 +++++++++++++++--- 1 file changed, 136 insertions(+), 21 deletions(-) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index ec22f72221..a1928b2cec 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -645,27 +645,6 @@ def start(self, verify: bool = True) -> None: "Not all ports came up after starting packet forwarding in testpmd." ) - def stop(self, verify: bool = True) -> None: - """Stop packet forwarding. - - Args: - verify: If :data:`True` , the output of the stop command is scanned to verify that - forwarding was stopped successfully or not started. If neither is found, it is - considered an error. - - Raises: - InteractiveCommandExecutionError: If `verify` is :data:`True` and the command to stop - forwarding results in an error. - """ - stop_cmd_output = self.send_command("stop") - if verify: - if ( - "Done." not in stop_cmd_output - and "Packet forwarding not started" not in stop_cmd_output - ): - self._logger.debug(f"Failed to stop packet forwarding: \n{stop_cmd_output}") - raise InteractiveCommandExecutionError("Testpmd failed to stop packet forwarding.") - def get_devices(self) -> list[TestPmdDevice]: """Get a list of device names that are known to testpmd. @@ -806,6 +785,142 @@ def show_port_stats(self, port_id: int) -> TestPmdPortStats: return TestPmdPortStats.parse(output) + def stop_port_queue( + self, + port_id: int, + queue_id: int, + is_rx_queue: bool, + verify: bool = True + ) -> None: + """Stops a given queue on a port. + + Args: + port_id: ID of the port that the queue belongs to. + queue_id: ID of the queue to stop. + is_rx_queue: Type of queue to stop. If :data:`True` an RX queue will be stopped, + otherwise a TX queue will be stopped. + verify: If :data:`True` an additional command will be sent to verify the queue stopped. + Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the queue fails + to stop. + """ + port_type = "rxq" if is_rx_queue else "txq" + stop_cmd_output = self.send_command(f"port {port_id} {port_type} {queue_id} stop") + if verify: + if ( + # Rx/Tx queue state: ... + f"{port_type.capitalize()[:-1]} queue state: stopped" not in + self.send_command(f"show {port_type} info {port_id} {queue_id}") + ): + self._logger.debug( + f"Failed to stop {port_type} {queue_id} on port {port_id}:\n{stop_cmd_output}" + ) + raise InteractiveCommandExecutionError( + f"Test pmd failed to stop {port_type} {queue_id} on port {port_id}" + ) + + def start_port_queue( + self, + port_id: int, + queue_id: int, + is_rx_queue: bool, + verify: bool = True + ) -> None: + """Starts a given RX queue on a port. + + Args: + port_id: ID of the port that the queue belongs to. + queue_id: ID of the queue to start. + is_rx_queue: Type of queue to start. If :data:`True` an RX queue will be started, + otherwise a TX queue will be started. + verify: if :data:`True` an additional command will be sent to verify that the queue was + started. Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the queue fails to + start. + """ + port_type = "rxq" if is_rx_queue else "txq" + self.setup_port_queue(port_id, queue_id, port_type) + start_cmd_output = self.send_command(f"port {port_id} {port_type} {queue_id} start") + if verify: + if ( + # Rx/Tx queue state: ... + f"{port_type.capitalize()[:-1]} queue state: started" not in + self.send_command(f"show {port_type} info {port_id} {queue_id}") + ): + self._logger.debug( + f"Failed to start {port_type} {queue_id} on port {port_id}:\n{start_cmd_output}" + ) + raise InteractiveCommandExecutionError( + f"Test pmd failed to start {port_type} {queue_id} on port {port_id}" + ) + + def setup_port_queue(self, port_id: int, queue_id: int, is_rx_queue: bool) -> None: + """Setup a given queue on a port. + + This functionality cannot be verified because the setup action only takes effect when the + queue is started. + + Args: + port_id: ID of the port where the queue resides. + queue_id: ID of the queue to setup. + is_rx_queue: Type of queue to setup. If :data:`True` an RX queue will be setup, + otherwise a TX queue will be setup. + """ + self.send_command(f"port {port_id} {'rxq' if is_rx_queue else 'txq'} {queue_id} setup") + + def set_promisc_on(self, port: int, on: bool, verify: bool = True): + """Turns promiscuous mode on/off for the specified port + + Args: + port: port number to use, should be within 0-32. + on: if :data:`True`, turn promisc mode on, otherwise turn off. + verify: if :data:`True` an additional command will be sent to verify that promisc mode + is properly set. Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and promisc mode + is not correctly set. + """ + if on: + promisc_output = self.send_command(f"set promisc {port} on") + else: + promisc_output = self.send_command(f"set promisc {port} off") + if verify: + if (on and "Promiscuous mode: enabled" not in + self.send_command(f"show port info {port}")): + self._logger.debug(f"Failed to set promisc mode on port {port}: \n{promisc_output}") + raise InteractiveCommandExecutionError(f"Testpmd failed to set promisc mode on port {port}.") + elif (not on and "Promiscuous mode: disabled" not in + self.send_command(f"show port info {port}")): + self._logger.debug(f"Failed to set promisc mode on port {port}: \n{promisc_output}") + raise InteractiveCommandExecutionError(f"Testpmd failed to set promisc mode on port {port}.") + + + def set_verbose(self, level: int, verify: bool = True): + """Set debug verbosity level. + + Args: + level: 0 - silent except for error + 1 - fully verbose except for Tx packets + 2 - fully verbose except for Rx packets + >2 - fully verbose + verify: if :data:`True` an additional command will be sent to verify that verbose level + is properly set. Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and verbose level + is not correctly set. + """ + verbose_output = self.send_command(f"set verbose {level}") + if verify: + if "Change verbose level" not in verbose_output: + self._logger.debug(f"Failed to set verbose level to {level}: \n{verbose_output}") + raise InteractiveCommandExecutionError(f"Testpmd failed to set verbose level to {level}.") + def close(self) -> None: """Overrides :meth:`~.interactive_shell.close`.""" self.send_command("quit", "") -- 2.44.0