From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EAB245524; Fri, 28 Jun 2024 18:20:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06293410D0; Fri, 28 Jun 2024 18:20:04 +0200 (CEST) Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by mails.dpdk.org (Postfix) with ESMTP id 3BFE140A71 for ; Fri, 28 Jun 2024 18:20:03 +0200 (CEST) Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6b501a4344bso3546366d6.3 for ; Fri, 28 Jun 2024 09:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1719591602; x=1720196402; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D3A1JXxwlQ9nHfOTooEpkns0NIoeN6u6xQ7jFEUNRMI=; b=jP2TLY6sTfkijRilIo3RmKV4nSdcI78jdUulLwCDqpoe6yj/CHh8sPP65XPiDMrHVu /CC96KWfhGmUbrmfIhn9zPk+p8IIFwQHTbyxwKpqGeXCWUdroepV2xUT3ip6Wo685K+N 17nOgKQ648zzT358SloFLLfd4G1tecqcfiIK0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719591602; x=1720196402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D3A1JXxwlQ9nHfOTooEpkns0NIoeN6u6xQ7jFEUNRMI=; b=UQb4L/SvcJAFtWKgwovNi7DL+7Ay+Twe8KlDUor/Bii7vPT3Q6tW42r4YGxsexExJ2 iTME+2wTolnTHaU/llnDM+kAD4mL+GWENjV6n5NMR4JneTq6Lh9ffUnlCvtB2UEd6cOn qHPHaWOTMSaRVOLcFjLVIlTuBtvOA3j1FBsGCWZRFnOHXVV8vCWC4etPRXYlHOuXsLSY B1K+ChprLASmKYoeXYchJQ5irsKPfqiNavHsnDWhm56LGGUMf42ZEUpLhEtbO02Q9p2Y UWTiXMjjgsU/iA8Ge7hZO9YnDh3EsNlIQpWLrjE0R48DYk2YFJ9dXKvZIys5GyAar1h6 YiKQ== X-Gm-Message-State: AOJu0YyknLIdnASDR1J+taYTLBz+WWglOzdIDBwSKCuR06NTfjS36JG8 UZOd6ckgPp9EqSl6+GnQ27t2Wx255AMFmVNB4yguG7YfpqkyDkUZNJ+Na4hUraY= X-Google-Smtp-Source: AGHT+IFy8MEV29rnfRqwwS00oeLCYh3i9QvIQGcne34D8R1y7XIjFeMaRPcVJ+Uk6bvcBHB3WtW6wg== X-Received: by 2002:ad4:4448:0:b0:6b5:f75:4a0c with SMTP id 6a1803df08f44-6b540cf70ccmr167861726d6.64.1719591602366; Fri, 28 Jun 2024 09:20:02 -0700 (PDT) Received: from dean-laptop.iol.unh.edu ([2606:4100:3880:1271:f9bd:24da:464d:6294]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b59e5642fesm9075246d6.40.2024.06.28.09.20.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 09:20:01 -0700 (PDT) From: Dean Marx To: Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, jspewock@iol.unh.edu, bruce.richardson@intel.com, luca.vizzarro@arm.com Cc: dev@dpdk.org, Dean Marx Subject: [PATCH v4 1/3] dts: add functions to testpmd shell Date: Fri, 28 Jun 2024 12:19:28 -0400 Message-ID: <20240628161930.15915-1-dmarx@iol.unh.edu> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240617194638.12926-2-dmarx@iol.unh.edu> References: <20240617194638.12926-2-dmarx@iol.unh.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org added set promisc, set verbose, and port stop commands to testpmd shell. Signed-off-by: Dean Marx --- dts/framework/remote_session/testpmd_shell.py | 124 ++++++++++++++++++ 1 file changed, 124 insertions(+) diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py index ec22f72221..56e0ef13fe 100644 --- a/dts/framework/remote_session/testpmd_shell.py +++ b/dts/framework/remote_session/testpmd_shell.py @@ -806,6 +806,130 @@ def show_port_stats(self, port_id: int) -> TestPmdPortStats: return TestPmdPortStats.parse(output) + def stop_port_queue( + self, port_id: int, queue_id: int, is_rx_queue: bool, verify: bool = True + ) -> None: + """Stops a given queue on a port. + + Args: + port_id: ID of the port that the queue belongs to. + queue_id: ID of the queue to stop. + is_rx_queue: Type of queue to stop. If :data:`True` an RX queue will be stopped, + otherwise a TX queue will be stopped. + verify: If :data:`True` an additional command will be sent to verify the queue stopped. + Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the queue fails + to stop. + """ + port_type = "rxq" if is_rx_queue else "txq" + stop_cmd_output = self.send_command(f"port {port_id} {port_type} {queue_id} stop") + if verify: + if ( + # Rx/Tx queue state: ... + f"{port_type.capitalize()[:-1]} queue state: stopped" + not in self.send_command(f"show {port_type} info {port_id} {queue_id}") + ): + self._logger.debug( + f"Failed to stop {port_type} {queue_id} on port {port_id}:\n{stop_cmd_output}" + ) + raise InteractiveCommandExecutionError( + f"Test pmd failed to stop {port_type} {queue_id} on port {port_id}" + ) + + def start_port_queue( + self, port_id: int, queue_id: int, is_rx_queue: bool, verify: bool = True + ) -> None: + """Starts a given RX queue on a port. + + Args: + port_id: ID of the port that the queue belongs to. + queue_id: ID of the queue to start. + is_rx_queue: Type of queue to start. If :data:`True` an RX queue will be started, + otherwise a TX queue will be started. + verify: if :data:`True` an additional command will be sent to verify that the queue was + started. Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and the queue fails to + start. + """ + port_type = "rxq" if is_rx_queue else "txq" + self.setup_port_queue(port_id, queue_id, port_type) + start_cmd_output = self.send_command(f"port {port_id} {port_type} {queue_id} start") + if verify: + if ( + # Rx/Tx queue state: ... + f"{port_type.capitalize()[:-1]} queue state: started" + not in self.send_command(f"show {port_type} info {port_id} {queue_id}") + ): + self._logger.debug( + f"Failed to start {port_type} {queue_id} on port {port_id}:\n{start_cmd_output}" + ) + raise InteractiveCommandExecutionError( + f"Test pmd failed to start {port_type} {queue_id} on port {port_id}" + ) + + def setup_port_queue(self, port_id: int, queue_id: int, is_rx_queue: bool) -> None: + """Setup a given queue on a port. + + This functionality cannot be verified because the setup action only takes effect when the + queue is started. + + Args: + port_id: ID of the port where the queue resides. + queue_id: ID of the queue to setup. + is_rx_queue: Type of queue to setup. If :data:`True` an RX queue will be setup, + otherwise a TX queue will be setup. + """ + self.send_command(f"port {port_id} {'rxq' if is_rx_queue else 'txq'} {queue_id} setup") + + def set_promisc(self, port: int, on: bool, verify: bool = True): + """Turns promiscuous mode on/off for the specified port + + Args: + port: Port number to use, should be within 0-32. + on: If :data:`True`, turn promisc mode on, otherwise turn off. + verify: If :data:`True` an additional command will be sent to verify that promisc mode + is properly set. Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and promisc mode + is not correctly set. + """ + promisc_output = self.send_command(f"set promisc {port} {'on' if on else 'off'}") + if verify: + stats = self.show_port_info(port_id=port) + if on ^ stats.is_promiscuous_mode_enabled: + self._logger.debug(f"Failed to set promisc mode on port {port}: \n{promisc_output}") + raise InteractiveCommandExecutionError( + f"Testpmd failed to set promisc mode on port {port}." + ) + + def set_verbose(self, level: int, verify: bool = True): + """Set debug verbosity level. + + Args: + level: 0 - silent except for error + 1 - fully verbose except for Tx packets + 2 - fully verbose except for Rx packets + >2 - fully verbose + verify: if :data:`True` an additional command will be sent to verify that verbose level + is properly set. Defaults to :data:`True`. + + Raises: + InteractiveCommandExecutionError: If `verify` is :data:`True` and verbose level + is not correctly set. + """ + verbose_output = self.send_command(f"set verbose {level}") + if verify: + if "Change verbose level" not in verbose_output: + self._logger.debug(f"Failed to set verbose level to {level}: \n{verbose_output}") + raise InteractiveCommandExecutionError( + f"Testpmd failed to set verbose level to {level}." + ) + def close(self) -> None: """Overrides :meth:`~.interactive_shell.close`.""" self.send_command("quit", "") -- 2.44.0