From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3A6A4553E; Sun, 30 Jun 2024 17:40:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7496940EE7; Sun, 30 Jun 2024 17:40:45 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 4A887402C9 for ; Sun, 30 Jun 2024 17:40:44 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-706683e5249so1256258b3a.2 for ; Sun, 30 Jun 2024 08:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1719762043; x=1720366843; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=e0Ghi9VwzZubZHBEjbjzAue3669qegYQ2lkxU8l2xFM=; b=Mh3ybUTV3AFWHF4iJ/0B7IxvcGTlaHdKE0WM6wN40fgyMorxDwCuyrOJ4jUNtOo68u YFj33r8ccR5XWAM1TZ5IUkzsBgrhbPulcjgBRoyYfqxYo7uEgs48XTwLu1hcZ0jSCBZX zL15DgaoW75isjMR0f8zUwVj4NIGi3H3+JP8yL9YCfbxptLDsnve+LB/aLUGP60Danc0 wV9EL4rrDORYx2CdUXeFXLvRIyiJqxaDfORTBtkaPeSKerBl/vewjer8qSYTUxuXUnTA KaSNjwdf09oJFgfbCdVQsXHJoiX7tax/doTxXiFL8D4qdIAtbRvIkvxVG5sKoIuIFlrN ymzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719762043; x=1720366843; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e0Ghi9VwzZubZHBEjbjzAue3669qegYQ2lkxU8l2xFM=; b=A/OtgS3IkOz7ftxCkF82mge1rGaOlNg2Z8FB24CrFUXT+pT54qxGb3zuiflUMoIcqQ ySA3cKdAi2aygaMtFDt2VEbnZv81hVNEBtGAo08dE7zvuKqOBAUC0kdLWxJLVEBZJx7/ gHuQlE4qeFQZHquDvNG2NesYgdvHofm28m4ekZA1gygZnyJDczv70ToeumnY2+Fn23Jw UtVpE5E7Xg9dUvIME+BPFIXKdXuE25uGqjbJI9oh39GSjHQxLXWr4EpNexEg1KKyEAMJ vRQPFLU38MCynbbuHke5tOMcDdFsdoZ5hI0xVNE6xsz4POKWVQ7fgkpkyoJqaQfZhHhp 5omQ== X-Forwarded-Encrypted: i=1; AJvYcCX1D40lQn5VoUYnINaLy7Z5cYQCBLOdcrpIQ9L+7X1fHCN3carG5wH1X6OoX0SKpX5NOqLgo7QUDNt2Pcc= X-Gm-Message-State: AOJu0YzynjxJSZUZKkB7wC9eSa/y/SiOm1YrkruajB8f0CKN5oPIhs9f A/oQKQy6oDCNVuGeCpqvVjtQ1AextKM5QNjRR3lGzwFUrK7HPLI2xNMBJ9FZZL4= X-Google-Smtp-Source: AGHT+IGjMQF8H/Es2gtP+uRUY1s9q74QA40Ki0XoBxGJgyoJTVkKmAZIkjTgW9nX2tQUaukCvqm01A== X-Received: by 2002:a05:6a20:7285:b0:1be:e0ed:6b49 with SMTP id adf61e73a8af0-1bef60f3d38mr2678846637.3.1719762043286; Sun, 30 Jun 2024 08:40:43 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac15991d1sm47505975ad.269.2024.06.30.08.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 08:40:42 -0700 (PDT) Date: Sun, 30 Jun 2024 08:40:41 -0700 From: Stephen Hemminger To: Alexander Skorichenko Cc: samandrew@microsoft.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, longli@microsoft.com, weh@microsoft.com, dev@dpdk.org Subject: Re: [PATCH] net/netvsc: fix mtu_set in netvsc devices Message-ID: <20240630084041.44e86a57@hermes.local> In-Reply-To: <20240628163503.15893-1-askorichenko@netgate.com> References: <20240628163503.15893-1-askorichenko@netgate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 28 Jun 2024 18:35:03 +0200 Alexander Skorichenko wrote: > Prevent segfault in hn_reinit() caused by changing the MTU for > an incompletely initialized device. > > Signed-off-by: Alexander Skorichenko How do you get in that state? Maybe the init code should set up these pointers and avoid the problem.