From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 180DB4552E; Mon, 1 Jul 2024 12:00:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7A79427AB; Mon, 1 Jul 2024 12:00:22 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id 4C6354025D for ; Mon, 1 Jul 2024 12:00:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719828020; x=1751364020; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MwMAm3NjDtPFPyPn9HTyYFCLkMfINGC7WZZbjwKARsw=; b=FYN5RaxcTjlV20k1lvIzpyIWS6+r+6I+cGgdg4RVl4tFLpQlocreoTNy hSZedyDbFvs699vxpuEXWKfjgxbuWmkT87ZsNuPRGOLJ4gotwLpZr+qNw 0e/mq/0J4DBH9A1vLQ3dx4FHZNlbKoMyq1wL4Mg0TVNlmzSq6vh36Uoxl ij5QCBW2jNorPmyzidw/moLwN74LCV3H0jXirRzwK2jQRKFMvQ5iVoQmD idGESTg+IaKqi0yyYZilhsuTQPdH7cVdqSMkCPX9VfLnkLugBnU545TEy Y+BPSUaM+z2uR/3oDcvRQilmwem7xYkJAux19VVdXrowlB2r/6s4Jh9LF Q==; X-CSE-ConnectionGUID: MG7OVAn/R+m2fx+IcbaMaA== X-CSE-MsgGUID: +0kShtnhTMqB3b6uOn0KXg== X-IronPort-AV: E=McAfee;i="6700,10204,11119"; a="42364152" X-IronPort-AV: E=Sophos;i="6.09,175,1716274800"; d="scan'208";a="42364152" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2024 03:00:20 -0700 X-CSE-ConnectionGUID: NBVcQn9STAun9bqZBuJEdQ== X-CSE-MsgGUID: kgMXxZL1RhGZJaYCytMFlA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,175,1716274800"; d="scan'208";a="45452940" Received: from unknown (HELO npf-hyd-clx-03..) ([10.145.170.182]) by fmviesa008.fm.intel.com with ESMTP; 01 Jul 2024 03:00:18 -0700 From: Soumyadeep Hore To: bruce.richardson@intel.com, anatoly.burakov@intel.com Cc: dev@dpdk.org Subject: [PATCH v6 1/7] common/idpf: add wmb before tail Date: Mon, 1 Jul 2024 09:13:45 +0000 Message-ID: <20240701091351.2550283-2-soumyadeep.hore@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240701091351.2550283-1-soumyadeep.hore@intel.com> References: <20240624091644.2404658-16-soumyadeep.hore@intel.com> <20240701091351.2550283-1-soumyadeep.hore@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Adds the memory barrier properly before posting ctlq tail. This makes sure memory writes have a chance to take place before HW starts messing with the descriptors. Signed-off-by: Soumyadeep Hore --- drivers/common/idpf/base/idpf_controlq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c index 65e5599614..4f47759a4f 100644 --- a/drivers/common/idpf/base/idpf_controlq.c +++ b/drivers/common/idpf/base/idpf_controlq.c @@ -604,6 +604,8 @@ int idpf_ctlq_post_rx_buffs(struct idpf_hw *hw, struct idpf_ctlq_info *cq, /* Wrap to end of end ring since current ntp is 0 */ cq->next_to_post = cq->ring_size - 1; + idpf_wmb(); + wr32(hw, cq->reg.tail, cq->next_to_post); } -- 2.43.0