From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D13DC45538; Mon, 1 Jul 2024 19:51:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3ED84014F; Mon, 1 Jul 2024 19:51:16 +0200 (CEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id A4FAB400EF for ; Mon, 1 Jul 2024 19:51:15 +0200 (CEST) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-718b714d362so1639857a12.0 for ; Mon, 01 Jul 2024 10:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1719856275; x=1720461075; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9XeMRUkgNnXPIrtdY49MnpVhdL9iV6ekuOTKdswBiq4=; b=sYBpMVb/Iu2PMfzcddY6tnyktSv8nWPe9VqrNpM6grinIUW4HIONUBBNOLzbpNGq8I KGpczQbVrmHypyGHXi5tp/EAIVhDAIGhyOMarmUDqqei5DGxQqFM+gya6qAxLGxH7Fep mU8OCe7GHf3BjQfk+X2bW6/8bdOAZCZSKokJRJAx12h2lo7A7HYW1CHC6XE6QOdiOlIb qiX5Qk4Kjfdc7ZNKURxwart/xp5q0vtsLQnj03V/uMptTWVpN6fOfw4imts/DVBSC827 ERTIBnZ4qIxHH8AMVawvnlJ5RXkcFweL5akONoYZlgAUhxA0Hcz3QjLePnidbdXpk4wf f0Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719856275; x=1720461075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9XeMRUkgNnXPIrtdY49MnpVhdL9iV6ekuOTKdswBiq4=; b=TKWUTS7XA64TiqyqM5hcqA88lsjsdMqZBubkXp/wLUR7YbK0DmRLFwKQoqupMKSV7q vRyr4fhQPm/Z3V6vRvP2z9CKpDMPwrbVxcGKQ1qc4UURao9hMtweZxbnpnjMtSp5qkh3 spZK4x6gH3L6amIjwNl2Q1rk5GkctPdT4WDx+LcRaEXLVaoeDxKWrkKVlyRsnOdAH7Ai HSXJYdmUcWSDKj0P5/FWlF2LDhlChs0f2VioiPWDNKOxBwE1mKn0lmtEARtfTVXEjwTY ZAm0pIo2ibIsljs7GflH8NlG2f2lHuHOm6BI7PFugPOJSktOs4VsimG4Q4moqXWNpd/a K79w== X-Gm-Message-State: AOJu0YzcYjbFl3d7oUK7JFj2ZC4iAtTKqVuxmX4RfmHorGbzNRIB+huT 6r1muQJQVfg4eKgPw/MFGP3fZkbFQIPdK014eRhX+/JQ6vW8zoZ7yy1nn1i0IIk= X-Google-Smtp-Source: AGHT+IFcev1uvb7FrdR6o7Wq4HS0uI4puSSrYnBly6IotuDYK+Lc3qYZvSEnKJUaTA6LJOxowdS9Tw== X-Received: by 2002:a17:90b:1010:b0:2c8:716f:b485 with SMTP id 98e67ed59e1d1-2c93d727ab1mr3039467a91.24.1719856274665; Mon, 01 Jul 2024 10:51:14 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c91ce5490esm7173872a91.24.2024.07.01.10.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 10:51:14 -0700 (PDT) Date: Mon, 1 Jul 2024 10:51:12 -0700 From: Stephen Hemminger To: Fidaullah Noonari Cc: dev@dpdk.org Subject: Re: [PATCH v4] usertools: add check for IOMMU support in dpdk-devbind Message-ID: <20240701105112.6b2cde71@hermes.local> In-Reply-To: <20221012123817.112225-1-fidaullah.noonari@emumba.com> References: <20220321122727.614290-1-fidaullah.noonari@emumba.com> <20221012123817.112225-1-fidaullah.noonari@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 12 Oct 2022 17:38:17 +0500 Fidaullah Noonari wrote: > binding with vfio driver, when IOMMU is disabled, causes program to crash. > this patch adds a flag for noiommmu-mode. when this is set, if IOMMU is > disabled, it changes vfio into unsafe noiommu mode and prints warning > message. > > Signed-off-by: Fidaullah Noonari Not sure why this patch got stuck. The flake8 tool reports: usertools/dpdk-devbind.py:489:27: E231 missing whitespace after ',' Fix by: diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index e7a5665fa2..a089313db1 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -486,7 +486,7 @@ def check_noiommu_mode(): filename = "/sys/module/vfio/parameters/enable_unsafe_noiommu_mode" try: - with open(filename,"r") as f: + with open(filename, "r") as f: if f.read(1) == "1": return except OSError as err: