From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A909145551; Tue, 2 Jul 2024 22:15:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 933BD40665; Tue, 2 Jul 2024 22:15:19 +0200 (CEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id DC393402D8 for ; Tue, 2 Jul 2024 22:15:17 +0200 (CEST) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2c8911c84daso3212986a91.3 for ; Tue, 02 Jul 2024 13:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719951317; x=1720556117; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YW4Jz6g7QJg9PLdhgHXWxbujfiDW31KCv0D0Q73w7ec=; b=WkXbSnDIHmaMA/sw5HGaESz9uaLW08ivrFCTlMVqNdG75w68Evtmg7YERhl3q/R0a2 Y1WJPsewPTlKE7eDAf8kCo3nuLh5Ug+zwNNZdR5JYNG4tT5nEH5Pe4t8KrZiwr23lKuc otF+wNrK7lkt3ZJPi4QRnfWeLlNcoY2vOGSDvn13HbWeVCwNwkGYgGgKjiab6KMiniJL cUeDYeaYwTl1VYTLXC8uDLHiO4tRaXyndQQqXHZWORugBcPBQS2wq/izkoix+5fc3Dg7 JRaK28CSx3U8v+h9hbEPcZQHoWlbyJ3HgK1OPDRLhutUipgPLA621jJfv72TEiBykdot xKFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719951317; x=1720556117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YW4Jz6g7QJg9PLdhgHXWxbujfiDW31KCv0D0Q73w7ec=; b=JXW/cZlqGuPN5h/9Qa9WBTBwfWHJQWlZBj9sDqKQ6Bap00DOWxrJXH5CTE5B1AiqvH GZUeSzoyZojDM9nCZJQUVUcAa0BZqCOadxtcsY8JBlFX81t0QihJcijEjI/PdsRFt757 i9XfHsigdlvgylKxkMtsQQLJu0yAChgSlWEdPRR9YXMESnviyhxyz40ed53gpzvQLMxB SSCrMfuKXvQraLBMyXmjdT5oHce7CTLmlXyKw3Ao7h2XooMNRP7nkQp/YxXm5KYSM4/d qFhknppnXxGh9DDgUMS114BOFmuGo2+14ITmJF81vzbtMxSETVjzzevQRbz9QVCKkKyw /YBw== X-Gm-Message-State: AOJu0YyIMiIyA0rHh1EPmzAR9F9nN5FKAUMe0/hzbCL/XNy1zqQh/de3 Jo5aM9+YZlj7vaTLnHP0HzO/mL2pKZHz0xo4rLNXdpfCW17OZdes X-Google-Smtp-Source: AGHT+IEbjUSez1xjMfu0KRbX6teFvH/W7K5XexO/mbk9DkW+GNyKSoWGIsYNzZLp84NoZ3wjjuVfQw== X-Received: by 2002:a17:90a:ff0d:b0:2c7:c700:d0cb with SMTP id 98e67ed59e1d1-2c93d6dffa6mr7225161a91.4.1719951316569; Tue, 02 Jul 2024 13:15:16 -0700 (PDT) Received: from localhost.localdomain.xyz (bba-2-50-154-164.alshamil.net.ae. [2.50.154.164]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac159ac64sm88179275ad.295.2024.07.02.13.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 13:15:16 -0700 (PDT) From: Mahmoud Maatuq To: Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani Cc: dev@dpdk.org, Mahmoud Maatuq Subject: [PATCH v3] net/mlx5: fix matcher object memory leak Date: Wed, 3 Jul 2024 00:14:50 +0400 Message-ID: <20240702201450.349991-1-mahmoudmatook.mm@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> References: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This makes sure that the allocated matcher object is freed for all branches that return NULL. Coverity issue: 426424 Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable reconfigure") Cc: mkashani@nvidia.com Signed-off-by: Mahmoud Maatuq --- v3: * changed commit message. * fixed typos v2: * fixed Fixes and Cc tags. --- drivers/net/mlx5/mlx5_flow_dv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index d46beffd4c..8a0d58cb05 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -12010,9 +12010,12 @@ flow_matcher_create_cb(void *tool_ctx, void *cb_ctx) items = *((const struct rte_flow_item **)(ctx->data2)); resource->matcher_object = mlx5dr_bwc_matcher_create (resource->group->tbl, resource->priority, items); - if (!(resource->matcher_object)) + if (!resource->matcher_object) { + mlx5_free(resource); return NULL; + } #else + mlx5_free(resource); return NULL; #endif } -- 2.43.0