DPDK patches and discussions
 help / color / mirror / Atom feed
From: vanshika.shukla@nxp.com
To: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@nxp.com>,
	Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: stable@dpdk.org, Rohit Raj <rohit.raj@nxp.com>,
	Vanshika Shukla <vanshika.shukla@nxp.com>
Subject: [PATCH 5/8] bus/dpaa: remove redundant file descriptor check
Date: Wed,  3 Jul 2024 16:46:41 +0530	[thread overview]
Message-ID: <20240703111644.1523242-6-vanshika.shukla@nxp.com> (raw)
In-Reply-To: <20240703111644.1523242-1-vanshika.shukla@nxp.com>

From: Rohit Raj <rohit.raj@nxp.com>

This patch removes the redundant file descriptor check

Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table")
Cc: stable@dpdk.org

Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com>
---
 drivers/bus/dpaa/base/qbman/process.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/dpaa/base/qbman/process.c b/drivers/bus/dpaa/base/qbman/process.c
index 3504ec97db..3e4622f606 100644
--- a/drivers/bus/dpaa/base/qbman/process.c
+++ b/drivers/bus/dpaa/base/qbman/process.c
@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0)
  *
  * Copyright 2011-2016 Freescale Semiconductor Inc.
- * Copyright 2017,2020 NXP
+ * Copyright 2017,2020,2022,2024 NXP
  *
  */
 #include <assert.h>
@@ -27,15 +27,16 @@ static int check_fd(void)
 {
 	int ret;
 
-	if (fd >= 0)
-		return 0;
 	ret = pthread_mutex_lock(&fd_init_lock);
 	assert(!ret);
+
 	/* check again with the lock held */
 	if (fd < 0)
 		fd = open(PROCESS_PATH, O_RDWR);
+
 	ret = pthread_mutex_unlock(&fd_init_lock);
 	assert(!ret);
+
 	return (fd >= 0) ? 0 : -ENODEV;
 }
 
-- 
2.25.1


  parent reply	other threads:[~2024-07-03 11:17 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 11:16 [PATCH 0/8] DPAA specific fixes vanshika.shukla
2024-07-03 11:16 ` [PATCH 1/8] bus/dpaa: fix bus scan for DMA devices vanshika.shukla
2024-07-03 11:16 ` [PATCH 2/8] bus/dpaa: fix resource leak in variable dev vanshika.shukla
2024-07-03 11:16 ` [PATCH 3/8] common/dpaax: fix IOVA table cleanup vanshika.shukla
2024-07-03 11:16 ` [PATCH 4/8] common/dpaax: fix array overrun issue vanshika.shukla
2024-07-03 11:16 ` vanshika.shukla [this message]
2024-07-03 11:16 ` [PATCH 6/8] bus/dpaa: remove unused code vanshika.shukla
2024-07-03 11:16 ` [PATCH 7/8] net/dpaa: restrict MTU config for shared intf vanshika.shukla
2024-07-03 11:16 ` [PATCH 8/8] mempool/dpaax: cache free optimization vanshika.shukla
2024-07-05  7:42 ` [v2 0/7] DPAA specific fixes vanshika.shukla
2024-07-05  7:42   ` [v2 1/7] bus/dpaa: fix bus scan for DMA devices vanshika.shukla
2024-07-08  7:29     ` [v3 0/8] DPAA specific fixes vanshika.shukla
2024-07-08  7:29       ` [PATCH v3 1/8] bus/dpaa: fix bus scan for DMA devices vanshika.shukla
2024-07-08  7:29       ` [PATCH v3 2/8] bus/dpaa: fix resource leak in variable dev vanshika.shukla
2024-07-08 13:28         ` David Marchand
2024-07-08  7:29       ` [PATCH v3 3/8] common/dpaax: fix IOVA table cleanup vanshika.shukla
2024-07-08  7:29       ` [PATCH v3 4/8] common/dpaax: fix array overrun issue vanshika.shukla
2024-07-08  7:29       ` [PATCH v3 5/8] bus/dpaa: remove redundant file descriptor check vanshika.shukla
2024-07-08  7:29       ` [PATCH v3 6/8] bus/dpaa: remove unused code vanshika.shukla
2024-07-08  7:29       ` [PATCH v3 7/8] net/dpaa: restrict MTU config for shared intf vanshika.shukla
2024-07-09  8:47         ` David Marchand
2024-07-08  7:29       ` [PATCH v3 8/8] mempool/dpaax: cache free optimization vanshika.shukla
2024-07-08 13:28         ` David Marchand
2024-07-09 10:04       ` [v4 0/8] DPAA specific fixes vanshika.shukla
2024-07-09 10:04         ` [v4 1/8] bus/dpaa: fix bus scan for DMA devices vanshika.shukla
2024-07-09 10:04         ` [v4 2/8] bus/dpaa: fix resource leak in variable dev vanshika.shukla
2024-07-09 10:05         ` [v4 3/8] common/dpaax: fix IOVA table cleanup vanshika.shukla
2024-07-09 10:05         ` [v4 4/8] common/dpaax: fix array overrun issue vanshika.shukla
2024-07-09 10:05         ` [v4 5/8] bus/dpaa: remove redundant file descriptor check vanshika.shukla
2024-07-09 10:05         ` [v4 6/8] bus/dpaa: remove unused code vanshika.shukla
2024-07-09 10:05         ` [v4 7/8] net/dpaa: restrict MTU config for shared intf vanshika.shukla
2024-07-09 10:05         ` [v4 8/8] mempool/dpaax: cache free optimization vanshika.shukla
2024-07-09 12:05         ` [v4 0/8] DPAA specific fixes David Marchand
2024-07-10  8:55         ` [v5 " vanshika.shukla
2024-07-10  8:55           ` [v5 1/8] bus/dpaa: fix bus scan for DMA devices vanshika.shukla
2024-07-10  8:55           ` [v5 2/8] bus/dpaa: fix resource leak in variable dev vanshika.shukla
2024-07-10  8:55           ` [v5 3/8] common/dpaax: fix IOVA table cleanup vanshika.shukla
2024-07-10  8:55           ` [v5 4/8] common/dpaax: fix array overrun issue vanshika.shukla
2024-07-10  8:55           ` [v5 5/8] bus/dpaa: remove redundant file descriptor check vanshika.shukla
2024-07-10  8:55           ` [v5 6/8] bus/dpaa: remove unused code vanshika.shukla
2024-07-10  8:55           ` [v5 7/8] net/dpaa: restrict MTU config for shared intf vanshika.shukla
2024-07-10  8:55           ` [v5 8/8] mempool/dpaax: cache free optimization vanshika.shukla
2024-07-11 15:41           ` [v5 0/8] DPAA specific fixes David Marchand
2024-07-05  7:42   ` [v2 2/7] bus/dpaa: fix resource leak in variable dev vanshika.shukla
2024-07-05  7:42   ` [v2 3/7] common/dpaax: fix IOVA table cleanup vanshika.shukla
2024-07-05  7:42   ` [v2 4/7] common/dpaax: fix array overrun issue vanshika.shukla
2024-07-05  7:42   ` [v2 5/7] bus/dpaa: remove redundant file descriptor check vanshika.shukla
2024-07-05  7:42   ` [v2 6/7] bus/dpaa: remove unused code vanshika.shukla
2024-07-05  7:42   ` [v2 7/7] net/dpaa: restrict MTU config for shared intf vanshika.shukla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240703111644.1523242-6-vanshika.shukla@nxp.com \
    --to=vanshika.shukla@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=rohit.raj@nxp.com \
    --cc=sachin.saxena@nxp.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).