DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: [PATCH] eal: make dev_sigbus static
Date: Wed,  3 Jul 2024 08:17:34 -0700	[thread overview]
Message-ID: <20240703151734.14458-1-stephen@networkplumber.org> (raw)

Only used in one file, and not an exported symbol should be static.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/eal/common/eal_private.h | 22 ----------------------
 lib/eal/linux/eal_dev.c      |  4 ++--
 2 files changed, 2 insertions(+), 24 deletions(-)

diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
index 71523cfdb8..e63ecd74f8 100644
--- a/lib/eal/common/eal_private.h
+++ b/lib/eal/common/eal_private.h
@@ -529,28 +529,6 @@ int local_dev_remove(struct rte_device *dev);
  */
 int rte_bus_sigbus_handler(const void *failure_addr);
 
-/**
- * @internal
- * Register the sigbus handler.
- *
- * @return
- *   - On success, zero.
- *   - On failure, a negative value.
- */
-int
-dev_sigbus_handler_register(void);
-
-/**
- * @internal
- * Unregister the sigbus handler.
- *
- * @return
- *   - On success, zero.
- *   - On failure, a negative value.
- */
-int
-dev_sigbus_handler_unregister(void);
-
 /**
  * Get OS-specific EAL mapping base address.
  */
diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
index fff4e8fa83..e63f24d108 100644
--- a/lib/eal/linux/eal_dev.c
+++ b/lib/eal/linux/eal_dev.c
@@ -393,7 +393,7 @@ rte_dev_event_monitor_stop(void)
 	return ret;
 }
 
-int
+static int
 dev_sigbus_handler_register(void)
 {
 	sigset_t mask;
@@ -414,7 +414,7 @@ dev_sigbus_handler_register(void)
 	return rte_errno;
 }
 
-int
+static int
 dev_sigbus_handler_unregister(void)
 {
 	rte_errno = 0;
-- 
2.43.0


             reply	other threads:[~2024-07-03 15:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 15:17 Stephen Hemminger [this message]
2024-07-05 14:08 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240703151734.14458-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).