Hi David,

I have made some changes as suggested. Is there anything else that needs to be changed?

Thanks

Original



From: DavidMarchand <david.marchand@redhat.com>
To: 张勇10313449;
Cc: dev@dpdk.org <dev@dpdk.org>;
Date: 2024年06月12日 19:28
Subject: Re: raw/zxdh: introduce zxdh raw device driver

Hello,
 
On Wed, Jun 12, 2024 at 1:01 PM <zhang.yong25@zte.com.cn> wrote:
> From 7da90caa892abc0ab27fc11e892f6616f4bc8c9a Mon Sep 17 00:00:00 2001
> From: Yong Zhang <zhang.yong25@zte.com.cn> 
> Date: Wed, 12 Jun 2024 17:35:34 +0800
> Subject: [PATCH] raw/zxdh: introduce zxdh raw device driver
> 
> Introduce rawdev driver support for ZXDH which
> can help to connect two separate hosts with each other.
> 
> Signed-off-by: Yong Zhang <zhang.yong25@zte.com.cn> 
 
Please check your mail settings, this patch was received base64 encoded.
It confuses a lot of our tools in the CI.
 
 
On the patch itself, I had a (really) quick look.
 
I see checks on DPDK version, please remove compat code, it does not
make sense in the main repository.
This looks to be a PCI driver, please convert this driver and do not
expose a vdev.
Please use RTE_LOG_LINE() / RTE_LOG_LINE_PREFIX() instead of direct
call to rte_log.
 
 
--  
David Marchand