From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77FC245680; Mon, 22 Jul 2024 22:19:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6354A402BE; Mon, 22 Jul 2024 22:19:17 +0200 (CEST) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by mails.dpdk.org (Postfix) with ESMTP id 2D9204028B for <dev@dpdk.org>; Mon, 22 Jul 2024 22:19:16 +0200 (CEST) Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5c661e75ff6so2220351eaf.2 for <dev@dpdk.org>; Mon, 22 Jul 2024 13:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1721679555; x=1722284355; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DuXSq/xTQ8LLixkB1DUdgQoKJML8oDZNfokWR8xhwmk=; b=wItb0Z3hZD0cRN5mxQcyyST0lXTcHxfv37QpvNAW+KMqTkXXogLbbJj5izMItUFbCw sE2ECqJfEmuHxjQMlPqfR8JRXJywTQrO0v7VBjTzPkj2QVFoB8av9myOsfoHZ3oTEBUt tlIDsynX0DvjuQ4xS5Rjs6Wl1p10HYWJpONaZVQhdAqIPr0wYh6v9lobTWk/LRDAeHFh QHsHZF9RUEv88IO6uFMKCXTh2z+NccVtz8B9d8wUjff1e1MTLjkgX9LMzCoikjtrtlSy byGcKpT+qW3QXE7NE1/dm96C/apeeLr2nmYmBxeq6SSzIqC9eChvuDzIjgUvs0cm3n5I NZfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721679555; x=1722284355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DuXSq/xTQ8LLixkB1DUdgQoKJML8oDZNfokWR8xhwmk=; b=GmA7JPpUNp8wQiao9CGZrocQ718F3+1sQnflZaJGSGlK01OYAfAaQYJVInH7jwYKom 6iMb6sGY0l9KF+I7von+UxSAkpH974FvBNpcmCQCQ7tAsahBHslXjeFrzFLpun1+2fj5 cPNrvn3VtRA6LTmMv/eu6mXbGk2yNbfSCnEde5K7RiMAm7E8icRO0faB1qN+gNoizXDz p8GAv9ImIWBrprw0v1aWWlaOOvbxh6iEFPs+dIkal4lMNMw3nSZ3RncoDeEe7C9m/8qL GRxI7NgoqbfDXLn6BbvgJr6n6Q4Ywerp4CDzkK4G3JNXM6knz8LUAAHt3VsEbAgEPIpY tYwg== X-Gm-Message-State: AOJu0YyIov6vf4cB0XHFPFWa1k3l3bnhEFp7qORkqw/XQ+8snUrUkLT8 PlO2pIs7KnqLtv05UqZwNoh6FUFPhtLaqAkOl/dWegHzOzeEMVy158re9msJKu0= X-Google-Smtp-Source: AGHT+IHWT4UcsN01c69p7mW+pd8QI8heML5NxNCs7Z0a5SjqUX7B9FlzLRYg/qxamRAbbjFAS75ETA== X-Received: by 2002:a05:6359:4129:b0:1a5:4b74:2214 with SMTP id e5c5f4694b2df-1acc5a78221mr1047254255d.3.1721679555285; Mon, 22 Jul 2024 13:19:15 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-79f0e5bd362sm5042942a12.57.2024.07.22.13.19.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 13:19:15 -0700 (PDT) Date: Mon, 22 Jul 2024 13:19:12 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Gagandeep Singh <g.singh@nxp.com> Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>, Jun Yang <jun.yang@nxp.com> Subject: Re: [v3 02/30] dma/dpaa2: support multiple HW queues Message-ID: <20240722131912.61a5e876@hermes.local> In-Reply-To: <20240722163930.2171568-3-g.singh@nxp.com> References: <20240722115843.1830105-1-g.singh@nxp.com> <20240722163930.2171568-1-g.singh@nxp.com> <20240722163930.2171568-3-g.singh@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 22 Jul 2024 22:09:02 +0530 Gagandeep Singh <g.singh@nxp.com> wrote: > index 5954b552b5..945ba71e4a 100644 > --- a/drivers/dma/dpaa2/dpaa2_qdma.c > +++ b/drivers/dma/dpaa2/dpaa2_qdma.c > @@ -478,9 +478,9 @@ dpdmai_dev_get_job_us(struct qdma_virt_queue *qdma_vq __rte_unused, > > static inline uint16_t > dpdmai_dev_get_single_job_lf(struct qdma_virt_queue *qdma_vq, > - const struct qbman_fd *fd, > - struct rte_dpaa2_qdma_job **job, > - uint16_t *nb_jobs) > + const struct qbman_fd *fd, > + struct rte_dpaa2_qdma_job **job, > + uint16_t *nb_jobs) Why are you changing this? The DPDK style is either to line up the args with the paren or use two tabs here. Changing indentation leads to lots of extra changes which makes it hard to review. Please, just leave the existing indentation alone or make it a separate patch.