From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B737456A2; Wed, 24 Jul 2024 16:38:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E15A43468; Wed, 24 Jul 2024 16:38:29 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id A21B040E3E for ; Wed, 24 Jul 2024 16:38:21 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1fc587361b6so10030425ad.2 for ; Wed, 24 Jul 2024 07:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1721831901; x=1722436701; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=XKPZN5lYp/rruU4vcxb/ud/abf5s8b/4H8v0t/ssJdA=; b=beG/j1c9Mj6Jw/mBSUYcSqlY/KPiD6AESlNnYSz1rkO+bmRhySuirbI+qpxjzRSz42 dys4jcbfmgYPv2WYR4m+FhuXJioln6Zwm3fUe1T1zp2TSAzcPOf7qq1vQMZ19zjQArMb QybDrq0bVtP1tEpxFkoblhQNNJvTlkoiLgfNk/7YuC9R2EhUos5w4L9leJk9jDUE4tWs bttSBUwbSwNtE7wpfv5vLGMIEOs2d5RsBGilCYYCzmqtfc+7of5PGs8k+5dOkTFDIR0P sCGMdTyFithz5ZwOmnjDaikPfGlBtsBbkBMYJ3EzIZ7uoePW280OMTXbs1GbYnMze4+U jGFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721831901; x=1722436701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XKPZN5lYp/rruU4vcxb/ud/abf5s8b/4H8v0t/ssJdA=; b=ulyCzTRQx0ilZgxiCvhbUQrzg2k8GkLlVn5aQAOWg/WANVINu+gl/y3eapVGvFFCnz zp7WGwuV6831MnWxUXHkGYPklOr+lUclOoR6m+SGR6kl7IrjqmiVD5slGviYKHEfyGQy p+X1W5odHwEDYth6HjyIO3pBipyAZtdoLrRsQeoNXkg7vqZov85duR1Gpn7/HpFBD+Nz SiPAOYmQmt50/KE5oCjTt8PgX0yYd1CLGuxJ2GAcOcwT3ghuhHpg9ZeZcqlVE7mDhuBM /dhHmp5YbOZUMuo7pEKkH0g3O/QS2+j3KkmFRixxEgBOPJr5VvtMCYnAxeNFBs/thbIS 8yEA== X-Forwarded-Encrypted: i=1; AJvYcCVSAQLAxHaARTAKVDE9PmXFthoq1AdEDX7cZ8JUuYPFVjBAKj81zWmoiw44nuB57C1MUYwVM3HX/1O/RDk= X-Gm-Message-State: AOJu0YwMpcH5qKl55GcsyuIYUCf/sN8GMaeQplERi9t29SKBFEvyOPSM fFemXfY2NpYYzlpQ3VZTszxSm4eZ3EdXnWb20/MLabkRR6GjaIxzuVGhGikkH1o= X-Google-Smtp-Source: AGHT+IHb4+ng73sDVOa5bqojpN6Zp0eH0gwnUwOULVt3z2UygyLMwe63ZYIxsVuMSmYK5fmCgY0Z5g== X-Received: by 2002:a17:902:e883:b0:1fb:1cc3:6482 with SMTP id d9443c01a7336-1fd7466b04dmr104478775ad.45.1721831900797; Wed, 24 Jul 2024 07:38:20 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f457954sm95384135ad.240.2024.07.24.07.38.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 07:38:20 -0700 (PDT) Date: Wed, 24 Jul 2024 07:38:18 -0700 From: Stephen Hemminger To: Sivaprasad Tummala Cc: , , , , , Subject: Re: [RFC PATCH 1/2] power: fix power library with --lcores Message-ID: <20240724073818.7c32899d@hermes.local> In-Reply-To: <20240724130336.1076462-1-sivaprasad.tummala@amd.com> References: <20240724130336.1076462-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 24 Jul 2024 13:03:35 +0000 Sivaprasad Tummala wrote: > + POWER_LOG(ERR, "Power library doesn't support lcore %u mapping " > + "to %u cpus", lcore_id, CPU_COUNT(&lcore_cpus)); Please don't break single format error string across lines. It makes it harder for users to find the error in the source. Instead wrap after Er,,