From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88A1F4576C; Thu, 8 Aug 2024 17:23:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 769FA42D28; Thu, 8 Aug 2024 17:23:49 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id E1418427D2 for ; Thu, 8 Aug 2024 17:23:47 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-710afd56c99so866937b3a.0 for ; Thu, 08 Aug 2024 08:23:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1723130627; x=1723735427; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YtZiUwC8kVJaGMqR/hU9El8iio34k2IyQnrYaqLZnTw=; b=lv+HynlwGxRDM25mWl9oFNBbPathvFP12/+iMXfg7Mz+OeLysyG8siM4iOgzE7NM1k b4qNN1zW+3cRQ1nDBr+ip/KQSHTgtF4hQqaHJxmxwBaCOjgdlo0s2YIsVjaTMkQGfc/0 2vVSpk4o+lHy6MM/8WLRJSTZx/JHTQFRkes8y6b/gIv37fPHbgIesxJIrmA5+uYp/WDc vpFgr8zl3uOXj3qIeJkef1X6uVBXv8cAWZulBKYTGyPFc2D1j9rFQEia8Bzh62s6E2Md daqJbG9Juxs3a+zRaenIZa1LDsAw4rUePPmUuVasSGYCWCyS8sr/2TLWh2j3dzlbEt8i iHKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723130627; x=1723735427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YtZiUwC8kVJaGMqR/hU9El8iio34k2IyQnrYaqLZnTw=; b=e+5J4iRxre94S+T/fJq0birCMIvUYzC0tzuL3EoBddGZqMoHhQOQpLelSMRBS3t8MQ IVAyVmvNCRdgCG4Gd1yPkl9JFG4u5Urb57CcOP19KbIGQi0fQSlWo7BX3sKVZ2Qm74Lr IfzNhiUQEXrh3umkY1fa9RPZpJnSf2O3GaZyNzMHmmmb5/m3+PxnhTWszmp7vyK2Mk24 KAhGZe3S2zmap1GVsKr0exhOJxuChWIcO9dN4OjGixCLIHkXU+te5KWFTf6LQWq8YDbt LF6WXcNQWx48Ic+S+TjX42seCog9KKJ5fXO6XrOGR5YJrh3V55kamgvfxL1xbtcfT0UD qE4g== X-Gm-Message-State: AOJu0Yzk9bg/6r8x2wtHJ1C8vdijUmZV8107QujavLWBskEwJd2SFB8p ocpWbUvsBG7jIcD9UMeZZyzihmvk9NNZkKFLECPWbADtLyycSWG2ZtVP0R/9maY= X-Google-Smtp-Source: AGHT+IF0vgy3MTgdd8fgzfVzCR7cydR3YLbJ7atTqdzCzCIVknIp3/d3bOd48Di/Y3ygdpQ30SDMzg== X-Received: by 2002:a05:6a00:66d7:b0:70e:ce95:b87 with SMTP id d2e1a72fcca58-710cc32a238mr4183708b3a.0.1723130626810; Thu, 08 Aug 2024 08:23:46 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710cb2f81b1sm1239079b3a.187.2024.08.08.08.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 08:23:46 -0700 (PDT) Date: Thu, 8 Aug 2024 08:23:45 -0700 From: Stephen Hemminger To: Hanxiao Li Cc: dev@dpdk.org Subject: Re: [PATCH 1/4] [v1,1/4] zsda: Introduce zsda device drivers Message-ID: <20240808082345.2d03dd73@hermes.local> In-Reply-To: <20240808085030.1685755-1-li.hanxiao@zte.com.cn> References: <20240808085030.1685755-1-li.hanxiao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 8 Aug 2024 16:50:11 +0800 Hanxiao Li wrote: > +static uint8_t > +zsda_crc8(uint8_t *message, int length) > +{ > + uint8_t crc = 0; > + int i; > + > + for (i = 0; i < length; i++) > + crc = crc8_table[crc ^ message[i]]; > + return crc; > +} The code in this driver could start using const many places to clarify what is input and what is result.