From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH 1/4] test: update alarm test
Date: Thu, 8 Aug 2024 11:52:23 -0700 [thread overview]
Message-ID: <20240808115223.6d5ac846@hermes.local> (raw)
In-Reply-To: <CAJFAV8zZeq3kzUNKxCr_7=qyMVjdk+_iShp1ObgRYbLKLXk78A@mail.gmail.com>
On Tue, 6 Aug 2024 14:45:45 +0200
David Marchand <david.marchand@redhat.com> wrote:
> On Thu, Jul 18, 2024 at 9:11 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > This test should be using the TEST_ASSERT macros, and can be
> > run as part of the fast test suite now.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> [...]
>
> > + ret = rte_eal_alarm_cancel(test_alarm_callback, NULL);
> > + /* return is the number of the alarm set (or 0 if none or -1 if error) */
> > + TEST_ASSERT(ret > 0, "could not cancel an alarm: %d", ret);
> >
> > return 0;
> > }
> >
> > -REGISTER_TEST_COMMAND(alarm_autotest, test_alarm);
> > +REGISTER_FAST_TEST(alarm_autotest, true, true, test_alarm);
>
> This test was removed from the fast-tests list as it was triggering
> false failures in some CI.
> ee00af60170b ("test: remove strict timing requirements some tests")
I can see why that test failed (too short an alarm), but the whole test has lots
of other issues. Starting new series to address.
next prev parent reply other threads:[~2024-08-08 18:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 19:07 [PATCH 0/4] Enable more unit tests Stephen Hemminger
2024-07-18 19:07 ` [PATCH 1/4] test: update alarm test Stephen Hemminger
2024-07-19 10:17 ` Bruce Richardson
2024-07-19 17:09 ` Stephen Hemminger
2024-08-06 12:45 ` David Marchand
2024-08-07 22:24 ` Stephen Hemminger
2024-08-08 18:52 ` Stephen Hemminger [this message]
2024-07-18 19:07 ` [PATCH 2/4] test: run cksum tests as part of perf test suite Stephen Hemminger
2024-07-19 8:45 ` Bruce Richardson
2024-07-18 19:07 ` [PATCH 3/4] test: make red test part of fast suite Stephen Hemminger
2024-07-19 9:14 ` Bruce Richardson
2024-08-06 12:28 ` David Marchand
2024-08-06 12:49 ` Bruce Richardson
2024-08-08 16:12 ` Stephen Hemminger
2024-10-04 12:17 ` David Marchand
2024-07-18 19:07 ` [PATCH 4/4] test: run timer secondary tests as " Stephen Hemminger
2024-07-19 9:27 ` Bruce Richardson
2024-10-04 12:20 ` David Marchand
2024-10-04 12:51 ` [PATCH 0/4] Enable more unit tests David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808115223.6d5ac846@hermes.local \
--to=stephen@networkplumber.org \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).