From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B5956457E5;
Fri, 16 Aug 2024 16:20:22 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 17FB542DF0;
Fri, 16 Aug 2024 16:20:18 +0200 (CEST)
Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com
[209.85.160.175])
by mails.dpdk.org (Postfix) with ESMTP id 56CA842DC5
for <dev@dpdk.org>; Fri, 16 Aug 2024 16:20:16 +0200 (CEST)
Received: by mail-qt1-f175.google.com with SMTP id
d75a77b69052e-44fded90c41so10061751cf.3
for <dev@dpdk.org>; Fri, 16 Aug 2024 07:20:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=iol.unh.edu; s=unh-iol; t=1723818016; x=1724422816; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=uISKbo2u9+QxhFcT57uOrThwW9sIgFM4v/D7ACRmG14=;
b=CoJ/bTWq87eCLM068Y2GYdKHaPXLxIEWZQvCMC0O+M34Djow8DWIUc2tZY1Ge0Q5m3
qxOprYgmk0xp9F7yqRiHLspvizNoaVJR65oXCAuG7zyB/dthQ8WJQ4geBpIykaT6OFEY
5hyLd/2BK8ksobGci0/kxYwzs3l2mAavngO5A=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1723818016; x=1724422816;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=uISKbo2u9+QxhFcT57uOrThwW9sIgFM4v/D7ACRmG14=;
b=w/PYUWmwJg9ENWaQq9tRN1HZxrONzkaee6frhO9G0GC/qf8S4gFkMOdbpCr9DTIgMo
jQxFz8GksRoWa9Lojgv/+CNXJIR4TfIBC70LXTi7uvOKbA2HKbBL3/JBjO3ex55AvlZv
ek92QyDFINBRDJG3t+ElQVXGdXpZ88zvyNUgnvygqsDXWeLjjj8rurkDyOTT3ek77tmC
U5v+JLsQ5c3m/b3WGOr+h2vfo5QuMRtvpTN5QvJsU4S46WFUpttOGAJbLpZIO85Wck9Y
Nmqy/J/uxcJXOA5DEBKQrK6nQEvQHS9tIindqocchecJoiroeWBJtGHZ12NLPX5Tq/TB
RbjA==
X-Gm-Message-State: AOJu0YwxP8QpkEyqMk5DLFv91UPYT/0bTOnlVufyQpU2txUEEgIDPxMC
gVcghDx0BRsWuYmrDYDVDVbBkPJLImyZu76v63gUMZV/6VO1AVeuNKJG30W34tw=
X-Google-Smtp-Source: AGHT+IGfLdgT92r2YMCBPAjn6LdpdnosYTAnE34SY+W9AmB381rWSW76K/61Z1VtnLYMrQqPxuYcrQ==
X-Received: by 2002:a05:622a:618a:b0:44f:5eb0:ea76 with SMTP id
d75a77b69052e-453743b6c90mr29796341cf.60.1723818015249;
Fri, 16 Aug 2024 07:20:15 -0700 (PDT)
Received: from dean-laptop.hsd1.nh.comcast.net ([2601:188:cd7e:6880::fcf1])
by smtp.gmail.com with ESMTPSA id
d75a77b69052e-4536a07837esm16422461cf.91.2024.08.16.07.20.14
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 16 Aug 2024 07:20:14 -0700 (PDT)
From: Dean Marx <dmarx@iol.unh.edu>
To: probb@iol.unh.edu, npratte@iol.unh.edu, jspewock@iol.unh.edu,
luca.vizzarro@arm.com, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com,
juraj.linkes@pantheon.tech
Cc: dev@dpdk.org,
Dean Marx <dmarx@iol.unh.edu>
Subject: [PATCH v1 1/2] dts: add csum HW offload to testpmd shell
Date: Fri, 16 Aug 2024 10:20:30 -0400
Message-ID: <20240816142031.15150-2-dmarx@iol.unh.edu>
X-Mailer: git-send-email 2.44.0
In-Reply-To: <20240816142031.15150-1-dmarx@iol.unh.edu>
References: <20240816142031.15150-1-dmarx@iol.unh.edu>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
add csum_set_hw method to testpmd shell class. Port over
set_verbose and port start/stop from queue start/stop suite.
Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
---
dts/framework/remote_session/testpmd_shell.py | 124 ++++++++++++++++++
1 file changed, 124 insertions(+)
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
index 43e9f56517..be7cd16b96 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -334,6 +334,32 @@ def make_parser(cls) -> ParserFn:
)
+class ChecksumOffloadOptions(Flag):
+ """Flag representing checksum hardware offload layer options."""
+
+ #:
+ ip = auto()
+ #:
+ udp = auto()
+ #:
+ tcp = auto()
+ #:
+ sctp = auto()
+ #:
+ outerip = auto()
+ #:
+ outerudp = auto()
+
+ def __str__(self):
+ """String method for use in csum_set_hw."""
+ if self == ChecksumOffloadOptions.outerip:
+ return "outer-ip"
+ elif self == ChecksumOffloadOptions.outerudp:
+ return "outer-udp"
+ else:
+ return f"{self.name}"
+
+
class DeviceErrorHandlingMode(StrEnum):
"""Enum representing the device error handling mode."""
@@ -806,6 +832,104 @@ def show_port_stats(self, port_id: int) -> TestPmdPortStats:
return TestPmdPortStats.parse(output)
+ def port_stop(self, port: int, verify: bool = True):
+ """Stop specified port.
+
+ Args:
+ port: Specifies the port number to use, must be between 0-32.
+ verify: If :data:`True`, the output of the command is scanned
+ to ensure specified port is stopped. If not, it is considered
+ an error.
+
+ Raises:
+ InteractiveCommandExecutionError: If `verify` is :data:`True` and the port
+ is not stopped.
+ """
+ port_output = self.send_command(f"port stop {port}")
+ if verify:
+ if "Done" not in port_output:
+ self._logger.debug(f"Failed to stop port {port}: \n{port_output}")
+ raise InteractiveCommandExecutionError(f"Testpmd failed to stop port {port}.")
+
+ def port_start(self, port: int, verify: bool = True):
+ """Start specified port.
+
+ Args:
+ port: Specifies the port number to use, must be between 0-32.
+ verify: If :data:`True`, the output of the command is scanned
+ to ensure specified port is started. If not, it is considered
+ an error.
+
+ Raises:
+ InteractiveCommandExecutionError: If `verify` is :data:`True` and the port
+ is not started.
+ """
+ port_output = self.send_command(f"port start {port}")
+ if verify:
+ if "Done" not in port_output:
+ self._logger.debug(f"Failed to start port {port}: \n{port_output}")
+ raise InteractiveCommandExecutionError(f"Testpmd failed to start port {port}.")
+
+ def csum_set_hw(self, layer: ChecksumOffloadOptions, port_id: int, verify: bool = True) -> None:
+ """Enables hardware checksum offloading on the specified layer.
+
+ Args:
+ layer: The layer that checksum offloading should be enabled on.
+ options: tcp, ip, udp, sctp, outer-ip, outer-udp.
+ port_id: The port number to enable checksum offloading on, should be within 0-32.
+ verify: If :data:`True` the output of the command will be scanned in an attempt to
+ verify that checksum offloading was enabled on the port.
+
+ Raises:
+ InteractiveCommandExecutionError: If checksum offload is not enabled successfully.
+ """
+ csum_output = self.send_command(f"csum set {str(layer)} hw {port_id}")
+ if verify:
+ if "Bad arguments" in csum_output or f"Please stop port {port_id} first" in csum_output:
+ self._logger.debug(f"Failed to set csum hw mode on port {port_id}:\n{csum_output}")
+ raise InteractiveCommandExecutionError(
+ f"Failed to set csum hw mode on port {port_id}"
+ )
+ if verify and f"checksum offload is not supported by port {port_id}" in csum_output:
+ self._logger.debug(f"Checksum {layer} offload is not supported:\n{csum_output}")
+
+ success = False
+ if layer == ChecksumOffloadOptions.outerip:
+ if "Outer-Ip checksum offload is hw" in csum_output:
+ success = True
+ elif layer == ChecksumOffloadOptions.outerudp:
+ if "Outer-Udp checksum offload is hw" in csum_output:
+ success = True
+ else:
+ if f"{str(layer).upper} checksum offload is hw" in csum_output:
+ success = True
+ if not success and verify:
+ self._logger.debug(f"Failed to set csum hw mode on port {port_id}:\n{csum_output}")
+
+ def set_verbose(self, level: int, verify: bool = True) -> None:
+ """Set debug verbosity level.
+
+ Args:
+ level:
+ 0: silent except for error.
+ 1: fully verbose except for Tx packets.
+ 2: fully verbose except for Rx packets.
+ >2: fully verbose.
+ verify: if :data:`True` an additional command will be sent to verify that verbose level
+ is properly set. Defaults to :data:`True`.
+
+ Raises:
+ InteractiveCommandExecutionError: If `verify` is :data:`True` and verbose level
+ is not correctly set.
+ """
+ verbose_output = self.send_command(f"set verbose {level}")
+ if verify:
+ if "Change verbose level" not in verbose_output:
+ self._logger.debug(f"Failed to set verbose level to {level}: \n{verbose_output}")
+ raise InteractiveCommandExecutionError(
+ f"Testpmd failed to set verbose level to {level}."
+ )
+
def _close(self) -> None:
"""Overrides :meth:`~.interactive_shell.close`."""
self.stop()
--
2.44.0