From: Stephen Hemminger <stephen@networkplumber.org>
To: Vipin Varghese <vipin.varghese@amd.com>
Cc: <ferruh.yigit@amd.com>, <bruce.richardson@intel.com>,
<konstantin.v.ananyev@yandex.ru>, <aman.deep.singh@intel.com>,
<dev@dpdk.org>
Subject: Re: [PATCH v2 1/3] app/testpmd: add register keyword
Date: Wed, 21 Aug 2024 07:55:02 -0700 [thread overview]
Message-ID: <20240821075502.3faa0997@hermes.local> (raw)
In-Reply-To: <20240821143857.1972-2-vipin.varghese@amd.com>
On Wed, 21 Aug 2024 20:08:55 +0530
Vipin Varghese <vipin.varghese@amd.com> wrote:
> diff --git a/app/test-pmd/macswap_sse.h b/app/test-pmd/macswap_sse.h
> index 223f87a539..29088843b7 100644
> --- a/app/test-pmd/macswap_sse.h
> +++ b/app/test-pmd/macswap_sse.h
> @@ -16,13 +16,13 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t nb,
> uint64_t ol_flags;
> int i;
> int r;
> - __m128i addr0, addr1, addr2, addr3;
> + register __m128i addr0, addr1, addr2, addr3;
Some compilers treat register as a no-op. Are you sure? Did you check with godbolt.
next prev parent reply other threads:[~2024-08-21 14:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 6:37 [PATCH] app/testpmd: improve sse based macswap Vipin Varghese
2024-07-23 16:45 ` Ferruh Yigit
2024-07-23 17:12 ` Bruce Richardson
2024-07-25 12:47 ` Varghese, Vipin
2024-07-25 12:52 ` Bruce Richardson
2024-08-21 14:38 ` [PATCH v2 0/3] " Vipin Varghese
2024-08-21 14:38 ` [PATCH v2 1/3] app/testpmd: add register keyword Vipin Varghese
2024-08-21 14:55 ` Stephen Hemminger [this message]
2024-08-27 15:32 ` Varghese, Vipin
2024-08-27 17:39 ` Stephen Hemminger
2024-08-29 8:14 ` Varghese, Vipin
2024-09-03 11:52 ` Konstantin Ananyev
2024-09-06 13:02 ` Varghese, Vipin
2024-10-04 5:04 ` Ferruh Yigit
2024-08-21 14:38 ` [PATCH v2 2/3] app/testpmd: move offload update Vipin Varghese
2024-08-21 14:38 ` [PATCH v2 3/3] app/testpmd: interleave SSE SIMD Vipin Varghese
2024-10-04 5:08 ` [PATCH v2 0/3] app/testpmd: improve sse based macswap Ferruh Yigit
2024-10-08 1:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821075502.3faa0997@hermes.local \
--to=stephen@networkplumber.org \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).