From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 94DF5459AD;
Mon, 16 Sep 2024 13:01:34 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 208F34025F;
Mon, 16 Sep 2024 13:01:34 +0200 (CEST)
Received: from EUR02-VI1-obe.outbound.protection.outlook.com
(mail-vi1eur02on2072.outbound.protection.outlook.com [40.107.241.72])
by mails.dpdk.org (Postfix) with ESMTP id CCC5940041
for <dev@dpdk.org>; Mon, 16 Sep 2024 13:01:32 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=DbdfTqXBwXj6BMnVTiw/X4P0IQjh3OIsBBGFDOw3iYcW2O7kobRPMPwRj2kvoHE722GIFVr8dNlOKO/Z9Ba+icZFudhlLKhY00E0D1zIfm+J7bKy0pUg+E/tC7HNUfZ2bgAjrmP3wlhhTpgOKZiX2ymN4IW4BfoNCzzCpaTxXxZ8hrvw+5+q6WGyKpWfgIXFLuOXj4GZXRlZOjrdr6qo1b8vSSdNUq49z29e6OVniFo5uIgz08HnqRiJy3F2y2ONTmBc4YHONQe8pjr0DyNn7BH6nAFu5Pnoiqexi3i+kka5PwWuLWQ+yf4icKIFcFaUYw9RKGjU4y0LZllwMKTQpQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=GXhJPcnr1seXDHrmffoS7GoGYiQKkb4o5ZNEmanF30E=;
b=pgblVh+pYwQVnKL28aiTigm0JxKV4ojkIaskI3c7ccB9oAyMRyknQf8o86eVCFEzvLkdCjNp8MqDwrlYXlLLhQ/WCNN8LpRWGdM6xa5F2H7AouF8YHjCfETCW147BkNnaUl3omZ9YSJ/+IM7lQyEJwdksKEKEl8z1KB9tLrslf09b7POTwGh2zGPwKcJomuM2PcrY9IPjF4c2/PSLiXNLgtreVERCVAK/YRKS8c8Pm3LN4SdxviT0MXypaR+LrdBN66YrepB+efsDma+pfYq/PpVoHU7Q7gigIVwteHhfiB2Wb2oNubBIcWSQqIlUFHB+dW1RV6m+ndaY0jYL1lUhA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;
dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;
dkim=none (message not signed); arc=none (0)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=GXhJPcnr1seXDHrmffoS7GoGYiQKkb4o5ZNEmanF30E=;
b=QHSAET+VGnpH6fnMIXunBXqY8h7H5doCGMJOrpMxd3szJOtHc09/7snotMV3bfN1A1m3LhRP70PNKtlIP9UDevOHLiCGnLW1t5E7AaXK3v0ujvNs47XU6IuY03zS+2h6rrvcdepZnab3JzrOJiompFIaHUi2FF5uMa4iugVju17j5sBfE4m+ZeqwXRQFxEBpJxx65RU37qwHchhrzfACV1m6CKqEwEkv91Q0C4hBGxs0VDfhLEYlYX/MyQ4P71vXiSsyB3GohA0GXIPjb1vPvieCzdW3lg88b7JEqJOs6p7UVb9BUZ92O9yHmYLW+utpdzZXQOa/ftdVJUBWZ1NtOA==
Received: from AS9PR05CA0032.eurprd05.prod.outlook.com (2603:10a6:20b:489::30)
by DB9PR07MB9740.eurprd07.prod.outlook.com (2603:10a6:10:4c3::12)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7962.23; Mon, 16 Sep
2024 11:01:30 +0000
Received: from AMS1EPF0000004E.eurprd04.prod.outlook.com
(2603:10a6:20b:489:cafe::31) by AS9PR05CA0032.outlook.office365.com
(2603:10a6:20b:489::30) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.30 via Frontend
Transport; Mon, 16 Sep 2024 11:01:30 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74)
smtp.mailfrom=ericsson.com; dkim=none (message not signed)
header.d=none;dmarc=pass action=none header.from=ericsson.com;
Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates
192.176.1.74 as permitted sender)
receiver=protection.outlook.com;
client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C
Received: from oa.msg.ericsson.com (192.176.1.74) by
AMS1EPF0000004E.mail.protection.outlook.com (10.167.16.139) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.7918.13 via Frontend Transport; Mon, 16 Sep 2024 11:01:30 +0000
Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by
smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server
id 15.2.1544.11; Mon, 16 Sep 2024 13:01:28 +0200
Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])
by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id
5A6D738007A; Mon, 16 Sep 2024 13:01:28 +0200 (CEST)
From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
To: <dev@dpdk.org>
CC: <hofors@lysator.liu.se>, =?UTF-8?q?Morten=20Br=C3=B8rup?=
<mb@smartsharesystems.com>, Stephen Hemminger <stephen@networkplumber.org>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, David Marchand
<david.marchand@redhat.com>, Jerin Jacob <jerinj@marvell.com>,
=?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
Subject: [PATCH v4 2/7] eal: add lcore variable functional tests
Date: Mon, 16 Sep 2024 12:52:05 +0200
Message-ID: <20240916105210.721315-3-mattias.ronnblom@ericsson.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20240916105210.721315-1-mattias.ronnblom@ericsson.com>
References: <20240912084429.703405-2-mattias.ronnblom@ericsson.com>
<20240916105210.721315-1-mattias.ronnblom@ericsson.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AMS1EPF0000004E:EE_|DB9PR07MB9740:EE_
X-MS-Office365-Filtering-Correlation-Id: dd7104ef-074e-4242-18c9-08dcd63eeb52
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
ARA:13230040|36860700013|82310400026|376014|1800799024;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?dndPaERGa2lWSGgxSTZPRkd1WGNNUm5jTmxLYXJsa1EzTnRsanU1T01vRTVD?=
=?utf-8?B?dExYNmtrRXBwNVVGR3VqTlhneVVLTDc4cithSmpYbDArdTNvN2NYVm5MZ00x?=
=?utf-8?B?UDRRRldMVS82WURQbjJCL0I3L29TQlk0RGNyVUxhUGJ0M1k0U2RuRzJjcjJ6?=
=?utf-8?B?MFRZWGttKzdFS3NCdTBPRUpTL3VxaytlL25Qd2tIcnRxNmczb0FqZjZ2Kzhm?=
=?utf-8?B?am5vd1oyeW0wbXlpTFA2ZjR2RXVZSVgyMkZFMFBiYnpWcHd3a0dPVTUvNHhH?=
=?utf-8?B?ZGZpd214aXJqZkNsclNmd1hNWVBwc3FFODBjOFNqUEo3TVZLangzUDBOQmJ0?=
=?utf-8?B?YlltK0RWNElnOVVwNlNsVE04NVIyeDdWaTZFWU5EWGlKcG9RaFE0bXdkcElF?=
=?utf-8?B?YkpDeGVkTnFpSVFGdTN3aHNkMWJ1S1FJTjJURTZ1cUxDMHRGS05oTFdwMU5n?=
=?utf-8?B?UW5PWXVpcnUyY2RjV3lyVGZ4VzVTeUM0aHNIbUNZeTZReG00U1VXZUNIcDJO?=
=?utf-8?B?Q0lvL1RKeVl4NExnUTMveGFuYUJoVjg4NTVqeTRHay8wSGQxeVpkUEk1V0lY?=
=?utf-8?B?UlVUdUxyZE9SY3pPdUF1QjlIay9GWGU5bXpVWmN2OGZSbm9HOVVodlp3QUJj?=
=?utf-8?B?U2NzY3k4Sis0Um1hNVZyOTBrYTNBSDBHWG4vYk15cDdvWDEzRzV2NURUc002?=
=?utf-8?B?T00wMHpRR21VcmREdkJrcTNlS1A2a21UdEJTVDNwZ3M1VWVQbzhHN2lscHBY?=
=?utf-8?B?WHZ1em9VNlJsT0JRbFBUa0R1dWxpOVN2UFdRaVE1ZUx2ODdNc3ZrUVBXMW9P?=
=?utf-8?B?WXNNbTJaYWU4Sm5mYUYyNUtDQkpTVUlPa1U2TnNWOFlIY3lIR1dxdjZBdThH?=
=?utf-8?B?TWdETGRXS2lFSXJUSHAxUVFmUmNvRm1VQmx5c3VtTWMrQ2c3TmljLzgyRm1O?=
=?utf-8?B?bUJQZ1UvVjJ5Qzhkb3kyZUw5V3hmUEQ4NC9PRmZPWVd2WWVIOTFQdFlxM3NN?=
=?utf-8?B?N2RqMmYvbWVGT1VSZ2RibFNHZWtHQlR0enQweDk4aWZYdEF4T0IzbEQwcHVu?=
=?utf-8?B?OExoaEhBVWgvbFAydXRreldRWDU3MURrUEtQeDNUMS9lNTNqSXJBbkNuVzhq?=
=?utf-8?B?c1NxVGswQkQ3dzV5eDI5OU9ENkdMNEphcFhvdzQ1K0NDTm9LWUdyL3V1TWdp?=
=?utf-8?B?WjIvVGZUQlByQTRoMElxNmRSN3Y1Z24vMGdjWW9GZ1pJMUdHZ2lDVWthL2NU?=
=?utf-8?B?S3hialh4dyttZHdOclJ2bkRnazlsbiszS2NDb2ZaRktxbm11Ulpxdm51aUc3?=
=?utf-8?B?dlpyQi82QWxla2Q1Ty85R0tYcEdGRlFSMmgrbTY5UFRVVnNQZjJrc3NFOW0w?=
=?utf-8?B?ZjlWYnFlYm8zM3dQQlVrd3RYSUpBa29OUm9lOVhndlFJZ3BZUm13MGVBV2Ew?=
=?utf-8?B?b05HNjBGS3hxU0txaXNIZkRHS0tOd3VQRC84ZnZ0a3JIbjFOMkluRUxmWXlI?=
=?utf-8?B?VmJ3RG1DVFU5YisrTmFVOVZYVkdvcGhpdVZTcFA0VktNdkM4VWViU1daanpZ?=
=?utf-8?B?Y3laM2FyblA2R0p6NlJkTFRsdXVDaUV4d2RMc090WWt1RVNyQ1FIeXl5d2pP?=
=?utf-8?B?N1ROK1pYakFCQW1tQ3dyOW1UVWlyUElmSmxsU29INnhJOUZhWjIvUnIvaG1x?=
=?utf-8?B?NzNWNGI1aDVZc0VoK1ErN3Y2MThOMlMvQmNOeGZ1VnRNN29qSzRjN0VHeE9n?=
=?utf-8?B?QzdlTTlCZlRlWjNmM1FsYUk0NzhqdEJMUGhtbVF5TUs0S0c5ZHExZnAwNUI1?=
=?utf-8?Q?LkTyBWjCWSuwkZ5eKXHP/FPz55JkLgbXYanaQ=3D?=
X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;
CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(376014)(1800799024);
DIR:OUT; SFP:1101;
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2024 11:01:30.3641 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: dd7104ef-074e-4242-18c9-08dcd63eeb52
X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];
Helo=[oa.msg.ericsson.com]
X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004E.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR07MB9740
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add functional test suite to exercise the <rte_lcore_var.h> API.
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
--
RFC v5:
* Adapt tests to reflect the removal of the GET() and SET() macros.
RFC v4:
* Check all lcore id's values for all variables in the many variables
test case.
* Introduce test case for max-sized lcore variables.
RFC v2:
* Improve alignment-related test coverage.
---
app/test/meson.build | 1 +
app/test/test_lcore_var.c | 432 ++++++++++++++++++++++++++++++++++++++
2 files changed, 433 insertions(+)
create mode 100644 app/test/test_lcore_var.c
diff --git a/app/test/meson.build b/app/test/meson.build
index e29258e6ec..48279522f0 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -103,6 +103,7 @@ source_file_deps = {
'test_ipsec_sad.c': ['ipsec'],
'test_kvargs.c': ['kvargs'],
'test_latencystats.c': ['ethdev', 'latencystats', 'metrics'] + sample_packet_forward_deps,
+ 'test_lcore_var.c': [],
'test_lcores.c': [],
'test_link_bonding.c': ['ethdev', 'net_bond',
'net'] + packet_burst_generator_deps + virtual_pmd_deps,
diff --git a/app/test/test_lcore_var.c b/app/test/test_lcore_var.c
new file mode 100644
index 0000000000..e07d13460f
--- /dev/null
+++ b/app/test/test_lcore_var.c
@@ -0,0 +1,432 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 Ericsson AB
+ */
+
+#include <inttypes.h>
+#include <stdio.h>
+#include <string.h>
+
+#include <rte_launch.h>
+#include <rte_lcore_var.h>
+#include <rte_random.h>
+
+#include "test.h"
+
+#define MIN_LCORES 2
+
+RTE_LCORE_VAR_HANDLE(int, test_int);
+RTE_LCORE_VAR_HANDLE(char, test_char);
+RTE_LCORE_VAR_HANDLE(long, test_long_sized);
+RTE_LCORE_VAR_HANDLE(short, test_short);
+RTE_LCORE_VAR_HANDLE(long, test_long_sized_aligned);
+
+struct int_checker_state {
+ int old_value;
+ int new_value;
+ bool success;
+};
+
+static void
+rand_blk(void *blk, size_t size)
+{
+ size_t i;
+
+ for (i = 0; i < size; i++)
+ ((unsigned char *)blk)[i] = (unsigned char)rte_rand();
+}
+
+static bool
+is_ptr_aligned(const void *ptr, size_t align)
+{
+ return ptr != NULL ? (uintptr_t)ptr % align == 0 : false;
+}
+
+static int
+check_int(void *arg)
+{
+ struct int_checker_state *state = arg;
+
+ int *ptr = RTE_LCORE_VAR_VALUE(test_int);
+
+ bool naturally_aligned = is_ptr_aligned(ptr, sizeof(int));
+
+ bool equal = *(RTE_LCORE_VAR_VALUE(test_int)) == state->old_value;
+
+ state->success = equal && naturally_aligned;
+
+ *ptr = state->new_value;
+
+ return 0;
+}
+
+RTE_LCORE_VAR_INIT(test_int);
+RTE_LCORE_VAR_INIT(test_char);
+RTE_LCORE_VAR_INIT_SIZE(test_long_sized, 32);
+RTE_LCORE_VAR_INIT(test_short);
+RTE_LCORE_VAR_INIT_SIZE_ALIGN(test_long_sized_aligned, sizeof(long),
+ RTE_CACHE_LINE_SIZE);
+
+static int
+test_int_lvar(void)
+{
+ unsigned int lcore_id;
+
+ struct int_checker_state states[RTE_MAX_LCORE] = {};
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ struct int_checker_state *state = &states[lcore_id];
+
+ state->old_value = (int)rte_rand();
+ state->new_value = (int)rte_rand();
+
+ *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_int) =
+ state->old_value;
+ }
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id)
+ rte_eal_remote_launch(check_int, &states[lcore_id], lcore_id);
+
+ rte_eal_mp_wait_lcore();
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ struct int_checker_state *state = &states[lcore_id];
+ int value;
+
+ TEST_ASSERT(state->success, "Unexpected value "
+ "encountered on lcore %d", lcore_id);
+
+ value = *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_int);
+ TEST_ASSERT_EQUAL(state->new_value, value,
+ "Lcore %d failed to update int", lcore_id);
+ }
+
+ /* take the opportunity to test the foreach macro */
+ int *v;
+ lcore_id = 0;
+ RTE_LCORE_VAR_FOREACH_VALUE(v, test_int) {
+ TEST_ASSERT_EQUAL(states[lcore_id].new_value, *v,
+ "Unexpected value on lcore %d during "
+ "iteration", lcore_id);
+ lcore_id++;
+ }
+
+ return TEST_SUCCESS;
+}
+
+static int
+test_sized_alignment(void)
+{
+ long *v;
+
+ RTE_LCORE_VAR_FOREACH_VALUE(v, test_long_sized) {
+ TEST_ASSERT(is_ptr_aligned(v, alignof(long)),
+ "Type-derived alignment failed");
+ }
+
+ RTE_LCORE_VAR_FOREACH_VALUE(v, test_long_sized_aligned) {
+ TEST_ASSERT(is_ptr_aligned(v, RTE_CACHE_LINE_SIZE),
+ "Explicit alignment failed");
+ }
+
+ return TEST_SUCCESS;
+}
+
+/* private, larger, struct */
+#define TEST_STRUCT_DATA_SIZE 1234
+
+struct test_struct {
+ uint8_t data[TEST_STRUCT_DATA_SIZE];
+};
+
+static RTE_LCORE_VAR_HANDLE(char, before_struct);
+static RTE_LCORE_VAR_HANDLE(struct test_struct, test_struct);
+static RTE_LCORE_VAR_HANDLE(char, after_struct);
+
+struct struct_checker_state {
+ struct test_struct old_value;
+ struct test_struct new_value;
+ bool success;
+};
+
+static int check_struct(void *arg)
+{
+ struct struct_checker_state *state = arg;
+
+ struct test_struct *lcore_struct = RTE_LCORE_VAR_VALUE(test_struct);
+
+ bool properly_aligned =
+ is_ptr_aligned(test_struct, alignof(struct test_struct));
+
+ bool equal = memcmp(lcore_struct->data, state->old_value.data,
+ TEST_STRUCT_DATA_SIZE) == 0;
+
+ state->success = equal && properly_aligned;
+
+ memcpy(lcore_struct->data, state->new_value.data,
+ TEST_STRUCT_DATA_SIZE);
+
+ return 0;
+}
+
+static int
+test_struct_lvar(void)
+{
+ unsigned int lcore_id;
+
+ RTE_LCORE_VAR_ALLOC(before_struct);
+ RTE_LCORE_VAR_ALLOC(test_struct);
+ RTE_LCORE_VAR_ALLOC(after_struct);
+
+ struct struct_checker_state states[RTE_MAX_LCORE];
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ struct struct_checker_state *state = &states[lcore_id];
+
+ rand_blk(state->old_value.data, TEST_STRUCT_DATA_SIZE);
+ rand_blk(state->new_value.data, TEST_STRUCT_DATA_SIZE);
+
+ memcpy(RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_struct)->data,
+ state->old_value.data, TEST_STRUCT_DATA_SIZE);
+ }
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id)
+ rte_eal_remote_launch(check_struct, &states[lcore_id],
+ lcore_id);
+
+ rte_eal_mp_wait_lcore();
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ struct struct_checker_state *state = &states[lcore_id];
+ struct test_struct *lstruct =
+ RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_struct);
+
+ TEST_ASSERT(state->success, "Unexpected value encountered on "
+ "lcore %d", lcore_id);
+
+ bool equal = memcmp(lstruct->data, state->new_value.data,
+ TEST_STRUCT_DATA_SIZE) == 0;
+
+ TEST_ASSERT(equal, "Lcore %d failed to update struct",
+ lcore_id);
+ }
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ char before =
+ *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, before_struct);
+ char after =
+ *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, after_struct);
+
+ TEST_ASSERT_EQUAL(before, 0, "Lcore variable before test "
+ "struct was modified on lcore %d", lcore_id);
+ TEST_ASSERT_EQUAL(after, 0, "Lcore variable after test "
+ "struct was modified on lcore %d", lcore_id);
+ }
+
+ return TEST_SUCCESS;
+}
+
+#define TEST_ARRAY_SIZE 99
+
+typedef uint16_t test_array_t[TEST_ARRAY_SIZE];
+
+static void test_array_init_rand(test_array_t a)
+{
+ size_t i;
+ for (i = 0; i < TEST_ARRAY_SIZE; i++)
+ a[i] = (uint16_t)rte_rand();
+}
+
+static bool test_array_equal(test_array_t a, test_array_t b)
+{
+ size_t i;
+ for (i = 0; i < TEST_ARRAY_SIZE; i++) {
+ if (a[i] != b[i])
+ return false;
+ }
+ return true;
+}
+
+static void test_array_copy(test_array_t dst, const test_array_t src)
+{
+ size_t i;
+ for (i = 0; i < TEST_ARRAY_SIZE; i++)
+ dst[i] = src[i];
+}
+
+static RTE_LCORE_VAR_HANDLE(char, before_array);
+static RTE_LCORE_VAR_HANDLE(test_array_t, test_array);
+static RTE_LCORE_VAR_HANDLE(char, after_array);
+
+struct array_checker_state {
+ test_array_t old_value;
+ test_array_t new_value;
+ bool success;
+};
+
+static int check_array(void *arg)
+{
+ struct array_checker_state *state = arg;
+
+ test_array_t *lcore_array = RTE_LCORE_VAR_VALUE(test_array);
+
+ bool properly_aligned =
+ is_ptr_aligned(lcore_array, alignof(test_array_t));
+
+ bool equal = test_array_equal(*lcore_array, state->old_value);
+
+ state->success = equal && properly_aligned;
+
+ test_array_copy(*lcore_array, state->new_value);
+
+ return 0;
+}
+
+static int
+test_array_lvar(void)
+{
+ unsigned int lcore_id;
+
+ RTE_LCORE_VAR_ALLOC(before_array);
+ RTE_LCORE_VAR_ALLOC(test_array);
+ RTE_LCORE_VAR_ALLOC(after_array);
+
+ struct array_checker_state states[RTE_MAX_LCORE];
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ struct array_checker_state *state = &states[lcore_id];
+
+ test_array_init_rand(state->new_value);
+ test_array_init_rand(state->old_value);
+
+ test_array_copy(*RTE_LCORE_VAR_LCORE_VALUE(lcore_id,
+ test_array),
+ state->old_value);
+ }
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id)
+ rte_eal_remote_launch(check_array, &states[lcore_id],
+ lcore_id);
+
+ rte_eal_mp_wait_lcore();
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ struct array_checker_state *state = &states[lcore_id];
+ test_array_t *larray =
+ RTE_LCORE_VAR_LCORE_VALUE(lcore_id, test_array);
+
+ TEST_ASSERT(state->success, "Unexpected value encountered on "
+ "lcore %d", lcore_id);
+
+ bool equal = test_array_equal(*larray, state->new_value);
+
+ TEST_ASSERT(equal, "Lcore %d failed to update array",
+ lcore_id);
+ }
+
+ RTE_LCORE_FOREACH_WORKER(lcore_id) {
+ char before =
+ *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, before_array);
+ char after =
+ *RTE_LCORE_VAR_LCORE_VALUE(lcore_id, after_array);
+
+ TEST_ASSERT_EQUAL(before, 0, "Lcore variable before test "
+ "array was modified on lcore %d", lcore_id);
+ TEST_ASSERT_EQUAL(after, 0, "Lcore variable after test "
+ "array was modified on lcore %d", lcore_id);
+ }
+
+ return TEST_SUCCESS;
+}
+
+#define MANY_LVARS (2 * RTE_MAX_LCORE_VAR / sizeof(uint32_t))
+
+static int
+test_many_lvars(void)
+{
+ uint32_t **handlers = malloc(sizeof(uint32_t *) * MANY_LVARS);
+ unsigned int i;
+
+ TEST_ASSERT(handlers != NULL, "Unable to allocate memory");
+
+ for (i = 0; i < MANY_LVARS; i++) {
+ unsigned int lcore_id;
+
+ RTE_LCORE_VAR_ALLOC(handlers[i]);
+
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+ uint32_t *v =
+ RTE_LCORE_VAR_LCORE_VALUE(lcore_id, handlers[i]);
+ *v = (uint32_t)(i * lcore_id);
+ }
+ }
+
+ for (i = 0; i < MANY_LVARS; i++) {
+ unsigned int lcore_id;
+
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+ uint32_t v = *RTE_LCORE_VAR_LCORE_VALUE(lcore_id,
+ handlers[i]);
+ TEST_ASSERT_EQUAL((uint32_t)(i * lcore_id), v,
+ "Unexpected lcore variable value on "
+ "lcore %d", lcore_id);
+ }
+ }
+
+ free(handlers);
+
+ return TEST_SUCCESS;
+}
+
+static int
+test_large_lvar(void)
+{
+ RTE_LCORE_VAR_HANDLE(unsigned char, large);
+ unsigned int lcore_id;
+
+ RTE_LCORE_VAR_ALLOC_SIZE(large, RTE_MAX_LCORE_VAR);
+
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+ unsigned char *ptr = RTE_LCORE_VAR_LCORE_VALUE(lcore_id, large);
+
+ memset(ptr, (unsigned char)lcore_id, RTE_MAX_LCORE_VAR);
+ }
+
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+ unsigned char *ptr = RTE_LCORE_VAR_LCORE_VALUE(lcore_id, large);
+ size_t i;
+
+ for (i = 0; i < RTE_MAX_LCORE_VAR; i++)
+ TEST_ASSERT_EQUAL(ptr[i], (unsigned char)lcore_id,
+ "Large lcore variable value is "
+ "corrupted on lcore %d.",
+ lcore_id);
+ }
+
+ return TEST_SUCCESS;
+}
+
+static struct unit_test_suite lcore_var_testsuite = {
+ .suite_name = "lcore variable autotest",
+ .unit_test_cases = {
+ TEST_CASE(test_int_lvar),
+ TEST_CASE(test_sized_alignment),
+ TEST_CASE(test_struct_lvar),
+ TEST_CASE(test_array_lvar),
+ TEST_CASE(test_many_lvars),
+ TEST_CASE(test_large_lvar),
+ TEST_CASES_END()
+ },
+};
+
+static int test_lcore_var(void)
+{
+ if (rte_lcore_count() < MIN_LCORES) {
+ printf("Not enough cores for lcore_var_autotest; expecting at "
+ "least %d.\n", MIN_LCORES);
+ return TEST_SKIPPED;
+ }
+
+ return unit_test_suite_runner(&lcore_var_testsuite);
+}
+
+REGISTER_FAST_TEST(lcore_var_autotest, true, false, test_lcore_var);
--
2.34.1