From: Stephen Hemminger <stephen@networkplumber.org>
To: Isaac Boukris <iboukris@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/tap: add new macpair option for split MAC address
Date: Mon, 16 Sep 2024 20:34:45 -0700 [thread overview]
Message-ID: <20240916203445.110cc8dd@hermes.local> (raw)
In-Reply-To: <20240916173851.369395-1-iboukris@gmail.com>
On Mon, 16 Sep 2024 20:38:51 +0300
Isaac Boukris <iboukris@gmail.com> wrote:
> +
> + if (pmd->mac_pair) {
> + rte_memcpy(&pmd->eth_addr, mac_addr, RTE_ETHER_ADDR_LEN);
> + return 0;
> + }
Do not use rte_memcpy for simple mac address copy.
Better to use rte_ether_addr_copy (or just memcpy)
next prev parent reply other threads:[~2024-09-17 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 17:38 Isaac Boukris
2024-09-17 3:34 ` Stephen Hemminger [this message]
2024-09-17 3:36 ` Stephen Hemminger
2024-09-17 6:48 ` Isaac Boukris
2024-09-17 7:38 ` Morten Brørup
2024-09-17 11:51 Isaac Boukris
2024-09-17 12:14 ` Isaac Boukris
2024-09-29 21:54 ` Ferruh Yigit
2024-09-30 13:28 ` Isaac Boukris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916203445.110cc8dd@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=iboukris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).