From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B361459B0; Tue, 17 Sep 2024 05:34:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBDA0402C4; Tue, 17 Sep 2024 05:34:49 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 13C9540261 for ; Tue, 17 Sep 2024 05:34:48 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-718816be6cbso3967110b3a.1 for ; Mon, 16 Sep 2024 20:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726544087; x=1727148887; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=C02lnBlbVzGjqWTUNagesqVDjiy7cDiKqALdYu8S4hM=; b=eLB860dfdBzcccQCfBlM0dFZc9RRVfmRdFM7IU/SROhi+R7ImHl4Guj2q3JVfKy5Oc EQuNsYjBmNWLZe3/lVWyu2NHAsSDzVoxaHP1Dyx7/DEsxa0KKN44thcIQHO8zYjjbqQf ss7Qnb4fzCgiv53ZxVDmTFhyMXEkmG2qRq9jBsFmXT1ralopayJM28MFORDzb+bz/6D2 Akbq51zz1qVp9aBrpQd0GIgiKnAIUkCxGNmfgRppAQObgBwTHypXCH1PCDHDCMRtD7c+ Ime2zw+KHweV4YtveTL5DfWuLHsHLx7qdQjtRHq1qc77O7R99wZJHMbmB0ZUNtVauqPy q/0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726544087; x=1727148887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C02lnBlbVzGjqWTUNagesqVDjiy7cDiKqALdYu8S4hM=; b=rDMzcrxylZVkDL6BgKjF0wU6CgKDZNNQbXvnhFC+wBUy6EI9utKfrY0FipIzKT9QFM V/FIdaiAF9AZSF/5ES/9A470iOnMNaQkHEmVF4hNgojUZ/ZP/dIwMtvIB+Z7t6eEpNCC H71azCk/sLXVw1ejCtS3spHWoF+DeIaNs4NWVzxb3k0ZE8d5sM6UosbEfvtVHqPZlnDi McjI/qeJcCwBFQOvymJyh6nEbpSiTKCgj6bwiBGqYzE4Pvseyubrv6BYqHuZpAWC5yxV Xt00kzjsnW5eTmEAaYRGpxd6b6YowvMaxBbB+QazxdrvCdJRdFY/Svc/o6ZXh6gE9cDK btog== X-Gm-Message-State: AOJu0Yx6tnHcB4vEX9FgI4t0P30WxDe17abHZmLohDSmNEJPIcj4YiCJ mqyYAHiWPemPYFAAUM6ooFm29RQm3PITc9sVXvj2SDBAGUpmPEPaRvTveCAHDxo= X-Google-Smtp-Source: AGHT+IGT/Z6RErnPyhYVp3AtwHF0ihFMl1AD2G/O31cZ00co8rI3rdVQWqdCXW0qZqgmrMBq4k5f3Q== X-Received: by 2002:a05:6a21:4a4b:b0:1cf:37bd:b553 with SMTP id adf61e73a8af0-1cf76244cb3mr24125829637.46.1726544087186; Mon, 16 Sep 2024 20:34:47 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71944a9831esm4416427b3a.24.2024.09.16.20.34.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 20:34:47 -0700 (PDT) Date: Mon, 16 Sep 2024 20:34:45 -0700 From: Stephen Hemminger To: Isaac Boukris Cc: dev@dpdk.org Subject: Re: [PATCH] net/tap: add new macpair option for split MAC address Message-ID: <20240916203445.110cc8dd@hermes.local> In-Reply-To: <20240916173851.369395-1-iboukris@gmail.com> References: <20240916173851.369395-1-iboukris@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 16 Sep 2024 20:38:51 +0300 Isaac Boukris wrote: > + > + if (pmd->mac_pair) { > + rte_memcpy(&pmd->eth_addr, mac_addr, RTE_ETHER_ADDR_LEN); > + return 0; > + } Do not use rte_memcpy for simple mac address copy. Better to use rte_ether_addr_copy (or just memcpy)