From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79D91459C0; Tue, 17 Sep 2024 22:42:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37FA2427E3; Tue, 17 Sep 2024 22:41:59 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 44691427B6 for ; Tue, 17 Sep 2024 22:41:53 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20696938f86so50746695ad.3 for ; Tue, 17 Sep 2024 13:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726605712; x=1727210512; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=egxw4h7TVGRZa9tIbs1MSiQ6yUmfIbXvbyem5wLytJw=; b=FbWN/6cKhAqw159g1V+nL3uWnVC8GoevP0jGW+iHTKs7Er6xQ/cPNSh+ENE+HbADw0 OV/vAQhAAxTS7HP+qzRhc5rJipKIQY7XwUSivvA9D0jQhuQOm3+nDe078tPCBK/nKA8t /p/KroYsTTa58G8UNENaLVAJ2VZgF46/+dapAPrju4dHL5feHxuQIv97XNMqczAg4ewx GDSXrLNVaIVctievUIkxZraoLP5MML7T7002ek3xUhikPhYUJAQWLb/Tg1Wvqby2AV3h z39FETg1UEY+5exUcxL6B7/KLejpPSZMN6ZeZW5eXtcpWE6fIhnqxuVnMHAQKeGQVlC5 1m/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726605712; x=1727210512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=egxw4h7TVGRZa9tIbs1MSiQ6yUmfIbXvbyem5wLytJw=; b=mP0G406q17hsngBo04qO6owHW4Ubtw72OOU0fp2DoK/uL3pL4ZLWOzl8a5Eb64agCU d0CyKCMfG3t6XFIXz9KLfGfbAx3Vk2VA5fkBxUuXi/Era2iXHAg0GnuHrIMpz2ylOpb/ 4TAI38OlY0GU9dJp0dcjzii0QZFanYTLfpL22SYzDswNpy935aWyTeHhN+/3voO5ImGw KYRrsQg2AEgdrCqyVqn1OuUfYwgDC1SNcBvJYcGAE8SzXqmJmXIs/zF357Ottqbn9B5D 3+xiNnFJm0A2L/b6+z85eLpcm104m60+OpsiEwm0CEHrhGt6MDpJzfRIBNIyrKNUeGo5 sqZA== X-Gm-Message-State: AOJu0YyKxI/3KLRZePW+4mhiPjAsWCGBz2jfsBmcntaTR6ATEK4kBL1Y VRYtXSLse9WRLXe/GD3xln5FJ6t1Oh2MH+Qp22RPOtYxVkAsdhKAPPkL7TYYQkIm8EUV0zo1Vd6 M X-Google-Smtp-Source: AGHT+IFPZ5lp/vGLtild4sDMBREPyU9bSSCemHsSK4qz5r3qx4CQRhYG5+V1V6/fVfqzOWD/7dTayw== X-Received: by 2002:a17:902:db0a:b0:1fd:67c2:f975 with SMTP id d9443c01a7336-2076e38ca9fmr313495835ad.29.1726605712394; Tue, 17 Sep 2024 13:41:52 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20794731afasm53830425ad.272.2024.09.17.13.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2024 13:41:52 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= Subject: [PATCH v22 05/15] eal: do not duplicate rte_init_alert() messages Date: Tue, 17 Sep 2024 13:35:47 -0700 Message-ID: <20240917203828.414701-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240917203828.414701-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240917203828.414701-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 0ded386472..7c26393d00 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.45.2