From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FF51459C3; Wed, 18 Sep 2024 06:58:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B8D84027C; Wed, 18 Sep 2024 06:58:42 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id D190C40156 for ; Wed, 18 Sep 2024 06:58:40 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-206aee40676so39792075ad.0 for ; Tue, 17 Sep 2024 21:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726635520; x=1727240320; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QzwlYwRChst1A6I2RVCoj32Linvv9qjG6i+YbkW/Yf4=; b=uhOe5sgQfWDvMTXpm186hK8vymp0DcGxp3wzHCEAboZT9z8KmF64aFfsAZIw+CxtrC xsyYl5LUtVmaRCTis3aGvXJDlH5z4pkvtAdLAuHOleotldGeNZ813fEO6URzEF8vM1GB u5srx3C7unrL9RLIbo6Vjk2p7+NduLreP7av81Mc0dZxJoOS93CTscCgD/Pvxvp60zbU eAk/a8knND5LR1/4dKJnwm/MMGBlLEsJx2Sj7W/FqMar0sliWLWKlxQphSrn/avARvWK zEXPh9zhqt2MUWw9ydkwvSYWU6PueWrkQMP30C/OIbVuSPWVa6llcDg1NFZ85P9/prwd UG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726635520; x=1727240320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QzwlYwRChst1A6I2RVCoj32Linvv9qjG6i+YbkW/Yf4=; b=kVUJEzW2noLfUKXHy3gfhXGADvkXT9Q65R6Jr7vj43iknxKszid+YHNF92QWOo8eib Cnf0Q1i12N3qMW1LGjsvJWiioI5dbeL/mr/rDwtqbZaThOyFSBVDdCieLp6COqEAblYY p59DlCm0LrXugEMeZ2kfrOnNDIsmuJaFTCZhb6Hu3Ysn6Ig5wyl+9HtioTnUG54cgmEj g/ANyREgBUMDkYyzRZc2zkHTFtNP6P5azk/2AJ4eokLQgUAx1sUN0N9pkGHXI8ItK+Ax /xzcvpqVN97jANV6vjX8RlpOeNmQtFY+AWteLxmm6+TzWwfxfkAPddzqqpQ9iqwteLyS xLJA== X-Gm-Message-State: AOJu0Yx4FJBQ3Zjhssydw20vXYjVbblQL1pgoAuWh07PS+4a1zS4Nf2j T89vvFsthSJrbeU9Bady1a7U7ej9qZmZfA39Me6jbf+SGCSH+vyjZXmVzPYJN/9OkXs3VAHS3YZ w X-Google-Smtp-Source: AGHT+IHjhaU9Af7gGqVCZSzJD9KMyECKRC4YAM7m/Q/sno4wlu/0l25v21v8CvSBFDfXMqOPMwsjmw== X-Received: by 2002:a17:903:41ca:b0:206:96ae:dc57 with SMTP id d9443c01a7336-20782be51b1mr239325145ad.48.1726635519759; Tue, 17 Sep 2024 21:58:39 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20794746d76sm57179245ad.292.2024.09.17.21.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2024 21:58:39 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v23 00/15] Logging improvements Date: Tue, 17 Sep 2024 21:56:05 -0700 Message-ID: <20240918045830.3798-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20200814173441.23086-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of startup codes. Timestamp is optional and must be enabled on command line. * Displaying console output with colors. It uses the standard conventions used by many other Linux commands for colorized display. The default is to enable color if the console output is going to a terminal. But it can be always on or disabled by command line flag. This default was chosen based on what dmesg(1) command does. Color is used by many tools (vi, iproute2, git) because it is helpful; DPDK drivers and libraries print lots of not very useful messages. And having error messages highlighted in bold face helps. This might also get users to pay more attention to error messages. Many bug reports have earlier messages that are lost because there are so many info messages. * Add support for automatic detection of systemd journal protocol. If running as systemd service will get enhanced logging. * Use of syslog is optional and the meaning of the --syslog flag has changed. The default is *not* to use syslog if output is going to a terminal. Add myself as maintainer for log because by now have added more than previous authors. v23 - simplify and fix Windows and FreeBSD builds; fix #ifdefs. Change from defining stubs to using inline functions in log_private.h. Stephen Hemminger (15): maintainers: add for log library windows: make getopt functions have const properties windows: add os shim for localtime_r eal: make eal_log_level_parse common eal: do not duplicate rte_init_alert() messages eal: change rte_exit() output to match rte_log() log: move handling of syslog facility out of eal eal: initialize log before everything else log: drop syslog support, and make code common log: add hook for printing log messages log: add timestamp option log: add optional support of syslog log: add support for systemd journal log: colorize log output doc: add release note about log library MAINTAINERS | 1 + app/test/test_eal_flags.c | 64 +++++- doc/guides/linux_gsg/linux_eal_parameters.rst | 27 --- doc/guides/prog_guide/log_lib.rst | 72 ++++++ doc/guides/rel_notes/release_24_11.rst | 15 ++ lib/eal/common/eal_common_debug.c | 11 +- lib/eal/common/eal_common_options.c | 140 +++++++----- lib/eal/common/eal_options.h | 7 + lib/eal/freebsd/eal.c | 64 ++---- lib/eal/linux/eal.c | 68 ++---- lib/eal/windows/eal.c | 49 +--- lib/eal/windows/getopt.c | 23 +- lib/eal/windows/include/getopt.h | 8 +- lib/eal/windows/include/rte_os_shim.h | 10 + lib/log/log.c | 71 +++--- lib/log/log_color.c | 148 ++++++++++++ lib/log/log_freebsd.c | 12 - lib/log/log_internal.h | 28 ++- lib/log/log_journal.c | 200 +++++++++++++++++ lib/log/log_linux.c | 61 ----- lib/log/log_private.h | 61 +++++ lib/log/log_syslog.c | 88 ++++++++ lib/log/log_timestamp.c | 210 ++++++++++++++++++ lib/log/log_windows.c | 18 -- lib/log/meson.build | 12 +- lib/log/version.map | 5 +- 26 files changed, 1096 insertions(+), 377 deletions(-) create mode 100644 lib/log/log_color.c delete mode 100644 lib/log/log_freebsd.c create mode 100644 lib/log/log_journal.c delete mode 100644 lib/log/log_linux.c create mode 100644 lib/log/log_private.h create mode 100644 lib/log/log_syslog.c create mode 100644 lib/log/log_timestamp.c delete mode 100644 lib/log/log_windows.c -- 2.45.2