From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F3BA459C3; Wed, 18 Sep 2024 06:59:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CD7D42D27; Wed, 18 Sep 2024 06:58:50 +0200 (CEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 9BC41427A6 for ; Wed, 18 Sep 2024 06:58:44 +0200 (CEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-20551eeba95so47582625ad.2 for ; Tue, 17 Sep 2024 21:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1726635524; x=1727240324; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=egxw4h7TVGRZa9tIbs1MSiQ6yUmfIbXvbyem5wLytJw=; b=bWD4/g0r1N8sVgJ6bgkluHwJpIAadTuhoqU1fnAR05ALfug8+lo9jFJ8/qb4hjCLQP b3w3UbK0oDAE1l2mData+eGjPLNNcN+zFMWkDnW9nlC/PE0wtwgjOb6AkoQjSivmVusl ZtKA2PVc7eG3Zgwx1bghOWP0C6Xdr556Fw06gIgN1A/tnGNMqvSovlJ9J//czbfY+tuR KnwnrQIBE6KLza2UBRphZnVmTfZVBU/KkgmF4eFS5wQZRij+uiFaHWwKDfiF3u3ajHfs Xcv8pqfNDaNMqx7W95urztTICwp9cHeYYCIBII9G5i0gh7jIi/dgYXpSO6fCLxaqI6Pz Y3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726635524; x=1727240324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=egxw4h7TVGRZa9tIbs1MSiQ6yUmfIbXvbyem5wLytJw=; b=ddKSEgA2XWh5DyIw8sYg9qwGQI0WW0HVsG33basvSEqihgmfkzY/Pcc+IjM/rnd8Ns b3IFtEnqV1JBsmBqagMoAC270vlDXuBiRCnSviaLqA7R0aF+q80KE8oNmcMPnoJ0Dpo5 R14JOGGoPVrjoNmhciJgwzG9cV5WvJrmKIO2KdoSoBJjZNbPdRXDvy0rau9af9dkh+S2 o/10stKkvIOHa9SkWdaFdgkTKpukwBWrAFJYYtVedobc25fSSQeM+Q/gnwH9990rxub2 fUtC6q8ghRTkY7cNqB9yTPzTKpS1QbkheaWBMJlqWA9D20iKOVSzixF0hetI9gShxXSL 0RIw== X-Gm-Message-State: AOJu0YwPA8fEXFJvdH4fpSzHVqC8fMOCHXq9xM0LJ8tlQz7jJMHIffnD rPFqmH8IQVlDB1/WkN5RfpPeye//It0AY49N5D1UohBXPWSkJJXtqEwdMFak/+FpKpfOaqzM3JQ c X-Google-Smtp-Source: AGHT+IHAp4lHTVaa9ukE/d3sYM3jb3zcx1ZJUTkmCgbRq+BsaDiv+r7Xakm70/VEo3RYyEiSBUeZvg== X-Received: by 2002:a17:902:c942:b0:202:47a4:7a1e with SMTP id d9443c01a7336-20781d5c6ddmr282373315ad.16.1726635523764; Tue, 17 Sep 2024 21:58:43 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20794746d76sm57179245ad.292.2024.09.17.21.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2024 21:58:43 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= Subject: [PATCH v23 05/15] eal: do not duplicate rte_init_alert() messages Date: Tue, 17 Sep 2024 21:56:10 -0700 Message-ID: <20240918045830.3798-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240918045830.3798-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20240918045830.3798-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 0ded386472..7c26393d00 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -840,8 +840,7 @@ static int rte_eal_vfio_setup(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* -- 2.45.2